lttng-dev.lists.lttng.org archive mirror
 help / color / mirror / Atom feed
From: Mathieu Desnoyers via lttng-dev <lttng-dev@lists.lttng.org>
To: Anders Wallin <wallinux@gmail.com>
Cc: lttng-dev <lttng-dev@lists.lttng.org>
Subject: Re: [lttng-dev] [PATCH lttng-tools] Fix: test code assumes that child process is schedule to run before parent
Date: Thu, 8 Apr 2021 08:48:15 -0400 (EDT)	[thread overview]
Message-ID: <621616245.61369.1617886095197.JavaMail.zimbra@efficios.com> (raw)
In-Reply-To: <CAF2baFcBgU+GH_yh5khVki1KHT8on90vNvPgnQxiWM6pwTbsLQ@mail.gmail.com>


[-- Attachment #1.1: Type: text/plain, Size: 4968 bytes --]

----- On Apr 8, 2021, at 5:22 AM, Anders Wallin <wallinux@gmail.com> wrote: 

> OK,

> I tried this and for
> - test_event_vpid_track_untrack ust 0 "${EVENT_NAME}"
> - test_event_pid_track_untrack ust 0 "${EVENT_NAME}"
> it works well.

> For
> - test_event_vpid_tracker ust 0 "${EVENT_NAME}"
> - test_event_pid_tracker ust 0 "${EVENT_NAME}"
> validate_trace_empty fails since there is no data at all in the trace_path

> This run is just calling copy of test_event_tracker running only
> "test_event_vpid_tracker ust 0 ..."
> 1..747
> # LTTng - Event tracker test
> ok 1 - Start session daemon
> # Test UST tracker
> ok 2 - Create session tracker in -o /tmp/tmp.lu5aeCJhQ3
> ok 3 - Enable ust event tp:tptest for session tracker
> ok 4 - Untrack command with opts: -u --all --vpid
> ok 5 - Start tracing for session
> ok 6 - Track command with opts: -u --vpid 11842
> ok 7 - Traced application stopped.
> ok 8 - Stop lttng tracing for session
> ok 9 - Destroy session tracker
> not ok 10 - Failed to parse trace
> # Failed test 'Failed to parse trace'
> # in ./regression/tools/tracker//../../../utils/tap/tap.sh:fail() at line 159.
> # Killing (signal SIGTERM) lttng-sessiond and lt-lttng-sessiond pids: 11808
> 11809 11830
> ok 11 - Wait after kill session daemon
> # Looks like you planned 747 tests but only ran 11.
> # Looks like you failed 1 test of 11.

> # find /tmp/tmp.lu5aeCJhQ3
> /tmp/tmp.lu5aeCJhQ3
> /tmp/tmp.lu5aeCJhQ3/ust

> Do you want me to add a special version of "validate_trace_empty" not returning
> "Failed to parse trace" for this? If so should it be added in
> "test_event_tracker" or in "utils.sh"

Actually, this helper already exists in utils.sh: validate_trace_session_ust_empty (), which 
internally uses validate_directory_empty (). As you point out, we should use 
validate_trace_session_ust_empty for the validation of those test cases which populate no 
trace whatsoever. 

Thanks, 

Mathieu 

> Anders Wallin

> On Wed, Apr 7, 2021 at 5:31 PM Mathieu Desnoyers < [
> mailto:mathieu.desnoyers@efficios.com | mathieu.desnoyers@efficios.com ] >
> wrote:

>> ----- On Apr 1, 2021, at 12:37 PM, lttng-dev [ mailto:lttng-dev@lists.lttng.org
>> | lttng-dev@lists.lttng.org ] wrote:

>> > the following tests fails
>> > - test_event_vpid_tracker ust 0 "${EVENT_NAME}"
>> > - test_event_vpid_track_untrack ust 0 "${EVENT_NAME}"
>> > - test_event_pid_tracker ust 0 "${EVENT_NAME}"
>> > - test_event_pid_track_untrack ust 0 "${EVENT_NAME}"

>> There is indeed an issue with these tests: there is a missing "untrack all pids"
>> which should be done at the very beginning of each test to have the expected
>> behavior. AFAIU this explains why there is a small window where traced
>> applications
>> can generate events when none are expected.

>> Fixing this should solve the issues without requiring any addition to the test
>> program.

>> Thanks,

>> Mathieu


>>> Signed-off-by: Anders Wallin < [ mailto:wallinux@gmail.com | wallinux@gmail.com
>> > ] >
>> > ---
>> > tests/regression/tools/tracker/test_event_tracker | 15 ++++++---------
>> > 1 file changed, 6 insertions(+), 9 deletions(-)

>> > diff --git a/tests/regression/tools/tracker/test_event_tracker
>> > b/tests/regression/tools/tracker/test_event_tracker
>> > index 711690af..78e9310b 100755
>> > --- a/tests/regression/tools/tracker/test_event_tracker
>> > +++ b/tests/regression/tools/tracker/test_event_tracker
>> > @@ -5,7 +5,7 @@
>> > #
>> > # SPDX-License-Identifier: GPL-2.0-only

>> > -TEST_DESC="LTTng - Event traker test"
>> > +TEST_DESC="LTTng - Event tracker test"

>> > CURDIR=$(dirname "$0")/
>> > TESTDIR="$CURDIR/../../.."
>> > @@ -30,27 +30,24 @@ SCRIPT_GROUPNAME="$(id -gn)"

>> > CHILD_PID=-1
>> > WAIT_PATH=
>> > -AFTER_FIRST_PATH=
>> > -BEFORE_LAST_PATH=
>> > +BEFORE_FIRST_PATH=

>> > source $TESTDIR/utils/utils.sh

>> > function prepare_ust_app
>> > {
>> > - AFTER_FIRST_PATH=$(mktemp -u)
>> > - BEFORE_LAST_PATH=$(mktemp -u)
>> > + BEFORE_FIRST_PATH=$(mktemp -u)

>> > - $TESTAPP_BIN -i $NR_ITER -w $NR_USEC_WAIT -a "$AFTER_FIRST_PATH" -b
>> > "$BEFORE_LAST_PATH" &
>> > + $TESTAPP_BIN -i $NR_ITER -w $NR_USEC_WAIT --sync-before-first-event
>> > "$BEFORE_FIRST_PATH" &
>> > CHILD_PID=$!
>> > }

>> > function trace_ust_app
>> > {
>> > - touch "$BEFORE_LAST_PATH"
>> > + touch "$BEFORE_FIRST_PATH"
>> > wait
>> > ok $? "Traced application stopped."
>> > - rm "$BEFORE_LAST_PATH"
>> > - rm "$AFTER_FIRST_PATH"
>> > + rm "$BEFORE_FIRST_PATH"
>> > }

>> > function prepare_kernel_app
>> > --
>> > 2.31.1

>> > _______________________________________________
>> > lttng-dev mailing list
>> > [ mailto:lttng-dev@lists.lttng.org | lttng-dev@lists.lttng.org ]
>>> [ https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev |
>> > https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev ]

>> --
>> Mathieu Desnoyers
>> EfficiOS Inc.
>> [ http://www.efficios.com/ | http://www.efficios.com ]

-- 
Mathieu Desnoyers 
EfficiOS Inc. 
http://www.efficios.com 

[-- Attachment #1.2: Type: text/html, Size: 7492 bytes --]

[-- Attachment #2: Type: text/plain, Size: 156 bytes --]

_______________________________________________
lttng-dev mailing list
lttng-dev@lists.lttng.org
https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev

  reply	other threads:[~2021-04-08 12:48 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-01 16:37 Anders Wallin via lttng-dev
2021-04-07 15:31 ` Mathieu Desnoyers via lttng-dev
2021-04-08  9:22   ` Anders Wallin via lttng-dev
2021-04-08 12:48     ` Mathieu Desnoyers via lttng-dev [this message]
2021-04-08 15:47       ` Anders Wallin via lttng-dev
  -- strict thread matches above, loose matches on Subject: below --
2021-04-09 14:41 Anders Wallin via lttng-dev
2021-04-09 19:12 ` Mathieu Desnoyers via lttng-dev
2021-03-31 18:56 Anders Wallin via lttng-dev
2021-03-31 19:25 ` Jonathan Rajotte-Julien via lttng-dev
2021-03-31 21:09   ` Anders Wallin via lttng-dev
2021-03-31 21:33     ` Jonathan Rajotte-Julien via lttng-dev
2021-04-01  1:21       ` Anders Wallin via lttng-dev
2021-04-01 13:45         ` Jonathan Rajotte-Julien via lttng-dev
2021-04-01 15:02           ` Anders Wallin via lttng-dev
2021-04-01 16:19 ` Mathieu Desnoyers via lttng-dev
2021-04-01 16:21   ` Mathieu Desnoyers via lttng-dev
2021-04-01 16:33   ` Anders Wallin via lttng-dev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=621616245.61369.1617886095197.JavaMail.zimbra@efficios.com \
    --to=lttng-dev@lists.lttng.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=wallinux@gmail.com \
    --subject='Re: [lttng-dev] [PATCH lttng-tools] Fix: test code assumes that child process is schedule to run before parent' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).