From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rocky Dunlap via lttng-dev Subject: Re: Babeltrace2 - compilation error with intel18 Date: Mon, 23 Mar 2020 10:56:32 -0600 Message-ID: References: <60fcd0f0-e89c-5e04-8185-8cf34a92fe04@simark.ca> <4bc0ec69-7587-fe58-691f-5cb23a11cd43@simark.ca> <1c4447ea-b67a-eaf0-c9dd-d2c10106b5a7@simark.ca> <5f7d96c7-bf73-3ef6-012d-27dd8812361a@simark.ca> Reply-To: Rocky Dunlap Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5136610679899477666==" Return-path: Received: from mail-oi1-x235.google.com (mail-oi1-x235.google.com [IPv6:2607:f8b0:4864:20::235]) by lists.lttng.org (Postfix) with ESMTPS id 48mLBn2Qzdz1R2v for ; Mon, 23 Mar 2020 12:56:48 -0400 (EDT) Received: by mail-oi1-x235.google.com with SMTP id k8so15499809oik.2 for ; Mon, 23 Mar 2020 09:56:48 -0700 (PDT) In-Reply-To: <5f7d96c7-bf73-3ef6-012d-27dd8812361a@simark.ca> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: lttng-dev-bounces@lists.lttng.org Sender: "lttng-dev" To: Simon Marchi Cc: lttng-dev@lists.lttng.org List-Id: lttng-dev@lists.lttng.org --===============5136610679899477666== Content-Type: multipart/alternative; boundary="000000000000556b0105a18885a8" --000000000000556b0105a18885a8 Content-Type: text/plain; charset="UTF-8" Simon, Success! This change worked and I was able to build and install with icc. Thank you! I still get a lot of warnings during the build (see below) which seems like configure should work these out ahead of time. They are easy enough to ignore, but if support for intel is added, it would be nice to have these cleaned up. For what it's worth, adding support for additional compilers in my experience has greatly improved the quality of library code - it tends to snuff out those bugs that are hard to find on a single compiler. If you decide to merge this in, a release patch 2.0.3 would certainly be helpful as well! Example warnings below: icc: command line warning #10006: ignoring unknown option '-Wnested-externs' icc: command line warning #10006: ignoring unknown option '-Wtautological-constant-out-of-range-compare' icc: command line warning #10006: ignoring unknown option '-Wnested-externs' icc: command line warning #10006: ignoring unknown option '-Wno-format-nonliteral' icc: command line warning #10006: ignoring unknown option '-Wno-format-nonliteral' icc: command line warning #10006: ignoring unknown option '-Wmissing-noreturn' icc: command line warning #10006: ignoring unknown option '-Wmissing-noreturn' icc: command line warning #10006: ignoring unknown option '-Wduplicated-cond' icc: command line warning #10006: ignoring unknown option '-Wduplicated-branches' icc: command line warning #10006: ignoring unknown option '-Wduplicated-cond' icc: command line warning #10006: ignoring unknown option '-Wduplicated-branches' icc: command line warning #10006: ignoring unknown option '-Wlogical-op' icc: command line warning #10006: ignoring unknown option '-Wlogical-op' icc: command line warning #10006: ignoring unknown option '-Wno-cast-function-type' icc: command line warning #10006: ignoring unknown option '-Wno-cast-function-type' icc: command line warning #10006: ignoring unknown option '-Wnull-dereference' icc: command line warning #10006: ignoring unknown option '-Wredundant-decls' icc: command line warning #10006: ignoring unknown option '-Wjump-misses-init' icc: command line warning #10006: ignoring unknown option '-Wsuggest-attribute=format' icc: command line warning #10006: ignoring unknown option '-Wtautological-constant-out-of-range-compare' icc: command line warning #10006: ignoring unknown option '-Wnested-externs' icc: command line warning #10006: ignoring unknown option '-Wno-format-nonliteral' icc: command line warning #10006: ignoring unknown option '-Wmissing-noreturn' icc: command line warning #10006: ignoring unknown option '-Wduplicated-cond' icc: command line warning #10006: ignoring unknown option '-Wduplicated-branches' icc: command line warning #10006: ignoring unknown option '-Wlogical-op' icc: command line warning #10006: ignoring unknown option '-Wno-cast-function-type' icc: command line warning #10006: ignoring unknown option '-Wnull-dereference' icc: command line warning #10006: ignoring unknown option '-Wredundant-decls' icc: command line warning #10006: ignoring unknown option '-Wjump-misses-init' icc: command line warning #10006: ignoring unknown option '-Wsuggest-attribute=format' icc: command line warning #10006: ignoring unknown option '-Wtautological-constant-out-of-range-compare' On Mon, Mar 23, 2020 at 10:14 AM Simon Marchi wrote: > On 2020-03-23 12:05 p.m., Rocky Dunlap wrote: > > Simon, > > > > Yes, I will be happy to give this a try. What's the easiest way to get > this patch? (Sorry, I'm less familiar with Gerrit...) > > > > Rocky > > You need a babeltrace git repository. If you don't already have one, you > can clone it from here: > > https://github.com/efficios/babeltrace > > You can then click the "DOWNLOAD" button on the patch's review page, or > press `d` (a keybinding). > > Copy the "Checkout" command (the first one) and paste it in your shell > (while having the > repository as the current working directory). You'll then have the code > corresponding to > the proposed patch checked out and ready to build. Note that when you > build from the git > repo, you need to run ./bootstrap first, to generate the configure script. > > Simon > > --000000000000556b0105a18885a8 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Simon,

Success!=C2=A0 This change worke= d and I was able to build and install with icc.=C2=A0 Thank you!
=
I still get a lot of warnings during the build (see below) w= hich seems like configure should work these out ahead of time.=C2=A0 They a= re easy enough to ignore, but if support for intel is added, it would be ni= ce to have these cleaned up.=C2=A0 For what it's worth, adding support = for additional compilers in my experience has greatly improved the quality = of library code - it tends to snuff out those bugs that are hard to find on= a single compiler.=C2=A0=C2=A0

If you decide to m= erge this in, a release patch 2.0.3 would certainly be helpful as well!


Example warnings below:
icc:= command line warning #10006: ignoring unknown option '-Wnested-externs= '
icc: command line warning #10006: ignoring unknown option '-Wt= autological-constant-out-of-range-compare'
icc: command line warning= #10006: ignoring unknown option '-Wnested-externs'
icc: command= line warning #10006: ignoring unknown option '-Wno-format-nonliteral&#= 39;
icc: command line warning #10006: ignoring unknown option '-Wno-= format-nonliteral'
icc: command line warning #10006: ignoring unknow= n option '-Wmissing-noreturn'
icc: command line warning #10006: = ignoring unknown option '-Wmissing-noreturn'
icc: command line w= arning #10006: ignoring unknown option '-Wduplicated-cond'
icc: = command line warning #10006: ignoring unknown option '-Wduplicated-bran= ches'
icc: command line warning #10006: ignoring unknown option '= ;-Wduplicated-cond'
icc: command line warning #10006: ignoring unkno= wn option '-Wduplicated-branches'
icc: command line warning #100= 06: ignoring unknown option '-Wlogical-op'
icc: command line war= ning #10006: ignoring unknown option '-Wlogical-op'
icc: command= line warning #10006: ignoring unknown option '-Wno-cast-function-type&= #39;
icc: command line warning #10006: ignoring unknown option '-Wno= -cast-function-type'
icc: command line warning #10006: ignoring unkn= own option '-Wnull-dereference'
icc: command line warning #10006= : ignoring unknown option '-Wredundant-decls'
icc: command line = warning #10006: ignoring unknown option '-Wjump-misses-init'
icc= : command line warning #10006: ignoring unknown option '-Wsuggest-attri= bute=3Dformat'
icc: command line warning #10006: ignoring unknown op= tion '-Wtautological-constant-out-of-range-compare'
icc: command= line warning #10006: ignoring unknown option '-Wnested-externs'icc: command line warning #10006: ignoring unknown option '-Wno-format= -nonliteral'
icc: command line warning #10006: ignoring unknown opti= on '-Wmissing-noreturn'
icc: command line warning #10006: ignori= ng unknown option '-Wduplicated-cond'
icc: command line warning = #10006: ignoring unknown option '-Wduplicated-branches'
icc: com= mand line warning #10006: ignoring unknown option '-Wlogical-op'icc: command line warning #10006: ignoring unknown option '-Wno-cast-f= unction-type'
icc: command line warning #10006: ignoring unknown opt= ion '-Wnull-dereference'
icc: command line warning #10006: ignor= ing unknown option '-Wredundant-decls'
icc: command line warning= #10006: ignoring unknown option '-Wjump-misses-init'
icc: comma= nd line warning #10006: ignoring unknown option '-Wsuggest-attribute=3D= format'
icc: command line warning #10006: ignoring unknown option &#= 39;-Wtautological-constant-out-of-range-compare'


On Mon, Mar 23, 2020 at 10:14 AM Simon Marchi <simark@simark.ca> wrote:
On 2020-03-23 12:05 p.m., Rocky Dunlap wrote:<= br> > Simon,
>
> Yes, I will be happy to give this a try.=C2=A0 What's the easiest = way to get this patch?=C2=A0 (Sorry, I'm less familiar with Gerrit...)<= br> >
> Rocky

You need a babeltrace git repository.=C2=A0 If you don't already have o= ne, you can clone it from here:

=C2=A0 https://github.com/efficios/babeltrace

You can then click the "DOWNLOAD" button on the patch's revie= w page, or press `d` (a keybinding).

Copy the "Checkout" command (the first one) and paste it in your = shell (while having the
repository as the current working directory).=C2=A0 You'll then have th= e code corresponding to
the proposed patch checked out and ready to build.=C2=A0 Note that when you= build from the git
repo, you need to run ./bootstrap first, to generate the configure script.<= br>
Simon

--000000000000556b0105a18885a8-- --===============5136610679899477666== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ lttng-dev mailing list lttng-dev@lists.lttng.org https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev --===============5136610679899477666==--