From: NeilBrown <neilb@suse.com> To: lustre-devel@lists.lustre.org Subject: [lustre-devel] [PATCH 02/37] lustre: llite: don't use class_setup_tunables() Date: Tue, 19 Feb 2019 11:09:04 +1100 Message-ID: <155053494490.24125.1514109985903155907.stgit@noble.brown> (raw) In-Reply-To: <155053473693.24125.6976971762921761309.stgit@noble.brown> llite_kobj does not benefit from being in the lustre_kset kset (though it does need lustre_kset as a parent) It also does not need the class_ktype type, as dynamic_kobj_ktype is sufficient. So use the simple kobject_create_and_add() to initialize it. This provides flexibility for making changes to class_setup_tunables(). Signed-off-by: NeilBrown <neilb@suse.com> --- drivers/staging/lustre/lustre/llite/lproc_llite.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lustre/llite/lproc_llite.c b/drivers/staging/lustre/lustre/llite/lproc_llite.c index 8215296dc15d..78ec0fa65c58 100644 --- a/drivers/staging/lustre/lustre/llite/lproc_llite.c +++ b/drivers/staging/lustre/lustre/llite/lproc_llite.c @@ -46,7 +46,7 @@ int llite_tunables_register(void) { int rc = 0; - llite_kobj = class_setup_tunables("llite"); + llite_kobj = kobject_create_and_add("llite", &lustre_kset->kobj); if (IS_ERR(llite_kobj)) return PTR_ERR(llite_kobj);
next prev parent reply index Thread overview: 105+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-02-19 0:09 [lustre-devel] [PATCH 00/37] More lustre patches from obdclass NeilBrown 2019-02-19 0:09 ` [lustre-devel] [PATCH 01/37] lustre: obdclass: char obd_ioctl_getdata type NeilBrown 2019-02-24 18:35 ` James Simmons 2019-02-19 0:09 ` NeilBrown [this message] 2019-02-24 16:35 ` [lustre-devel] [PATCH 02/37] lustre: llite: don't use class_setup_tunables() James Simmons 2019-02-25 22:27 ` NeilBrown 2019-02-26 22:18 ` James Simmons 2019-02-24 16:52 ` [lustre-devel] [PATCH 03/37] lustre: embed typ_kobj if obd_type James Simmons 2019-02-25 22:38 ` NeilBrown 2019-02-26 20:41 ` Simmons, James A. 2019-02-19 0:09 ` [lustre-devel] [PATCH 14/37] lustre: llog: change lgh_refcount to struct kref NeilBrown 2019-02-25 18:16 ` Andreas Dilger 2019-02-19 0:09 ` [lustre-devel] [PATCH 13/37] lustre: llog: remove lgh_hdr_lock NeilBrown 2019-02-24 20:29 ` James Simmons 2019-02-25 18:16 ` Andreas Dilger 2019-02-19 0:09 ` [lustre-devel] [PATCH 07/37] lustre: obd_type: discard obd_type_lock NeilBrown 2019-02-24 17:02 ` James Simmons 2019-02-19 0:09 ` [lustre-devel] [PATCH 08/37] lustre: obdclass: don't copy ops structures in to new type NeilBrown 2019-02-24 17:03 ` James Simmons 2019-02-19 0:09 ` [lustre-devel] [PATCH 16/37] lustre: obdclass: typo: Banlance -> Balance NeilBrown 2019-02-24 17:39 ` James Simmons 2019-02-19 0:09 ` [lustre-devel] [PATCH 05/37] lustre: obd_type: use typ_kobj.name as typ_name NeilBrown 2019-02-24 16:56 ` James Simmons 2019-02-19 0:09 ` [lustre-devel] [PATCH 03/37] lustre: embed typ_kobj if obd_type NeilBrown 2019-02-19 0:09 ` [lustre-devel] [PATCH 09/37] lustre: obdclass: fix module load locking NeilBrown 2019-02-24 17:04 ` James Simmons 2019-02-19 0:09 ` [lustre-devel] [PATCH 17/37] lustre: simplify lprocfs_read_frac_helper NeilBrown 2019-02-24 17:52 ` James Simmons 2019-02-26 23:59 ` NeilBrown 2019-02-27 1:06 ` Andreas Dilger 2019-02-19 0:09 ` [lustre-devel] [PATCH 18/37] lustre: obdclass: discard lprocfs_single/seq_release NeilBrown 2019-02-24 17:53 ` James Simmons 2019-02-19 0:09 ` [lustre-devel] [PATCH 12/37] lustre: remove unused function in linkea NeilBrown 2019-02-25 18:16 ` Andreas Dilger 2019-02-19 0:09 ` [lustre-devel] [PATCH 10/37] lustre: kernelcomm: pass correct gfp_t to kmalloc NeilBrown 2019-02-24 17:05 ` James Simmons 2019-02-25 18:16 ` Andreas Dilger 2019-02-19 0:09 ` [lustre-devel] [PATCH 21/37] lustre: remove several MAX_STRING_SIZE defines NeilBrown 2019-02-24 19:07 ` James Simmons 2019-02-27 0:41 ` NeilBrown 2019-02-25 18:16 ` Andreas Dilger 2019-02-19 0:09 ` [lustre-devel] [PATCH 19/37] lustre: discard lprocfs_strnstr() NeilBrown 2019-02-24 17:53 ` James Simmons 2019-02-19 0:09 ` [lustre-devel] [PATCH 15/37] lustre: llog_obd: Convert loc_refcount to refcount_t NeilBrown 2019-02-25 18:16 ` Andreas Dilger 2019-02-19 0:09 ` [lustre-devel] [PATCH 11/37] lustre: kernelcomm: make libcfs_kkuc_msg_put static NeilBrown 2019-02-24 17:15 ` James Simmons 2019-02-26 23:45 ` NeilBrown 2019-02-27 22:36 ` James Simmons 2019-02-27 22:37 ` James Simmons 2019-02-19 0:09 ` [lustre-devel] [PATCH 04/37] lustre: collect all resource releasing for obj_type NeilBrown 2019-02-24 16:54 ` James Simmons 2019-02-19 0:09 ` [lustre-devel] [PATCH 06/37] lustre: obd_type: discard obd_types linked list NeilBrown 2019-02-24 17:00 ` James Simmons 2019-02-19 0:09 ` [lustre-devel] [PATCH 20/37] lustre: convert rsi_sem to a spinlock NeilBrown 2019-02-25 18:16 ` Andreas Dilger 2019-02-27 0:22 ` NeilBrown 2019-02-27 1:00 ` Andreas Dilger 2019-02-19 0:09 ` [lustre-devel] [PATCH 32/37] lustre: portals_handle: rename ops to owner NeilBrown 2019-02-19 0:09 ` [lustre-devel] [PATCH 22/37] lustre: lprocfs: use log2.h macros instead of shift loop NeilBrown 2019-02-24 18:09 ` James Simmons 2019-02-26 20:55 ` James Simmons 2019-02-27 0:51 ` NeilBrown 2019-02-27 0:54 ` Andreas Dilger 2019-02-19 0:09 ` [lustre-devel] [PATCH 25/37] lustre: deprecate libcfs_debug_vmsg2 NeilBrown 2019-02-24 20:02 ` James Simmons 2019-02-25 18:16 ` Andreas Dilger 2019-02-19 0:09 ` [lustre-devel] [PATCH 30/37] lustre: handle: move refcount into the lustre_handle NeilBrown 2019-02-27 6:32 ` Andreas Dilger 2019-02-27 21:48 ` NeilBrown 2019-02-27 22:14 ` Andreas Dilger 2019-02-19 0:09 ` [lustre-devel] [PATCH 28/37] lustre: remove scope and source from class_incref and class_decref NeilBrown 2019-02-27 6:52 ` Andreas Dilger 2019-02-28 0:39 ` NeilBrown 2019-02-19 0:09 ` [lustre-devel] [PATCH 26/37] lustre: remove libcfs_debug_vmsg2 NeilBrown 2019-02-25 18:16 ` Andreas Dilger 2019-02-19 0:09 ` [lustre-devel] [PATCH 23/37] lustre: prefer to use tabs for alignment NeilBrown 2019-02-24 18:51 ` James Simmons 2019-02-25 18:16 ` Andreas Dilger 2019-02-19 0:09 ` [lustre-devel] [PATCH 27/37] lustre: discard lu_ref NeilBrown 2019-02-24 20:28 ` James Simmons 2019-02-27 1:17 ` NeilBrown 2019-02-27 5:35 ` Andreas Dilger 2019-03-01 6:45 ` Mike Pershin 2019-02-19 0:09 ` [lustre-devel] [PATCH 29/37] lustre: handles: discard h_owner in favour of h_ops NeilBrown 2019-02-27 6:37 ` Andreas Dilger 2019-02-27 21:41 ` NeilBrown 2019-02-28 6:41 ` Andreas Dilger 2019-02-19 0:09 ` [lustre-devel] [PATCH 33/37] lustre: portals_handle: remove locking from class_handle2object() NeilBrown 2019-02-19 0:09 ` [lustre-devel] [PATCH 34/37] lustre: portals_handle: use hlist for hash lists NeilBrown 2019-02-19 0:09 ` [lustre-devel] [PATCH 31/37] lustre: discard OBD_FREE_RCU NeilBrown 2019-02-19 0:09 ` [lustre-devel] [PATCH 24/37] lustre: lu_object: remove extra newline from debug printing NeilBrown 2019-02-24 19:08 ` James Simmons 2019-02-25 18:16 ` Andreas Dilger 2019-02-19 0:09 ` [lustre-devel] [PATCH 35/37] lustre: portals_handle: discard h_lock NeilBrown 2019-02-19 0:09 ` [lustre-devel] [PATCH 37/37] lustre: obd_sysfs: error-check value stored in jobid_var NeilBrown 2019-02-27 6:17 ` Andreas Dilger 2019-03-01 2:35 ` NeilBrown 2019-03-01 8:32 ` Andreas Dilger 2019-03-01 14:30 ` Patrick Farrell 2019-03-14 0:34 ` NeilBrown 2019-03-14 14:12 ` Patrick Farrell 2019-03-14 22:56 ` NeilBrown 2019-03-14 23:05 ` Andreas Dilger 2019-02-19 0:09 ` [lustre-devel] [PATCH 36/37] lustre: remove unused fields from struct obd_device NeilBrown
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=155053494490.24125.1514109985903155907.stgit@noble.brown \ --to=neilb@suse.com \ --cc=lustre-devel@lists.lustre.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Lustre-devel archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/lustre-devel/0 lustre-devel/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 lustre-devel lustre-devel/ https://lore.kernel.org/lustre-devel \ lustre-devel@lists.lustre.org public-inbox-index lustre-devel Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.lustre.lists.lustre-devel AGPL code for this site: git clone https://public-inbox.org/public-inbox.git