Re: [PATCH 09/13] HID: playstation: add DualSense lightbar support

From: "Barnabás Pőcze" <pobrn@protonmail.com>
To: Roderick Colenbrander <roderick@gaikai.com>
Cc: Jiri Kosina <jikos@kernel.org>,
	Benjamin Tissoires <benjamin.tissoires@redhat.com>,
	"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
	Chris Ye <lzye@google.com>,
	Roderick Colenbrander <roderick.colenbrander@sony.com>
Subject: Re: [PATCH 09/13] HID: playstation: add DualSense lightbar support
Date: Tue, 29 Dec 2020 18:59:38 +0000	[thread overview]
Message-ID: <mc1Un9RZANQ4yIfAjCv3ziQaVjEBZ6FYCWJjSygax6AZ5L0VS01uBxkmG3kGWYT2_Sf12jQ62ZVG8pwhZUqc7C9Z0L60ZwaONDkoDMhH0Yc=@protonmail.com> (raw)
In-Reply-To: <CANndSK=LSFyAf-7BfXJkCVrFcd7Auy64Wtqh65de6T7FkDN1Hw@mail.gmail.com>

2020. december 28., hétfő 22:26 keltezéssel, Roderick Colenbrander írta:

> [...]
> > > +/* Create a DualSense/DualShock4 RGB lightbar represented by a multicolor LED. */
> > > +static struct led_classdev_mc *ps_lightbar_create(struct ps_device *ps_dev,
> > > +     int (*brightness_set)(struct led_classdev *, enum led_brightness))
> > > +{
> > > +     struct hid_device *hdev = ps_dev->hdev;
> > > +     struct led_classdev_mc *lightbar_mc_dev;
> > > +     struct mc_subled *mc_led_info;
> > > +     struct led_classdev *led_cdev;
> > > +     int ret;
> > > +
> > > +     lightbar_mc_dev = devm_kzalloc(&hdev->dev, sizeof(*lightbar_mc_dev), GFP_KERNEL);
> > > +     if (!lightbar_mc_dev)
> > > +             return ERR_PTR(-ENOMEM);
> > > +
> > > +     mc_led_info = devm_kzalloc(&hdev->dev, 3*sizeof(*mc_led_info), GFP_KERNEL);
> > > +     if (!mc_led_info)
> > > +             return ERR_PTR(-ENOMEM);
> > > +
> >
> > Is there any reason why these are dynamically allocated?
>
> No particular reason. I should probably at least not dynamically
> allocate 'mc_dev' and pass it in similar to regular LED registration
> (previously I had my regular LEDs dynamically allocated). The
> mc_led_info I will probably keep dynamic. It feels a bit nasty to have
> the caller be aware of these internal details.
> [...]

Could you please elaborate what you mean by "It feels a bit nasty to have
the caller be aware of these internal details."? I don't think I fully understand
what you're referring to.