Re: [PATCH 1/5] drm/i915: Drop WA 16015675438

From: Lucas De Marchi <lucas.demarchi@intel.com>
To: Matt Roper <matthew.d.roper@intel.com>
Cc: <intel-gfx@lists.freedesktop.org>,
	<dri-devel@lists.freedesktop.org>,
	Mateusz Jablonski <mateusz.jablonski@intel.com>,
	Michal Mrozek <michal.mrozek@intel.com>,
	Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: Re: [PATCH 1/5] drm/i915: Drop WA 16015675438
Date: Tue, 12 Mar 2024 18:47:58 -0500	[thread overview]
Message-ID: <mgydv3afrxdraulzba2e3q27uyvm5qnhhvv2wddjbw4gcgqlck@2on6hfp7n2b6> (raw)
In-Reply-To: <20240312225409.GM718896@mdroper-desk1.amr.corp.intel.com>

On Tue, Mar 12, 2024 at 03:54:09PM -0700, Matt Roper wrote:
>On Wed, Mar 06, 2024 at 11:36:39AM -0800, Lucas De Marchi wrote:
>> With dynamic load-balancing disabled on the compute side, there's no
>> reason left to enable WA 16015675438. Drop it from both PVC and DG2.
>> Note that this can be done because now the driver always set a fixed
>> partition of EUs during initialization via the ccs_mode configuration.
>>
>> The flag to GuC is still needed because of 18020744125, so update
>> the comment accordingly.
>>
>> Cc: Mateusz Jablonski <mateusz.jablonski@intel.com>
>> Cc: Michal Mrozek <michal.mrozek@intel.com>
>> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
>> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
>
>Dynamic load-balancing disable hasn't landed in i915 yet (although it
>probably will soon).  Assuming we wait for that to happen first before
>applying this,
>
>        Reviewed-by: Matt Roper <matthew.d.roper@intel.com>

Humn... I probably grepped the wrong tree for this one since I was
seeing ccs_mode being set. Indeed it isn't :-/, so I will have to land a
fix or revert since this patch already landed a few days ago.

Lucas De Marchi