From: Jeffrey Hugo <quic_jhugo@quicinc.com>
To: <loic.poulain@linaro.org>, <mani@kernel.org>,
<quic_hemantk@quicinc.com>, <quic_bbhatt@quicinc.com>
Cc: <mhi@lists.linux.dev>, <linux-arm-msm@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
Jeffrey Hugo <quic_jhugo@quicinc.com>
Subject: [PATCH v3 0/2] MHI MMIO register write updates
Date: Wed, 13 Apr 2022 09:56:44 -0600 [thread overview]
Message-ID: <1649865406-30198-1-git-send-email-quic_jhugo@quicinc.com> (raw)
In case of MHI MMIO writes, the register field write function needs to do reads
before writes are performed. Propagate read failures such that callers are made
aware of those and can take appropriate action instead of running blind.
Optimizing the MMIO initialization function to use mhi_write_reg() in most cases
should also be done to improve design.
These patches were tested on X86_64 architecture with Ubuntu 18.04 and SDX65
attach.
v3:
Noticed this was reviewed but never picked up. Rebased to -next
v2:
-Fix testbot reported missing set of changes from pm.c
Bhaumik Bhatt (2):
bus: mhi: host: Bail on writing register fields if read fails
bus: mhi: host: Optimize and update MMIO register write method
drivers/bus/mhi/host/boot.c | 21 +++++++++----
drivers/bus/mhi/host/init.c | 68 ++++++++++++++++++++++++-----------------
drivers/bus/mhi/host/internal.h | 7 +++--
drivers/bus/mhi/host/main.c | 9 ++++--
drivers/bus/mhi/host/pm.c | 15 ++++++---
5 files changed, 76 insertions(+), 44 deletions(-)
--
2.7.4
next reply other threads:[~2022-04-13 15:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-13 15:56 Jeffrey Hugo [this message]
2022-04-13 15:56 ` [PATCH v3 1/2] bus: mhi: host: Bail on writing register fields if read fails Jeffrey Hugo
2022-04-18 6:05 ` Manivannan Sadhasivam
2022-04-13 15:56 ` [PATCH v3 2/2] bus: mhi: host: Optimize and update MMIO register write method Jeffrey Hugo
2022-04-18 6:08 ` Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1649865406-30198-1-git-send-email-quic_jhugo@quicinc.com \
--to=quic_jhugo@quicinc.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=mani@kernel.org \
--cc=mhi@lists.linux.dev \
--cc=quic_bbhatt@quicinc.com \
--cc=quic_hemantk@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).