From: Manivannan Sadhasivam <mani@kernel.org>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
hemantk@codeaurora.org, bbhatt@codeaurora.org,
loic.poulain@linaro.org, wangqing@vivo.com, mhi@lists.linux.dev,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] bus: mhi: replace snprintf in show functions with sysfs_emit
Date: Sat, 16 Oct 2021 21:49:56 +0530 [thread overview]
Message-ID: <20211016161956.GB4048@thinkpad> (raw)
In-Reply-To: <YWqBTj4slHq7HexS@kroah.com>
On Sat, Oct 16, 2021 at 09:37:50AM +0200, Greg KH wrote:
> On Sat, Oct 16, 2021 at 12:27:34PM +0530, Manivannan Sadhasivam wrote:
> > From: Qing Wang <wangqing@vivo.com>
> >
> > coccicheck complains about the use of snprintf() in sysfs show functions.
> >
> > Fix the following coccicheck warning:
> > drivers/bus/mhi/core/init.c:97:8-16: WARNING: use scnprintf or sprintf.
> >
> > Use sysfs_emit instead of scnprintf or sprintf makes more sense.
> >
> > Signed-off-by: Qing Wang <wangqing@vivo.com>
> > Reviewed-by: Hemant Kumar <hemantk@codeaurora.org>
> > Reviewed-by: Manivannan Sadhasivam <mani@kernel.org>
> > Link: https://lore.kernel.org/r/1634095550-3978-1-git-send-email-wangqing@vivo.com
> > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> > ---
> > drivers/bus/mhi/core/init.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/bus/mhi/core/init.c b/drivers/bus/mhi/core/init.c
> > index 5aaca6d0f52b..a5a5c722731e 100644
> > --- a/drivers/bus/mhi/core/init.c
> > +++ b/drivers/bus/mhi/core/init.c
> > @@ -94,7 +94,7 @@ static ssize_t serial_number_show(struct device *dev,
> > struct mhi_device *mhi_dev = to_mhi_device(dev);
> > struct mhi_controller *mhi_cntrl = mhi_dev->mhi_cntrl;
> >
> > - return snprintf(buf, PAGE_SIZE, "Serial Number: %u\n",
> > + return sysfs_emit(buf, "Serial Number: %u\n",
> > mhi_cntrl->serial_number);
>
> The text "Serial Number: " should not be in here, right? It's obvious
> this is a serial number, that's what the documentation and file name
> says. Userspace should not have to parse sysfs files.
>
Right, somehow missed it :/
> And why is only one sysfs entry being changed in this file? Either they
> all should be, or none, no need to do this one-patch-per-entry, right?
>
> Note, I have rejected Qing's patches like this for other subsystems
> already because they are not complete, this is something they are well
> aware of by now...
>
Oh, I'm not aware of this.
Qing: Please modify the other instance of snprintf also.
Thanks,
Mani
> thanks,
>
> greg k-h
next prev parent reply other threads:[~2021-10-16 16:20 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-16 6:57 [PATCH 0/3] MHI patches for v5.16 Manivannan Sadhasivam
2021-10-16 6:57 ` [PATCH 1/3] MAINTAINERS: Update the entry for MHI bus Manivannan Sadhasivam
2021-10-16 7:34 ` Greg KH
2021-10-19 4:19 ` Hemant Kumar
2021-10-19 12:24 ` Greg KH
2021-10-19 13:26 ` Manivannan Sadhasivam
2021-10-16 6:57 ` [PATCH 2/3] bus: mhi: Add inbound buffers allocation flag Manivannan Sadhasivam
2021-10-16 7:39 ` Greg KH
2021-10-16 16:31 ` Manivannan Sadhasivam
2021-10-17 7:07 ` Greg KH
2021-10-16 6:57 ` [PATCH 3/3] bus: mhi: replace snprintf in show functions with sysfs_emit Manivannan Sadhasivam
2021-10-16 7:37 ` Greg KH
2021-10-16 10:24 ` Joe Perches
2021-10-16 15:07 ` Greg KH
2021-10-16 15:13 ` Joe Perches
2021-10-16 16:15 ` Manivannan Sadhasivam
2021-10-19 4:30 ` Hemant Kumar
2021-10-16 16:19 ` Manivannan Sadhasivam [this message]
2021-10-16 7:00 ` [PATCH 0/3] MHI patches for v5.16 Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211016161956.GB4048@thinkpad \
--to=mani@kernel.org \
--cc=bbhatt@codeaurora.org \
--cc=gregkh@linuxfoundation.org \
--cc=hemantk@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=mhi@lists.linux.dev \
--cc=wangqing@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).