From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 38F852F44 for ; Fri, 28 Oct 2022 17:20:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id ED407C433C1; Fri, 28 Oct 2022 17:20:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1666977630; bh=kqTt1deJK2agJjmjKfnohy/X48Cpk74KPQ7q6QI2i8U=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=JmEy3lPBrsVtVzbPd1YHA5FhcaWqnzp5iE3MxBAyWXeAjIXo/JHKaoXJR3u0mRYca 2NeAvTaPUPUclJylcqTqD72LMeL36W8RDjTOfSh/d2183eQqt0U6jZ3Ug+pooPa+mY l4fFVoPUcK5iNbkf/Cb4AvxQOOFZaMyGs/H302mVKbxF+FSewyzpLw5KcPknpXTt+x Ayp9r1ldvlLQOrpjuND11HE2A4ARJewDFl2JiTDni6TO/T+x14YQlCbmdDtbOdEmMo Wj2Ypa5F3W1k4bSKt0Yyliv5nl80K6EQLEUgIGEDdDipqsW6OI+k5+ph2wISbhh4e1 iLHe2Od9ZBV1Q== Date: Fri, 28 Oct 2022 22:50:22 +0530 From: Manivannan Sadhasivam To: Qiang Yu Cc: quic_hemantk@quicinc.com, loic.poulain@linaro.org, mhi@lists.linux.dev, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, quic_cang@quicinc.com, mrana@quicinc.com Subject: Re: [PATCH] bus: mhi: host: Add session ID to MHI controller Message-ID: <20221028172022.GC13880@thinkpad> References: <1665376870-60668-1-git-send-email-quic_qianyu@quicinc.com> Precedence: bulk X-Mailing-List: mhi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1665376870-60668-1-git-send-email-quic_qianyu@quicinc.com> On Mon, Oct 10, 2022 at 12:41:10PM +0800, Qiang Yu wrote: > Session ID to be used during BHI transfers to recognize a > particular session are currently not being stored in the MHI > controller structure. Store them to allow for tracking and other > future usage. > > Signed-off-by: Qiang Yu Who/what is going to use this session id? Thanks, Mani > --- > drivers/bus/mhi/host/boot.c | 8 ++++---- > include/linux/mhi.h | 1 + > 2 files changed, 5 insertions(+), 4 deletions(-) > > diff --git a/drivers/bus/mhi/host/boot.c b/drivers/bus/mhi/host/boot.c > index 26d0edd..5bed8b51 100644 > --- a/drivers/bus/mhi/host/boot.c > +++ b/drivers/bus/mhi/host/boot.c > @@ -231,7 +231,7 @@ static int mhi_fw_load_bhi(struct mhi_controller *mhi_cntrl, > dma_addr_t dma_addr, > size_t size) > { > - u32 tx_status, val, session_id; > + u32 tx_status, val; > int i, ret; > void __iomem *base = mhi_cntrl->bhi; > rwlock_t *pm_lock = &mhi_cntrl->pm_lock; > @@ -253,16 +253,16 @@ static int mhi_fw_load_bhi(struct mhi_controller *mhi_cntrl, > goto invalid_pm_state; > } > > - session_id = MHI_RANDOM_U32_NONZERO(BHI_TXDB_SEQNUM_BMSK); > + mhi_cntrl->session_id = MHI_RANDOM_U32_NONZERO(BHI_TXDB_SEQNUM_BMSK); > dev_dbg(dev, "Starting image download via BHI. Session ID: %u\n", > - session_id); > + mhi_cntrl->session_id); > mhi_write_reg(mhi_cntrl, base, BHI_STATUS, 0); > mhi_write_reg(mhi_cntrl, base, BHI_IMGADDR_HIGH, > upper_32_bits(dma_addr)); > mhi_write_reg(mhi_cntrl, base, BHI_IMGADDR_LOW, > lower_32_bits(dma_addr)); > mhi_write_reg(mhi_cntrl, base, BHI_IMGSIZE, size); > - mhi_write_reg(mhi_cntrl, base, BHI_IMGTXDB, session_id); > + mhi_write_reg(mhi_cntrl, base, BHI_IMGTXDB, mhi_cntrl->session_id); > read_unlock_bh(pm_lock); > > /* Wait for the image download to complete */ > diff --git a/include/linux/mhi.h b/include/linux/mhi.h > index a5441ad..8b3c934 100644 > --- a/include/linux/mhi.h > +++ b/include/linux/mhi.h > @@ -405,6 +405,7 @@ struct mhi_controller { > u32 minor_version; > u32 serial_number; > u32 oem_pk_hash[MHI_MAX_OEM_PK_HASH_SEGMENTS]; > + u32 session_id; > > struct mhi_event *mhi_event; > struct mhi_cmd *mhi_cmd; > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project > > -- மணிவண்ணன் சதாசிவம்