From: Manivannan Sadhasivam <mani@kernel.org>
To: Qiang Yu <quic_qianyu@quicinc.com>
Cc: quic_hemantk@quicinc.com, loic.poulain@linaro.org,
mhi@lists.linux.dev, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org, quic_cang@quicinc.com,
mrana@quicinc.com
Subject: Re: [PATCH] bus: mhi: host: Use mhi_soc_reset() API in place of register write
Date: Fri, 28 Oct 2022 22:52:03 +0530 [thread overview]
Message-ID: <20221028172203.GD13880@thinkpad> (raw)
In-Reply-To: <1665376324-34258-1-git-send-email-quic_qianyu@quicinc.com>
On Mon, Oct 10, 2022 at 12:32:04PM +0800, Qiang Yu wrote:
> Currently, a direct register write is used when ramdump collection
> in panic path occurs. Replace that with new mhi_soc_reset() API
> such that a controller defined reset() function is exercised if
> one is present and the regular SOC reset is done if it is not.
>
> Signed-off-by: Qiang Yu <quic_qianyu@quicinc.com>
> Reviewed-by: Loic Poulain <loic.poulain@linaro.org>
> Reviewed-by: Jeffrey Hugo <quic_jhugo@quicinc.com>
Reviewed-by: Manivannan Sadhasivam <mani@kernel.org>
Btw, this patch is supposed to be v2... Please keep the version info and also
add the changelog for future patches.
Thanks,
Mani
> ---
> drivers/bus/mhi/host/boot.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/bus/mhi/host/boot.c b/drivers/bus/mhi/host/boot.c
> index 26d0edd..1c69fee 100644
> --- a/drivers/bus/mhi/host/boot.c
> +++ b/drivers/bus/mhi/host/boot.c
> @@ -118,9 +118,7 @@ static int __mhi_download_rddm_in_panic(struct mhi_controller *mhi_cntrl)
> /* Hardware reset so force device to enter RDDM */
> dev_dbg(dev,
> "Did not enter RDDM, do a host req reset\n");
> - mhi_write_reg(mhi_cntrl, mhi_cntrl->regs,
> - MHI_SOC_RESET_REQ_OFFSET,
> - MHI_SOC_RESET_REQ);
> + mhi_soc_reset(mhi_cntrl);
> udelay(delayus);
> }
>
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>
--
மணிவண்ணன் சதாசிவம்
next prev parent reply other threads:[~2022-10-28 17:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-10 4:32 [PATCH] bus: mhi: host: Use mhi_soc_reset() API in place of register write Qiang Yu
2022-10-28 17:22 ` Manivannan Sadhasivam [this message]
2022-10-28 17:28 ` Manivannan Sadhasivam
-- strict thread matches above, loose matches on Subject: below --
2022-09-27 9:48 Qiang Yu
2022-09-27 10:04 ` Loic Poulain
2022-09-27 13:57 ` Jeffrey Hugo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221028172203.GD13880@thinkpad \
--to=mani@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=mhi@lists.linux.dev \
--cc=mrana@quicinc.com \
--cc=quic_cang@quicinc.com \
--cc=quic_hemantk@quicinc.com \
--cc=quic_qianyu@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).