From: Manivannan Sadhasivam <mani@kernel.org>
To: Qiang Yu <quic_qianyu@quicinc.com>
Cc: quic_hemantk@quicinc.com, loic.poulain@linaro.org,
mhi@lists.linux.dev, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org, quic_cang@quicinc.com,
mrana@quicinc.com
Subject: Re: [PATCH] bus: mhi: host: Add session ID to MHI controller
Date: Thu, 3 Nov 2022 18:25:31 +0530 [thread overview]
Message-ID: <20221103125531.GI8434@thinkpad> (raw)
In-Reply-To: <20221101114554.GD54667@thinkpad>
On Tue, Nov 01, 2022 at 05:15:54PM +0530, Manivannan Sadhasivam wrote:
> On Mon, Oct 31, 2022 at 04:54:55PM +0800, Qiang Yu wrote:
> >
> > On 10/29/2022 1:20 AM, Manivannan Sadhasivam wrote:
> > > On Mon, Oct 10, 2022 at 12:41:10PM +0800, Qiang Yu wrote:
> > > > Session ID to be used during BHI transfers to recognize a
> > > > particular session are currently not being stored in the MHI
> > > > controller structure. Store them to allow for tracking and other
> > > > future usage.
> > > >
> > > > Signed-off-by: Qiang Yu <quic_qianyu@quicinc.com>
> > > Who/what is going to use this session id?
> > Sometimes, we may find some error logs and want to see what happens on
> > device when host is printing these error logs.
> > Session id can help us find the logs we want.
>
> Okay. Please add this info to the commit message.
>
Wait. I asked who is going to use session_id cached in the MHI controller
structure? session_id is already printed in debug log.
> Thanks,
> Mani
>
> > >
> > > Thanks,
> > > Mani
> > >
> > > > ---
> > > > drivers/bus/mhi/host/boot.c | 8 ++++----
> > > > include/linux/mhi.h | 1 +
> > > > 2 files changed, 5 insertions(+), 4 deletions(-)
> > > >
> > > > diff --git a/drivers/bus/mhi/host/boot.c b/drivers/bus/mhi/host/boot.c
> > > > index 26d0edd..5bed8b51 100644
> > > > --- a/drivers/bus/mhi/host/boot.c
> > > > +++ b/drivers/bus/mhi/host/boot.c
> > > > @@ -231,7 +231,7 @@ static int mhi_fw_load_bhi(struct mhi_controller *mhi_cntrl,
> > > > dma_addr_t dma_addr,
> > > > size_t size)
> > > > {
> > > > - u32 tx_status, val, session_id;
> > > > + u32 tx_status, val;
> > > > int i, ret;
> > > > void __iomem *base = mhi_cntrl->bhi;
> > > > rwlock_t *pm_lock = &mhi_cntrl->pm_lock;
> > > > @@ -253,16 +253,16 @@ static int mhi_fw_load_bhi(struct mhi_controller *mhi_cntrl,
> > > > goto invalid_pm_state;
> > > > }
> > > > - session_id = MHI_RANDOM_U32_NONZERO(BHI_TXDB_SEQNUM_BMSK);
> > > > + mhi_cntrl->session_id = MHI_RANDOM_U32_NONZERO(BHI_TXDB_SEQNUM_BMSK);
> > > > dev_dbg(dev, "Starting image download via BHI. Session ID: %u\n",
> > > > - session_id);
> > > > + mhi_cntrl->session_id);
> > > > mhi_write_reg(mhi_cntrl, base, BHI_STATUS, 0);
> > > > mhi_write_reg(mhi_cntrl, base, BHI_IMGADDR_HIGH,
> > > > upper_32_bits(dma_addr));
> > > > mhi_write_reg(mhi_cntrl, base, BHI_IMGADDR_LOW,
> > > > lower_32_bits(dma_addr));
> > > > mhi_write_reg(mhi_cntrl, base, BHI_IMGSIZE, size);
> > > > - mhi_write_reg(mhi_cntrl, base, BHI_IMGTXDB, session_id);
> > > > + mhi_write_reg(mhi_cntrl, base, BHI_IMGTXDB, mhi_cntrl->session_id);
> > > > read_unlock_bh(pm_lock);
> > > > /* Wait for the image download to complete */
> > > > diff --git a/include/linux/mhi.h b/include/linux/mhi.h
> > > > index a5441ad..8b3c934 100644
> > > > --- a/include/linux/mhi.h
> > > > +++ b/include/linux/mhi.h
> > > > @@ -405,6 +405,7 @@ struct mhi_controller {
> > > > u32 minor_version;
> > > > u32 serial_number;
> > > > u32 oem_pk_hash[MHI_MAX_OEM_PK_HASH_SEGMENTS];
> > > > + u32 session_id;
> > > > struct mhi_event *mhi_event;
> > > > struct mhi_cmd *mhi_cmd;
> > > > --
> > > > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> > > > a Linux Foundation Collaborative Project
> > > >
> > > >
> >
>
> --
> மணிவண்ணன் சதாசிவம்
>
--
மணிவண்ணன் சதாசிவம்
next prev parent reply other threads:[~2022-11-03 12:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-10 4:41 [PATCH] bus: mhi: host: Add session ID to MHI controller Qiang Yu
2022-10-28 17:20 ` Manivannan Sadhasivam
2022-10-31 8:54 ` Qiang Yu
2022-11-01 11:45 ` Manivannan Sadhasivam
2022-11-03 12:55 ` Manivannan Sadhasivam [this message]
2022-11-08 7:25 ` Qiang Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221103125531.GI8434@thinkpad \
--to=mani@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=mhi@lists.linux.dev \
--cc=mrana@quicinc.com \
--cc=quic_cang@quicinc.com \
--cc=quic_hemantk@quicinc.com \
--cc=quic_qianyu@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).