From: Manivannan Sadhasivam <mani@kernel.org>
To: Jeffrey Hugo <quic_jhugo@quicinc.com>
Cc: mhi@lists.linux.dev, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] bus: mhi: host: Remove duplicate ee check for syserr
Date: Mon, 3 Apr 2023 11:15:31 +0530 [thread overview]
Message-ID: <20230403054531.GK4627@thinkpad> (raw)
In-Reply-To: <20230403053730.GI4627@thinkpad>
On Mon, Apr 03, 2023 at 11:07:35AM +0530, Manivannan Sadhasivam wrote:
> On Tue, Jan 24, 2023 at 02:57:23PM -0700, Jeffrey Hugo wrote:
> > If we detect a system error via intvec, we only process the syserr if the
> > current ee is different than the last observed ee. The reason for this
> > check is to prevent bhie from running multiple times, but with the single
> > queue handling syserr, that is not possible.
> >
> > The check can cause an issue with device recovery. If PBL loads a bad SBL
> > via BHI, but that SBL hangs before notifying the host of an ee change,
> > then issuing soc_reset to crash the device and retry (after supplying a
> > fixed SBL) will not recover the device as the host will observe a PBL->PBL
> > transition and not process the syserr. The device will be stuck until
> > either the driver is reloaded, or the host is rebooted. Instead, remove
> > the check so that we can attempt to recover the device.
> >
> > Signed-off-by: Jeffrey Hugo <quic_jhugo@quicinc.com>
>
> Reviewed-by: Manivannan Sadhasivam <mani@kernel.org>
>
Forgot to add that, this patch also needs a fixes tag and backporting.
- Mani
> - Mani
>
> > Reviewed-by: Carl Vanderlip <quic_carlv@quicinc.com>
> > ---
> > drivers/bus/mhi/host/main.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/bus/mhi/host/main.c b/drivers/bus/mhi/host/main.c
> > index df0fbfe..0c3a009 100644
> > --- a/drivers/bus/mhi/host/main.c
> > +++ b/drivers/bus/mhi/host/main.c
> > @@ -503,7 +503,7 @@ irqreturn_t mhi_intvec_threaded_handler(int irq_number, void *priv)
> > }
> > write_unlock_irq(&mhi_cntrl->pm_lock);
> >
> > - if (pm_state != MHI_PM_SYS_ERR_DETECT || ee == mhi_cntrl->ee)
> > + if (pm_state != MHI_PM_SYS_ERR_DETECT)
> > goto exit_intvec;
> >
> > switch (ee) {
> > --
> > 2.7.4
> >
>
> --
> மணிவண்ணன் சதாசிவம்
--
மணிவண்ணன் சதாசிவம்
next prev parent reply other threads:[~2023-04-03 5:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-24 21:57 [PATCH 0/2] MHI host syserr fixes Jeffrey Hugo
2023-01-24 21:57 ` [PATCH 1/2] bus: mhi: host: Remove duplicate ee check for syserr Jeffrey Hugo
2023-04-03 5:37 ` Manivannan Sadhasivam
2023-04-03 5:45 ` Manivannan Sadhasivam [this message]
2023-01-24 21:57 ` [PATCH 2/2] bus: mhi: host: Use mhi_tryset_pm_state() for setting fw error state Jeffrey Hugo
2023-04-03 5:42 ` Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230403054531.GK4627@thinkpad \
--to=mani@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhi@lists.linux.dev \
--cc=quic_jhugo@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).