From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EB194369 for ; Thu, 11 May 2023 13:52:31 +0000 (UTC) Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 34BDUUJS000533; Thu, 11 May 2023 13:52:28 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=RbRyh5JxCzRNKwywrJitBFStmeMc03vJfDZhpriQN1M=; b=cr1qQlAs0Rq2b4wcmbJLi2HiKlajTYyjBBOF/HwRrWO/NyhguG7Txy/fACyEK7P2qRg4 ObQVJmr7kMs9DzXvvAF0FF3dv+Nq4nRpBKkwbStORra3nNfpzZ94SbxTvRYdVAJSC7YZ 7czl5YMalBMw/bw0gHAvhBe3eV+pXGT12OUmYhrbjKwO5+xuLshdl3Kdh5XkWsZzwML5 uNF8uhKgt41QPPUvz96TyclRefQenfkDxQtbvxC33ukDUr7XFkLuv/PIqKK5bigfvOva evgY76f6VDXAXPgGlwNjxe92/HGA+xcYHX8MVqbVzrDGrNiTYt5a2rZWQPGSNggG/PJd Xw== Received: from nalasppmta01.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3qgv1u8vgs-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 11 May 2023 13:52:28 +0000 Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA01.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 34BDqRh1027265 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 11 May 2023 13:52:27 GMT Received: from [10.226.59.182] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.42; Thu, 11 May 2023 06:52:26 -0700 Message-ID: <73f6b38d-b968-ccad-c00f-86afa883a07d@quicinc.com> Date: Thu, 11 May 2023 07:52:25 -0600 Precedence: bulk X-Mailing-List: mhi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.0 Subject: Re: [PATCH v2] bus: mhi: host: Skip MHI reset if device is in RDDM Content-Language: en-US To: Qiang Yu , CC: , , , , References: <1683772404-13192-1-git-send-email-quic_qianyu@quicinc.com> From: Jeffrey Hugo In-Reply-To: <1683772404-13192-1-git-send-email-quic_qianyu@quicinc.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: bvoZugI4VqJIpH50vtlBfniE9K-RWs0K X-Proofpoint-ORIG-GUID: bvoZugI4VqJIpH50vtlBfniE9K-RWs0K X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-05-11_11,2023-05-05_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 mlxscore=0 phishscore=0 mlxlogscore=948 lowpriorityscore=0 bulkscore=0 spamscore=0 clxscore=1015 suspectscore=0 adultscore=0 malwarescore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2304280000 definitions=main-2305110119 On 5/10/2023 8:33 PM, Qiang Yu wrote: > In RDDM EE, device can not process MHI reset issued by host. In case of MHI > power off, host is issuing MHI reset and polls for it to get cleared until > it times out. Since this timeout can not be avoided in case of RDDM, skip > the MHI reset in this scenarios. > > Fixes: a0f5a630668c ("bus: mhi: Move host MHI code to "host" directory") This doesn't seem like the correct fixes tag. That commit looks like it just moves code around, but does not add code. What is the commit that added the relevant code? That commit probably predates the move. > Signed-off-by: Qiang Yu > ---