mhi.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@kernel.org>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: ath11k@lists.infradead.org,  mhi@lists.linux.dev,
	 linux-wireless@vger.kernel.org,  robert.marko@sartura.hr
Subject: Re: [PATCH RFC] ath11k: Add multiple QCN9074 devices support
Date: Fri, 13 Jan 2023 14:34:15 +0200	[thread overview]
Message-ID: <87edryd35k.fsf@kernel.org> (raw)
In-Reply-To: <20230112103824.GD4782@thinkpad> (Manivannan Sadhasivam's message of "Thu, 12 Jan 2023 16:08:24 +0530")

Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> writes:

> On Wed, Jan 11, 2023 at 07:00:33PM +0200, Kalle Valo wrote:
>> From: P Praneesh <quic_ppranees@quicinc.com>
>> 
>> On platforms with two or more QCN9074 devices, the QMI service will run with
>> identical QRTR ids. qmi_add_lookup() is called with same qmi.service_ins_id.
>
> identical QRTR instance ID.

Will fix.

>> Kalle's comments:
>> 
>> Depends on: https://patchwork.kernel.org/project/linux-wireless/list/?series=710862&order=date
>> 
>> It's also possible to do a simple test by just changing the test
>> "test_bit(ATH11K_FW_FEATURE_MULTI_QRTR_ID, ab->fw.fw_features)" to true, no
>> extra patches should be needed.
>> 
>> I don't have a test setup for this so compile tested only. But I assume Praneesh has tested this.
>> 
>> This is alternative approach to Robert's patchset:
>> 
>> https://patchwork.kernel.org/project/linux-wireless/list/?series=692423&state=*&order=date
>> 
>
> For what devices the compatible firmware is available?

Currently only recent QCN9074 firmware releases support this, but I
don't from which release onwards.

> Any plan to fix the devices with old firmware?

In my opinion all ath11k PCI firmwares should support this, but AFAIK
they do not. I'll push the firmware teams to implement this but it's
another story if I succeed :)

>> +static void ath11k_pci_update_qrtr_node_id(struct ath11k_base *ab)
>
> The function name says update node_id but instance_id is what getting
> updated.

Will fix.

Thanks for the review!

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

      reply	other threads:[~2023-01-13 12:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-11 17:00 [PATCH RFC] ath11k: Add multiple QCN9074 devices support Kalle Valo
2023-01-12 10:38 ` Manivannan Sadhasivam
2023-01-13 12:34   ` Kalle Valo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87edryd35k.fsf@kernel.org \
    --to=kvalo@kernel.org \
    --cc=ath11k@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=manivannan.sadhasivam@linaro.org \
    --cc=mhi@lists.linux.dev \
    --cc=robert.marko@sartura.hr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).