From: Greg KH <gregkh@linuxfoundation.org>
To: Slark Xiao <slark_xiao@163.com>
Cc: mani@kernel.org, loic.poulain@linaro.org, dnlplm@gmail.com,
yonglin.tan@outlook.com, fabio.porcedda@gmail.com,
mhi@lists.linux.dev, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: Re: Re: [PATCH v2] bus: mhi: host: pci_generic: Add macro for some VIDs
Date: Mon, 7 Nov 2022 13:07:52 +0100 [thread overview]
Message-ID: <Y2j1GBLQB2N8+lUM@kroah.com> (raw)
In-Reply-To: <5b96b2e2.3a97.18451a061a3.Coremail.slark_xiao@163.com>
On Mon, Nov 07, 2022 at 06:26:16PM +0800, Slark Xiao wrote:
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
Why all the blank lines?
> At 2022-11-07 17:53:57, "Greg KH" <gregkh@linuxfoundation.org> wrote:
> >On Mon, Nov 07, 2022 at 05:30:56PM +0800, Slark Xiao wrote:
> >As I said, this is just a define, not a macro at all.
> >
> >> And could you give your comments in previous patch, not the 'final' one?
> >
> >I do not understand, what previous patrch? What "final" one? What is
> >the "latest" patch?
> previous patch:
> https://lore.kernel.org/lkml/20221027115123.5326-1-slark_xiao@163.com/
> https://lore.kernel.org/lkml/20221028023711.4196-1-slark_xiao@163.com/
> https://lore.kernel.org/lkml/20221102024437.15248-1-slark_xiao@163.com/
>
> 'final' patch:
> https://lore.kernel.org/lkml/20221107084826.8888-1-slark_xiao@163.com/
> https://lore.kernel.org/lkml/20221101015858.6777-1-slark_xiao@163.com/
That's 2 different versions, with a total of 3.
>
> The 'final' patch was committed according to the advice of the feature
> maintainer.
> >
> >> In another pci_ids patch, you break it in v3 and break it here again in v2.
> >
> >I broke what?
> You could have voiced out such comment in V1, V2 before the 'final'.
We all review patches when we can. There is no rule that people can not
comment on newer patches, or older ones.
In fact, it would be wonderful if you could take some time and review
patches from others. It would help your understanding of the code and
how the kernel development process works.
thanks,
greg k-h
next prev parent reply other threads:[~2022-11-07 12:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-07 8:48 [PATCH v2] bus: mhi: host: pci_generic: Add macro for some VIDs Slark Xiao
2022-11-07 9:02 ` Greg KH
2022-11-07 9:30 ` Slark Xiao
2022-11-07 9:53 ` Greg KH
2022-11-07 10:26 ` Slark Xiao
2022-11-07 12:07 ` Greg KH [this message]
2022-11-10 11:14 ` Re:Re: " Slark Xiao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y2j1GBLQB2N8+lUM@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=dnlplm@gmail.com \
--cc=fabio.porcedda@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=mani@kernel.org \
--cc=mhi@lists.linux.dev \
--cc=slark_xiao@163.com \
--cc=yonglin.tan@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).