From: Greg KH <email@example.com>
To: Slark Xiao <firstname.lastname@example.org>
Cc: email@example.com, firstname.lastname@example.org, email@example.com,
Subject: Re: Re: [PATCH v2] bus: mhi: host: pci_generic: Add macro for some VIDs
Date: Mon, 7 Nov 2022 10:53:57 +0100 [thread overview]
Message-ID: <Y2jVtWPdTybNCYqX@kroah.com> (raw)
On Mon, Nov 07, 2022 at 05:30:56PM +0800, Slark Xiao wrote:
> At 2022-11-07 17:02:29, "Greg KH" <firstname.lastname@example.org> wrote:
> >On Mon, Nov 07, 2022 at 04:48:26PM +0800, Slark Xiao wrote:
> >> To make code neat and for convenience purpose, use macro for
> >> some VIDs. These macros are supposed to be added to pci_ids.h.
> >No, they are not supposed to be added there at all.
> >And they are not a "macro", it is a "#define".
> >> But until the macros are used in multiple places, it is not
> >> recommended. So adding it locally for now.
> >Again, these are not macros
> >greg k-h
> Hi Greg,
> Thanks for your comment.
> In my opinion, MACRO almost same as a '#define'. May I know how do
> you call such definition?
As I said, this is just a define, not a macro at all.
> And could you give your comments in previous patch, not the 'final' one?
I do not understand, what previous patrch? What "final" one? What is
the "latest" patch?
> In another pci_ids patch, you break it in v3 and break it here again in v2.
I broke what?
> Honestly, it's positive for whole project. But it's negative for contributor
> and maintainer.
I am totally confused here and do not understand what you are referring
next prev parent reply other threads:[~2022-11-07 9:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-07 8:48 [PATCH v2] bus: mhi: host: pci_generic: Add macro for some VIDs Slark Xiao
2022-11-07 9:02 ` Greg KH
2022-11-07 9:30 ` Slark Xiao
2022-11-07 9:53 ` Greg KH [this message]
2022-11-07 10:26 ` Re:Re: " Slark Xiao
2022-11-07 12:07 ` Greg KH
2022-11-10 11:14 ` Slark Xiao
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).