From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Subject: Re: [patch 06/67] mm: factor out next_present_section_nr() Date: Mon, 3 Feb 2020 20:29:00 -0800 Message-ID: <20200203202900.bda79c8f28ddaa63ddd8c740@linux-foundation.org> References: <20200203173311.6269a8be06a05e5a4aa08a93@linux-foundation.org> <20200204013402.UfNC2Pqe3%akpm@linux-foundation.org> Reply-To: linux-kernel@vger.kernel.org Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: Received: from mail.kernel.org ([198.145.29.99]:60414 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726994AbgBDE3D (ORCPT ); Mon, 3 Feb 2020 23:29:03 -0500 In-Reply-To: Sender: mm-commits-owner@vger.kernel.org List-Id: mm-commits@vger.kernel.org To: Linus Torvalds Cc: Baoquan He , Dan Williams , David Hildenbrand , "Kirill A . Shutemov" , "Kirill A . Shutemov" , Linux-MM , Mel Gorman , Michal Hocko , Michal Hocko , mm-commits@vger.kernel.org, osalvador@suse.de, Pavel Tatashin , Vlastimil Babka , zhi.jin@intel.com On Tue, 4 Feb 2020 03:04:40 +0000 Linus Torvalds wrote: > On Tue, Feb 4, 2020 at 1:34 AM Andrew Morton wrote: > > > > From: David Hildenbrand > > Subject: mm: factor out next_present_section_nr() > > > > Let's move it to the header and use the shorter variant from > > mm/page_alloc.c (the original one will also check > > "__highest_present_section_nr + 1", which is not necessary). While at it, > > make the section_nr in next_pfn() const. > > > > In next_pfn(), we now return section_nr_to_pfn(-1) instead of -1 once we > > exceed __highest_present_section_nr, which doesn't make a difference i= n > > the caller as it is big enough (>=3D all sane end_pfn). > > Here, look at that "i= n". It looks like it was a MIME line-break (so > "in" was MIME-encoded and turned into "i=\nn") followed by you or > David re-flowing the text without MIME-decoding it. Yes, my MUA is not good about converting all input. I have tools to fix up the patches post-facto but changelogs have been a challenge. I have updated my nightly check-patches-for-crap-and-email-it-to-andrew script to check for this.