From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Subject: + pstore_ftrace_seq_next-should-increase-position-index.patch added to -mm tree Date: Tue, 25 Feb 2020 19:56:24 -0800 Message-ID: <20200226035624.7OWMYBNf-%akpm@linux-foundation.org> References: <20200203173311.6269a8be06a05e5a4aa08a93@linux-foundation.org> Reply-To: linux-kernel@vger.kernel.org Return-path: Received: from mail.kernel.org ([198.145.29.99]:41080 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725788AbgBZD41 (ORCPT ); Tue, 25 Feb 2020 22:56:27 -0500 In-Reply-To: <20200203173311.6269a8be06a05e5a4aa08a93@linux-foundation.org> Sender: mm-commits-owner@vger.kernel.org List-Id: mm-commits@vger.kernel.org To: dave@stgolabs.net, longman@redhat.com, manfred@colorfullife.com, mingo@redhat.com, mm-commits@vger.kernel.org, neilb@suse.com, oberpar@linux.ibm.com, rostedt@goodmis.org, viro@zeniv.linux.org.uk, vvs@virtuozzo.com The patch titled Subject: fs/pstore: pstore_ftrace_seq_next() should increase position index has been added to the -mm tree. Its filename is pstore_ftrace_seq_next-should-increase-position-index.patch This patch should soon appear at http://ozlabs.org/~akpm/mmots/broken-out/pstore_ftrace_seq_next-should-increase-position-index.patch and later at http://ozlabs.org/~akpm/mmotm/broken-out/pstore_ftrace_seq_next-should-increase-position-index.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/process/submit-checklist.rst when testing your code *** The -mm tree is included into linux-next and is updated there every 3-4 working days ------------------------------------------------------ From: Vasily Averin Subject: fs/pstore: pstore_ftrace_seq_next() should increase position index If seq_file .next fuction does not change position index, read after some lseek can generate unexpected output. https://bugzilla.kernel.org/show_bug.cgi?id=206283 Link: http://lkml.kernel.org/r/51376af5-e0f2-0ff2-d664-e932153b0665@virtuozzo.com Signed-off-by: Vasily Averin Cc: Waiman Long Cc: Steven Rostedt Cc: Ingo Molnar Cc: Peter Oberparleiter Cc: Al Viro Cc: Davidlohr Bueso Cc: Manfred Spraul Cc: NeilBrown Signed-off-by: Andrew Morton --- fs/pstore/inode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/fs/pstore/inode.c~pstore_ftrace_seq_next-should-increase-position-index +++ a/fs/pstore/inode.c @@ -87,11 +87,11 @@ static void *pstore_ftrace_seq_next(stru struct pstore_private *ps = s->private; struct pstore_ftrace_seq_data *data = v; + (*pos)++; data->off += REC_SIZE; if (data->off + REC_SIZE > ps->total_size) return NULL; - (*pos)++; return data; } _ Patches currently in -mm which might be from vvs@virtuozzo.com are seq_read-info-message-about-buggy-next-functions.patch pstore_ftrace_seq_next-should-increase-position-index.patch gcov_seq_next-should-increase-position-index.patch sysvipc_find_ipc-should-increase-position-index.patch