From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Subject: [patch 002/155] kthread: mark timer used by delayed kthread works as IRQ safe Date: Wed, 01 Apr 2020 21:02:28 -0700 Message-ID: <20200402040228.SUm4aLepC%akpm@linux-foundation.org> References: <20200401210155.09e3b9742e1c6e732f5a7250@linux-foundation.org> Reply-To: linux-kernel@vger.kernel.org Return-path: Received: from mail.kernel.org ([198.145.29.99]:45724 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727109AbgDBECa (ORCPT ); Thu, 2 Apr 2020 00:02:30 -0400 In-Reply-To: <20200401210155.09e3b9742e1c6e732f5a7250@linux-foundation.org> Sender: mm-commits-owner@vger.kernel.org List-Id: mm-commits@vger.kernel.org To: akpm@linux-foundation.org, grygorii.strashko@ti.com, linux-mm@kvack.org, mm-commits@vger.kernel.org, pmladek@suse.com, tglx@linutronix.de, tj@kernel.org, torvalds@linux-foundation.org From: Petr Mladek Subject: kthread: mark timer used by delayed kthread works as IRQ safe The timer used by delayed kthread works are IRQ safe because the used kthread_delayed_work_timer_fn() is IRQ safe. It is properly marked when initialized by KTHREAD_DELAYED_WORK_INIT(). But TIMER_IRQSAFE flag is missing when initialized by kthread_init_delayed_work(). The missing flag might trigger invalid warning from del_timer_sync() when kthread_mod_delayed_work() is called with interrupts disabled. This patch is result of a discussion about using the API, see https://lkml.kernel.org/r/cfa886ad-e3b7-c0d2-3ff8-58d94170eab5@ti.com Link: http://lkml.kernel.org/r/20200217120709.1974-1-pmladek@suse.com Signed-off-by: Petr Mladek Reported-by: Grygorii Strashko Tested-by: Grygorii Strashko Acked-by: Tejun Heo Cc: Thomas Gleixner Signed-off-by: Andrew Morton --- include/linux/kthread.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/include/linux/kthread.h~kthread-mark-timer-used-by-delayed-kthread-works-as-irq-safe +++ a/include/linux/kthread.h @@ -165,7 +165,8 @@ extern void __kthread_init_worker(struct do { \ kthread_init_work(&(dwork)->work, (fn)); \ timer_setup(&(dwork)->timer, \ - kthread_delayed_work_timer_fn, 0); \ + kthread_delayed_work_timer_fn, \ + TIMER_IRQSAFE); \ } while (0) int kthread_worker_fn(void *worker_ptr); _