From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C452C433DF for ; Mon, 6 Jul 2020 23:34:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EF0BB20720 for ; Mon, 6 Jul 2020 23:34:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594078448; bh=RJtVnLbZNvydXBQsZpJfJWdeUMX8Lkcj1Y8ai/XM0DE=; h=Date:From:To:Subject:In-Reply-To:Reply-To:List-ID:From; b=LvFGo0aia0FFQE57IwQuiZDX2I5gbanct9wnNmkmcSxqlZLR1sdgBo9UmMLKO6bGF wnko2bqB/sBFerswJBbEwH0A+Iw4SpZOcaBaOPKS5rMP72S23/ewI0WBsI1p+91tal TKLd3LtzRJBoTksJONzjezDIPUf3rxsMKbHQjmQU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726817AbgGFXeH (ORCPT ); Mon, 6 Jul 2020 19:34:07 -0400 Received: from mail.kernel.org ([198.145.29.99]:36306 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726366AbgGFXeH (ORCPT ); Mon, 6 Jul 2020 19:34:07 -0400 Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A715B206DF; Mon, 6 Jul 2020 23:34:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594078447; bh=RJtVnLbZNvydXBQsZpJfJWdeUMX8Lkcj1Y8ai/XM0DE=; h=Date:From:To:Subject:In-Reply-To:From; b=q+ODsGA3QKwVX5j94xpEdRvdbdG/zC1KbCyf3s+P2Wj+wcoww2dL7T/XY1H7SQz2p /DC2ZUsq26QCifmp32Tjidf8sjTXwUf4HWwhcsBV/gVQwWifo9skrVpSGx8W/EP3WT sV7UOiPL0DfihIu9BY2GLur1ryNItollD+6xTLNs= Date: Mon, 06 Jul 2020 16:34:06 -0700 From: Andrew Morton To: bigeasy@linutronix.de, cl@linux.com, iamjoonsoo.kim@lge.com, mm-commits@vger.kernel.org, penberg@kernel.org, rientjes@google.com, tglx@linutronix.de, yuzhao@google.com Subject: + slub-drop-lockdep_assert_held-from-put_map.patch added to -mm tree Message-ID: <20200706233406.tznwdEcVl%akpm@linux-foundation.org> In-Reply-To: <20200703151445.b6a0cfee402c7c5c4651f1b1@linux-foundation.org> User-Agent: s-nail v14.8.16 Sender: mm-commits-owner@vger.kernel.org Precedence: bulk Reply-To: linux-kernel@vger.kernel.org List-ID: X-Mailing-List: mm-commits@vger.kernel.org Message-ID: <20200706233406.HIqwOlHQTPSisTqCSbcrx6hKbuysR9tWA3FCp9L9WZ4@z> The patch titled Subject: mm/slub.c: drop lockdep_assert_held() from put_map() has been added to the -mm tree. Its filename is slub-drop-lockdep_assert_held-from-put_map.patch This patch should soon appear at http://ozlabs.org/~akpm/mmots/broken-out/slub-drop-lockdep_assert_held-from-put_map.patch and later at http://ozlabs.org/~akpm/mmotm/broken-out/slub-drop-lockdep_assert_held-from-put_map.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/process/submit-checklist.rst when testing your code *** The -mm tree is included into linux-next and is updated there every 3-4 working days ------------------------------------------------------ From: Sebastian Andrzej Siewior Subject: mm/slub.c: drop lockdep_assert_held() from put_map() There is no point in using lockdep_assert_held() unlock that is about to be unlocked. It works only with lockdep and lockdep will complain if spin_unlock() is used on a lock that has not been locked. Remove superfluous lockdep_assert_held(). Link: http://lkml.kernel.org/r/20200618201234.795692-2-bigeasy@linutronix.de Signed-off-by: Sebastian Andrzej Siewior Cc: Yu Zhao Cc: Christopher Lameter Cc: Pekka Enberg Cc: David Rientjes Cc: Joonsoo Kim Cc: Thomas Gleixner Signed-off-by: Andrew Morton --- mm/slub.c | 2 -- 1 file changed, 2 deletions(-) --- a/mm/slub.c~slub-drop-lockdep_assert_held-from-put_map +++ a/mm/slub.c @@ -473,8 +473,6 @@ static unsigned long *get_map(struct kme static void put_map(unsigned long *map) __releases(&object_map_lock) { VM_BUG_ON(map != object_map); - lockdep_assert_held(&object_map_lock); - spin_unlock(&object_map_lock); } _ Patches currently in -mm which might be from bigeasy@linutronix.de are slub-drop-lockdep_assert_held-from-put_map.patch