From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26251C433DF for ; Wed, 12 Aug 2020 01:30:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 037912076C for ; Wed, 12 Aug 2020 01:30:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597195825; bh=NQbfiQzOVm7+XrLhsNYOPjvyTcEC1zsVfs+5rHjNJp0=; h=Date:From:To:Subject:In-Reply-To:Reply-To:List-ID:From; b=SQTs5x+UsGaoQmVOUfDSCPynEIEnZ7XYC4qc5fTMZBBUBaMe+pRDH0MLWVYbHU5Qs 54YVITZTYenexKc2FoAKkF1xXl8JrFzrcAqG9pKOnp6Z8BWJZpOmYpewCUC8/mb7TJ jkzSMLs5NF0uspFBQlyo3iY2gIOZvKp3W9yS9l9A= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726488AbgHLBaY (ORCPT ); Tue, 11 Aug 2020 21:30:24 -0400 Received: from mail.kernel.org ([198.145.29.99]:57056 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726235AbgHLBaX (ORCPT ); Tue, 11 Aug 2020 21:30:23 -0400 Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 026B920829; Wed, 12 Aug 2020 01:30:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597195822; bh=NQbfiQzOVm7+XrLhsNYOPjvyTcEC1zsVfs+5rHjNJp0=; h=Date:From:To:Subject:In-Reply-To:From; b=W7ONstaRZ8Xo5cNyyB3m0gS2EDobja73XHWbsC8Km0D8KbPdjqzCP4YROI54z/j38 ctzlnci9VTkL2J8FoIHfoxnkkAmHoK1n2sq2RYnwVUh3HKAShIFye/CIEQJTWUPmZL 7dJt4WfRrKa1GqMLCdVsfP7xbMONsdRGOPAGNy3k= Date: Tue, 11 Aug 2020 18:30:21 -0700 From: Andrew Morton To: akpm@linux-foundation.org, cl@linux.com, cuibixuan@huawei.com, dennis@kernel.org, guro@fb.com, hannes@cmpxchg.org, iamjoonsoo.kim@lge.com, linux-mm@kvack.org, longman@redhat.com, mgorman@techsingularity.net, mhocko@kernel.org, mkoutny@suse.com, mm-commits@vger.kernel.org, penberg@kernel.org, rientjes@google.com, sfr@canb.auug.org.au, shakeelb@google.com, tj@kernel.org, tobin@kernel.org, torvalds@linux-foundation.org, vbabka@suse.cz Subject: [patch 003/165] mm: memcg/percpu: per-memcg percpu memory statistics Message-ID: <20200812013021.T8o2FQyM0%akpm@linux-foundation.org> In-Reply-To: <20200811182949.e12ae9a472e3b5e27e16ad6c@linux-foundation.org> User-Agent: s-nail v14.8.16 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Sender: mm-commits-owner@vger.kernel.org Precedence: bulk Reply-To: linux-kernel@vger.kernel.org List-ID: X-Mailing-List: mm-commits@vger.kernel.org =46rom: Roman Gushchin Subject: mm: memcg/percpu: per-memcg percpu memory statistics Percpu memory can represent a noticeable chunk of the total memory consumption, especially on big machines with many CPUs. Let's track percpu memory usage for each memcg and display it in memory.stat. A percpu allocation is usually scattered over multiple pages (and nodes), and can be significantly smaller than a page. So let's add a byte-sized counter on the memcg level: MEMCG_PERCPU_B. Byte-sized vmstat infra created for slabs can be perfectly reused for percpu case. [guro@fb.com: v3] Link: http://lkml.kernel.org/r/20200623184515.4132564-4-guro@fb.com Link: http://lkml.kernel.org/r/20200608230819.832349-4-guro@fb.com Signed-off-by: Roman Gushchin Acked-by: Dennis Zhou Reviewed-by: Shakeel Butt Acked-by: Johannes Weiner Cc: Christoph Lameter Cc: David Rientjes Cc: Joonsoo Kim Cc: Mel Gorman Cc: Michal Hocko Cc: Pekka Enberg Cc: Tejun Heo Cc: Tobin C. Harding Cc: Vlastimil Babka Cc: Waiman Long Cc: Bixuan Cui Cc: Michal Koutn=C3=BD Cc: Stephen Rothwell Signed-off-by: Andrew Morton --- Documentation/admin-guide/cgroup-v2.rst | 4 ++++ include/linux/memcontrol.h | 8 ++++++++ mm/memcontrol.c | 4 +++- mm/percpu.c | 10 ++++++++++ 4 files changed, 25 insertions(+), 1 deletion(-) --- a/Documentation/admin-guide/cgroup-v2.rst~mm-memcg-percpu-per-memcg-per= cpu-memory-statistics +++ a/Documentation/admin-guide/cgroup-v2.rst @@ -1274,6 +1274,10 @@ PAGE_SIZE multiple when read back. Amount of memory used for storing in-kernel data structures. =20 + percpu + Amount of memory used for storing per-cpu kernel + data structures. + sock Amount of memory used in network transmission buffers =20 --- a/include/linux/memcontrol.h~mm-memcg-percpu-per-memcg-percpu-memory-st= atistics +++ a/include/linux/memcontrol.h @@ -32,6 +32,7 @@ struct kmem_cache; enum memcg_stat_item { MEMCG_SWAP =3D NR_VM_NODE_STAT_ITEMS, MEMCG_SOCK, + MEMCG_PERCPU_B, MEMCG_NR_STAT, }; =20 @@ -339,6 +340,13 @@ struct mem_cgroup { =20 extern struct mem_cgroup *root_mem_cgroup; =20 +static __always_inline bool memcg_stat_item_in_bytes(int idx) +{ + if (idx =3D=3D MEMCG_PERCPU_B) + return true; + return vmstat_item_in_bytes(idx); +} + static inline bool mem_cgroup_is_root(struct mem_cgroup *memcg) { return (memcg =3D=3D root_mem_cgroup); --- a/mm/memcontrol.c~mm-memcg-percpu-per-memcg-percpu-memory-statistics +++ a/mm/memcontrol.c @@ -781,7 +781,7 @@ void __mod_memcg_state(struct mem_cgroup if (mem_cgroup_disabled()) return; =20 - if (vmstat_item_in_bytes(idx)) + if (memcg_stat_item_in_bytes(idx)) threshold <<=3D PAGE_SHIFT; =20 x =3D val + __this_cpu_read(memcg->vmstats_percpu->stat[idx]); @@ -1488,6 +1488,8 @@ static char *memory_stat_format(struct m seq_buf_printf(&s, "slab %llu\n", (u64)(memcg_page_state(memcg, NR_SLAB_RECLAIMABLE_B) + memcg_page_state(memcg, NR_SLAB_UNRECLAIMABLE_B))); + seq_buf_printf(&s, "percpu %llu\n", + (u64)memcg_page_state(memcg, MEMCG_PERCPU_B)); seq_buf_printf(&s, "sock %llu\n", (u64)memcg_page_state(memcg, MEMCG_SOCK) * PAGE_SIZE); --- a/mm/percpu.c~mm-memcg-percpu-per-memcg-percpu-memory-statistics +++ a/mm/percpu.c @@ -1610,6 +1610,11 @@ static void pcpu_memcg_post_alloc_hook(s =20 if (chunk) { chunk->obj_cgroups[off >> PCPU_MIN_ALLOC_SHIFT] =3D objcg; + + rcu_read_lock(); + mod_memcg_state(obj_cgroup_memcg(objcg), MEMCG_PERCPU_B, + size * num_possible_cpus()); + rcu_read_unlock(); } else { obj_cgroup_uncharge(objcg, size * num_possible_cpus()); obj_cgroup_put(objcg); @@ -1628,6 +1633,11 @@ static void pcpu_memcg_free_hook(struct =20 obj_cgroup_uncharge(objcg, size * num_possible_cpus()); =20 + rcu_read_lock(); + mod_memcg_state(obj_cgroup_memcg(objcg), MEMCG_PERCPU_B, + -(size * num_possible_cpus())); + rcu_read_unlock(); + obj_cgroup_put(objcg); } =20 _