From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 613D3C433DF for ; Wed, 12 Aug 2020 21:04:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 351F220774 for ; Wed, 12 Aug 2020 21:04:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597266264; bh=wIb2QFCr5AGjnX06wzjlaiRS8YxcssKNhbx26wcxXFs=; h=Date:From:To:Subject:Reply-To:List-ID:From; b=v7ayhks/NlYzu71WHUJ0GRzLNp90I+r7eHbDU1m906HXRpAoy8d9/CTQcX+HVk0MC pbBxbXdeloMeALV5+p4b9Atk8LjVr3XPjPdWI92LAwkIX5MGYiWfPDA5tHTpS4oTTE +Av7qU+FI2yKNspP9/TjwLAtC56T2u/UTGIyYrRs= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726596AbgHLVEY (ORCPT ); Wed, 12 Aug 2020 17:04:24 -0400 Received: from mail.kernel.org ([198.145.29.99]:56578 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726578AbgHLVEX (ORCPT ); Wed, 12 Aug 2020 17:04:23 -0400 Received: from localhost.localdomain (c-71-198-47-131.hsd1.ca.comcast.net [71.198.47.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 63985207F7; Wed, 12 Aug 2020 21:04:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597266263; bh=wIb2QFCr5AGjnX06wzjlaiRS8YxcssKNhbx26wcxXFs=; h=Date:From:To:Subject:From; b=AwSlkB3We3hUcf00zS5jYx6ZmCtqWKgco2QYU9HRuJJI5x4+itzBR5pnie7j25ULw S/f2AVV+J4BUHn/xwIv1EolNLb2X6OPE38C1UV1RaAAJJcquXKaI2CMUGThEZDr48T o4Z/bVJyoNM+j96Rwa+agsI7CCs/4/P2yp8r0Rdc= Date: Wed, 12 Aug 2020 14:04:23 -0700 From: akpm@linux-foundation.org To: joe@perches.com, keescook@chromium.org, mm-commits@vger.kernel.org Subject: [merged] checkpatch-add-test-for-possible-misuse-of-is_enabled-without-config_.patch removed from -mm tree Message-ID: <20200812210423.kcKE-A3vi%akpm@linux-foundation.org> User-Agent: s-nail v14.8.16 Sender: mm-commits-owner@vger.kernel.org Precedence: bulk Reply-To: linux-kernel@vger.kernel.org List-ID: X-Mailing-List: mm-commits@vger.kernel.org The patch titled Subject: checkpatch: add test for possible misuse of IS_ENABLED() without CONFIG_ has been removed from the -mm tree. Its filename was checkpatch-add-test-for-possible-misuse-of-is_enabled-without-config_.patch This patch was dropped because it was merged into mainline or a subsystem tree ------------------------------------------------------ From: Joe Perches Subject: checkpatch: add test for possible misuse of IS_ENABLED() without CONFIG_ IS_ENABLED is almost always used with CONFIG_ defines. Add a test to verify that the #define being tested starts with CONFIG_. Link: http://lkml.kernel.org/r/e7fda760b91b769ba82844ba282d432c0d26d709.camel@perches.com Signed-off-by: Joe Perches Reviewed-by: Kees Cook Signed-off-by: Andrew Morton --- scripts/checkpatch.pl | 6 ++++++ 1 file changed, 6 insertions(+) --- a/scripts/checkpatch.pl~checkpatch-add-test-for-possible-misuse-of-is_enabled-without-config_ +++ a/scripts/checkpatch.pl @@ -6465,6 +6465,12 @@ sub process { } } +# check for IS_ENABLED() without CONFIG_ ($rawline for comments too) + if ($rawline =~ /\bIS_ENABLED\s*\(\s*(\w+)\s*\)/ && $1 !~ /^CONFIG_/) { + WARN("IS_ENABLED_CONFIG", + "IS_ENABLED($1) is normally used as IS_ENABLED(CONFIG_$1)\n" . $herecurr); + } + # check for #if defined CONFIG_ || defined CONFIG__MODULE if ($line =~ /^\+\s*#\s*if\s+defined(?:\s*\(?\s*|\s+)(CONFIG_[A-Z_]+)\s*\)?\s*\|\|\s*defined(?:\s*\(?\s*|\s+)\1_MODULE\s*\)?\s*$/) { my $config = $1; _ Patches currently in -mm which might be from joe@perches.com are checkpatch-test-git_dir-changes.patch