mm-commits.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: akpm@linux-foundation.org, andres@anarazel.de,
	david@fromorbit.com, dhowells@redhat.com, hch@infradead.org,
	jack@suse.cz, jlayton@kernel.org, linux-mm@kvack.org,
	minchan@kernel.org, mm-commits@vger.kernel.org,
	stable@vger.kernel.org, torvalds@linux-foundation.org,
	viro@zeniv.linux.org.uk, willy@infradead.org
Subject: [patch 4/5] mm: validate inode in mapping_set_error()
Date: Sat, 10 Oct 2020 23:16:37 -0700	[thread overview]
Message-ID: <20201011061637.E_t0y98Vu%akpm@linux-foundation.org> (raw)
In-Reply-To: <20201010231559.e148a66f744d0b4870301450@linux-foundation.org>

From: Minchan Kim <minchan@kernel.org>
Subject: mm: validate inode in mapping_set_error()

The swap address_space doesn't have host. Thus, it makes kernel crash once
swap write meets error. Fix it.

Link: https://lkml.kernel.org/r/20201010000650.750063-1-minchan@kernel.org
Fixes: 735e4ae5ba28 ("vfs: track per-sb writeback errors and report them to syncfs")
Signed-off-by: Minchan Kim <minchan@kernel.org>
Acked-by: Jeff Layton <jlayton@kernel.org>
Cc: Jan Kara <jack@suse.cz>
Cc: Andres Freund <andres@anarazel.de>
Cc: Matthew Wilcox <willy@infradead.org>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: Christoph Hellwig <hch@infradead.org>
Cc: Dave Chinner <david@fromorbit.com>
Cc: David Howells <dhowells@redhat.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 include/linux/pagemap.h |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

--- a/include/linux/pagemap.h~mm-validate-inode-in-mapping_set_error
+++ a/include/linux/pagemap.h
@@ -54,7 +54,8 @@ static inline void mapping_set_error(str
 	__filemap_set_wb_err(mapping, error);
 
 	/* Record it in superblock */
-	errseq_set(&mapping->host->i_sb->s_wb_err, error);
+	if (mapping->host)
+		errseq_set(&mapping->host->i_sb->s_wb_err, error);
 
 	/* Record it in flags for now, for legacy callers */
 	if (error == -ENOSPC)
_

  parent reply	other threads:[~2020-10-11  6:16 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-11  6:15 incoming Andrew Morton
2020-10-11  6:16 ` [patch 1/5] MAINTAINERS: change hardening mailing list Andrew Morton
2020-10-11  6:16 ` [patch 2/5] MAINTAINERS: Antoine Tenart's email address Andrew Morton
2020-10-11  6:16 ` [patch 3/5] mm: mmap: fix general protection fault in unlink_file_vma() Andrew Morton
2020-10-11  6:16 ` Andrew Morton [this message]
2020-10-11  6:16 ` [patch 5/5] mm: khugepaged: recalculate min_free_kbytes after memory hotplug as expected by khugepaged Andrew Morton
2020-10-13 23:02 ` [folded-merged] x86-numa-add-nohmat-option-fix.patch removed from -mm tree Andrew Morton
2020-10-13 23:02 ` [folded-merged] acpi-hmat-refactor-hmat_register_target_device-to-hmem_register_device-fix.patch " Andrew Morton
2020-10-13 23:03 ` [folded-merged] mm-memory_hotplug-introduce-default-phys_to_target_node-implementation-fix.patch " Andrew Morton
2020-10-13 23:04 ` [folded-merged] acpi-hmat-attach-a-device-for-each-soft-reserved-range-fix.patch " Andrew Morton
2020-10-13 23:05 ` [folded-merged] mm-memremap_pages-convert-to-struct-range-fix.patch " Andrew Morton
2020-10-13 23:05 ` [folded-merged] mm-optimise-madvise-willneed-fix.patch " Andrew Morton
2020-10-13 23:06 ` [folded-merged] mm-convert-find_get_entry-to-return-the-head-page-fix.patch " Andrew Morton
2020-10-13 23:07 ` [folded-merged] mm-shmem-return-head-page-from-find_lock_entry-fix.patch " Andrew Morton
2020-10-13 23:08 ` [folded-merged] mm-gup-dont-permit-users-to-call-get_user_pages-with-foll_longterm-fix.patch " Andrew Morton
2020-10-13 23:09 ` [folded-merged] mm-memcg-simplify-mem_cgroup_get_max-v4.patch " Andrew Morton
2020-10-13 23:09 ` [folded-merged] mm-account-pmd-tables-like-pte-tables-fix.patch " Andrew Morton
2020-10-13 23:10 ` [folded-merged] mm-remove-src-dst-mm-parameter-in-copy_page_range-v2.patch " Andrew Morton
2020-10-13 23:10 ` [folded-merged] mm-remove-src-dst-mm-parameter-in-copy_page_range-v2-fix.patch " Andrew Morton
2020-10-13 23:12 ` [folded-merged] kasan-port-kasan-tests-to-kunit-v14.patch " Andrew Morton
2020-10-13 23:12 ` [folded-merged] mm-page_allocc-clean-code-by-removing-unnecessary-initialization-fix.patch " Andrew Morton
2020-10-13 23:13 ` [folded-merged] mm-hugetlb-take-the-free-hpage-during-the-iteration-directly-v4.patch " Andrew Morton
2020-10-13 23:13 ` [folded-merged] mm-mempool-add-else-to-split-mutually-exclusive-case-fix.patch " Andrew Morton
2020-10-13 23:14 ` [folded-merged] memblock-make-memblock_debug-and-related-functionality-private-fix.patch " Andrew Morton
2020-10-13 23:14 ` [folded-merged] arch-drivers-replace-for_each_membock-with-for_each_mem_range-fix.patch " Andrew Morton
2020-10-13 23:14 ` [folded-merged] arch-drivers-replace-for_each_membock-with-for_each_mem_range-fix-2.patch " Andrew Morton
2020-10-13 23:15 ` [folded-merged] mm-oom_adj-dont-loop-through-tasks-in-__set_oom_adj-when-not-necessary-v3.patch " Andrew Morton
2020-10-16  2:11 ` [folded-merged] powerpc-mm-move-setting-pte-specific-flags-to-pfn_pte-fix.patch " Andrew Morton
2020-10-16  2:12 ` [folded-merged] mm-debug_vm_pgtable-hugetlb-disable-hugetlb-test-on-ppc64-fix.patch " Andrew Morton
2020-10-16  2:13 ` [folded-merged] mm-debug_vm_pgtable-avoid-none-pte-in-pte_clear_test-fix.patch " Andrew Morton
2020-10-16  2:14 ` [folded-merged] xarray-add-xa_get_order-fix.patch " Andrew Morton
2020-10-16  2:14 ` [folded-merged] xarray-add-xas_split-fix.patch " Andrew Morton
2020-10-16  2:14 ` [folded-merged] xarray-add-xas_split-fix-2.patch " Andrew Morton
2020-10-16  2:14 ` [folded-merged] xarray-add-xas_split-fix-3patch.patch " Andrew Morton
2020-10-16  2:15 ` [folded-merged] mm-memory-remove-page-fault-assumption-of-compound-page-size-fix.patch " Andrew Morton
2020-10-16  2:16 ` [folded-merged] mm-memory_hotplug-simplify-page-offlining-fix.patch " Andrew Morton
2020-10-16  2:17 ` [folded-merged] kernel-resource-make-release_mem_region_adjustable-never-fail-fix.patch " Andrew Morton
2020-10-16  2:19 ` [folded-merged] checkpatch-warn-on-self-assignments-checkpatch-fixes.patch " Andrew Morton
2020-10-16  2:20 ` [folded-merged] checkpatch-allow-not-using-f-with-files-that-are-in-git-fix.patch " Andrew Morton
2020-10-16  2:20 ` [folded-merged] checkpatch-emit-a-warning-on-embedded-filenames-fix.patch " Andrew Morton
2020-10-16  2:21 ` [folded-merged] fs-binfmt_elf-use-pt_load-p_align-values-for-suitable-start-address-fix.patch " Andrew Morton
2020-10-16  2:21 ` [folded-merged] fs-binfmt_elf-use-pt_load-p_align-values-for-suitable-start-address-v4.patch " Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201011061637.E_t0y98Vu%akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=andres@anarazel.de \
    --cc=david@fromorbit.com \
    --cc=dhowells@redhat.com \
    --cc=hch@infradead.org \
    --cc=jack@suse.cz \
    --cc=jlayton@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=minchan@kernel.org \
    --cc=mm-commits@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=viro@zeniv.linux.org.uk \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).