From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C61EAC433E7 for ; Fri, 16 Oct 2020 03:09:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 773C2208E4 for ; Fri, 16 Oct 2020 03:09:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602817792; bh=cn5yultem/+6mHypbbQ8ih+AQKc065J7TXIe6Lvy4/M=; h=Date:From:To:Subject:In-Reply-To:Reply-To:List-ID:From; b=ZeVQH/Pre/WxHfdBKBjueIu564qECIlpaNA/zRYnfvolIJl8bqJZeFSd7pwcwEaKE mkFkInOTFP7f6DHeaKInivhoCEBicqEHmwh9b3KlwaRju29iqAwiaTEx0KRG4E7NyE PlXv6F0rXc/7CgPk+EAjSoeCV9qVuephm0ce9aSE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731908AbgJPDJw (ORCPT ); Thu, 15 Oct 2020 23:09:52 -0400 Received: from mail.kernel.org ([198.145.29.99]:47190 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726528AbgJPDJv (ORCPT ); Thu, 15 Oct 2020 23:09:51 -0400 Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id EBA0E20897; Fri, 16 Oct 2020 03:09:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602817790; bh=cn5yultem/+6mHypbbQ8ih+AQKc065J7TXIe6Lvy4/M=; h=Date:From:To:Subject:In-Reply-To:From; b=2tRZA/5YCCEByX6cZpQ/GJJbrctjh8qWf3wA8QwMrjA69QaJRdFWHamVr2XoGOkjl DZgBSPlKvfb9Wo1nb3F+ESaCpfGycFKOa4YUXDWXx8IR+F7U1ZmvZ/YgX6Hz3WhUw7 jJDQhqY51pFt8nLZW72lSplurTS5zG8X3pqzCJDs= Date: Thu, 15 Oct 2020 20:09:49 -0700 From: Andrew Morton To: akpm@linux-foundation.org, alexander.h.duyck@linux.intel.com, david@redhat.com, mm-commits@vger.kernel.org, richard.weiyang@linux.alibaba.com, torvalds@linux-foundation.org Subject: [patch 086/156] mm/page_reporting.c: drop stale list head check in page_reporting_cycle Message-ID: <20201016030949.oT_g5Vxrz%akpm@linux-foundation.org> In-Reply-To: <20201015194043.84cda0c1d6ca2a6847f2384a@linux-foundation.org> User-Agent: s-nail v14.8.16 Precedence: bulk Reply-To: linux-kernel@vger.kernel.org List-ID: X-Mailing-List: mm-commits@vger.kernel.org From: Wei Yang Subject: mm/page_reporting.c: drop stale list head check in page_reporting_cycle list_for_each_entry_safe() guarantees that we will never stumble over the list head; "&page->lru != list" will always evaluate to true. Let's simplify. [david@redhat.com: Changelog refinements] Link: http://lkml.kernel.org/r/20200818084448.33969-1-richard.weiyang@linux.alibaba.com Signed-off-by: Wei Yang Reviewed-by: David Hildenbrand Reviewed-by: Alexander Duyck Signed-off-by: Andrew Morton --- mm/page_reporting.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/mm/page_reporting.c~mm-page_reporting-drop-stale-list-head-check-in-page_reporting_cycle +++ a/mm/page_reporting.c @@ -178,7 +178,7 @@ page_reporting_cycle(struct page_reporti * the new head of the free list before we release the * zone lock. */ - if (&page->lru != list && !list_is_first(&page->lru, list)) + if (!list_is_first(&page->lru, list)) list_rotate_to_front(&page->lru, list); /* release lock before waiting on report processing */ _