From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9E52C433DF for ; Fri, 16 Oct 2020 03:11:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 83AD42087D for ; Fri, 16 Oct 2020 03:11:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602817891; bh=QoUnqKZJPGgPSD2L+NFlQaQN482vyk4CXuqa4iADZfM=; h=Date:From:To:Subject:In-Reply-To:Reply-To:List-ID:From; b=Yop96+bAgXlbi3/XE97ASWH2SFFk+sRyE2RD3fgToON3xQEfwgSjKe0Nem+f4qMNS pQcW0WktW32vioxDktasjKQZeqZAMkCec5mX+lZBXFdGbmQJXg5wInx69I/6SztS4k k3fvVaepVmO16aI6J79xRbtTdZ8PgPs/SLrXTktk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388453AbgJPDLb (ORCPT ); Thu, 15 Oct 2020 23:11:31 -0400 Received: from mail.kernel.org ([198.145.29.99]:48004 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387864AbgJPDLb (ORCPT ); Thu, 15 Oct 2020 23:11:31 -0400 Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id EAD0C20789; Fri, 16 Oct 2020 03:11:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602817889; bh=QoUnqKZJPGgPSD2L+NFlQaQN482vyk4CXuqa4iADZfM=; h=Date:From:To:Subject:In-Reply-To:From; b=SePivQksg1NVUpyx7F7vZJs6CBAlwR0rmMiHmLsiXDzY4Jre6952D108T2/PSqYHO 6+3y9BtAFFejk6qSLc6Htks7PVCan/PBTnyMQ68aH378/YNh+6flUmb+/ybV1CQnf0 RJkimzQL2DDmq6XSC5eMUmUtqiryRWptYMZLARuQ= Date: Thu, 15 Oct 2020 20:11:28 -0700 From: Andrew Morton To: akpm@linux-foundation.org, linmiaohe@huawei.com, mm-commits@vger.kernel.org, torvalds@linux-foundation.org Subject: [patch 115/156] lib/percpu_counter.c: use helper macro abs() Message-ID: <20201016031128.n1q0vLw8O%akpm@linux-foundation.org> In-Reply-To: <20201015194043.84cda0c1d6ca2a6847f2384a@linux-foundation.org> User-Agent: s-nail v14.8.16 Precedence: bulk Reply-To: linux-kernel@vger.kernel.org List-ID: X-Mailing-List: mm-commits@vger.kernel.org From: Miaohe Lin Subject: lib/percpu_counter.c: use helper macro abs() Use helper macro abs() to simplify the "x >= t || x <= -t" cmp. Link: https://lkml.kernel.org/r/20200927122746.5964-1-linmiaohe@huawei.com Signed-off-by: Miaohe Lin Reviewed-by: Andrew Morton Signed-off-by: Andrew Morton --- lib/percpu_counter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/lib/percpu_counter.c~percpu_counter-use-helper-macro-abs +++ a/lib/percpu_counter.c @@ -85,7 +85,7 @@ void percpu_counter_add_batch(struct per preempt_disable(); count = __this_cpu_read(*fbc->counters) + amount; - if (count >= batch || count <= -batch) { + if (abs(count) >= batch) { unsigned long flags; raw_spin_lock_irqsave(&fbc->lock, flags); fbc->count += count; _