From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ABEEDC433DF for ; Fri, 16 Oct 2020 03:13:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 53B4020FC3 for ; Fri, 16 Oct 2020 03:13:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602818004; bh=A0ChrCDCJhPaDEnC2n0JcMIBX/9RljacmUDs2z2DTAA=; h=Date:From:To:Subject:In-Reply-To:Reply-To:List-ID:From; b=ug+yr9K6ueFUkw8pRbmdGeUl2VbRjAr1d3uUIsxN2AsEGZ/t3Twu4ZOTInYIRg5Sh 6btDnGoOG3mBSIQ9mlNui9PBiFmsn8EJ/NBqZSoG48vHw0KmVrXlbMISjlHfN5qli5 Z76w2BKoP8w36tA5CQkfmc8fiHv3BuQelcVKm0uQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2393958AbgJPDNY (ORCPT ); Thu, 15 Oct 2020 23:13:24 -0400 Received: from mail.kernel.org ([198.145.29.99]:49030 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2393799AbgJPDNX (ORCPT ); Thu, 15 Oct 2020 23:13:23 -0400 Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D7EAF20E65; Fri, 16 Oct 2020 03:13:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602818003; bh=A0ChrCDCJhPaDEnC2n0JcMIBX/9RljacmUDs2z2DTAA=; h=Date:From:To:Subject:In-Reply-To:From; b=ANjxzFDTT5pELmN/L7UrR7l2jPg7Z6cOi5NKGTA9Ymb/3v51Yeoa8PbT4GpRAcUuS dNtJAnEdVZNvgdFovA8GOsBALE0B6w32j3RPZLszUIbDkhh38dp2dxhpJL2rEFo1Za Z92FXKujKUf+s5HgJeLHYI77ZO7ljzIFbrx2xYpo= Date: Thu, 15 Oct 2020 20:13:22 -0700 From: Andrew Morton To: aik@ozlabs.ru, akpm@linux-foundation.org, aquini@redhat.com, dianders@chromium.org, keescook@chromium.org, mingo@kernel.org, mm-commits@vger.kernel.org, npiggin@gmail.com, tglx@linutronix.de, torvalds@linux-foundation.org, will@kernel.org Subject: [patch 148/156] panic: dump registers on panic_on_warn Message-ID: <20201016031322.82K_GCvVc%akpm@linux-foundation.org> In-Reply-To: <20201015194043.84cda0c1d6ca2a6847f2384a@linux-foundation.org> User-Agent: s-nail v14.8.16 Precedence: bulk Reply-To: linux-kernel@vger.kernel.org List-ID: X-Mailing-List: mm-commits@vger.kernel.org From: Alexey Kardashevskiy Subject: panic: dump registers on panic_on_warn Currently we print stack and registers for ordinary warnings but we do not for panic_on_warn which looks as oversight - panic() will reboot the machine but won't print registers. This moves printing of registers and modules earlier. This does not move the stack dumping as panic() dumps it. Link: https://lkml.kernel.org/r/20200804095054.68724-1-aik@ozlabs.ru Signed-off-by: Alexey Kardashevskiy Reviewed-by: Kees Cook Cc: Douglas Anderson Cc: Ingo Molnar Cc: Kees Cook Cc: Rafael Aquini Cc: Thomas Gleixner Cc: Will Deacon Cc: Nicholas Piggin Signed-off-by: Andrew Morton --- kernel/panic.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) --- a/kernel/panic.c~panic-dump-registers-on-panic_on_warn +++ a/kernel/panic.c @@ -589,6 +589,11 @@ void __warn(const char *file, int line, if (args) vprintk(args->fmt, args->args); + print_modules(); + + if (regs) + show_regs(regs); + if (panic_on_warn) { /* * This thread may hit another WARN() in the panic path. @@ -600,12 +605,7 @@ void __warn(const char *file, int line, panic("panic_on_warn set ...\n"); } - print_modules(); - - if (regs) - show_regs(regs); - else - dump_stack(); + dump_stack(); print_irqtrace_events(current); _