From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B517C433DF for ; Fri, 16 Oct 2020 20:49:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F036F21775 for ; Fri, 16 Oct 2020 20:49:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602881391; bh=QB49mTd86gVeQYmnTERgd3H34eWGb8YdvSOvuxrsPz0=; h=Date:From:To:Subject:Reply-To:List-ID:From; b=E5HrEmyT+lFAinonv0Ofj++++gH8gCaHLbGpWOQf/91tC8/rYlpCK4ApXSQ1MvFSE xWiBT9gxSGpSKn8DiCktpp4aGGZ22cIjrK/jeG8w7meAaPJNNQuENsIhqVlyiBHQv4 hbRbAqSBAA6lNK4h/cetTHAKKWmLmAniv1l72KDw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392727AbgJPUtu (ORCPT ); Fri, 16 Oct 2020 16:49:50 -0400 Received: from mail.kernel.org ([198.145.29.99]:38938 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2392725AbgJPUtu (ORCPT ); Fri, 16 Oct 2020 16:49:50 -0400 Received: from localhost.localdomain (c-71-198-47-131.hsd1.ca.comcast.net [71.198.47.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 25BFB20878; Fri, 16 Oct 2020 20:49:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602881389; bh=QB49mTd86gVeQYmnTERgd3H34eWGb8YdvSOvuxrsPz0=; h=Date:From:To:Subject:From; b=TkbokTJCvQe4O+hm4nXoBkx1dnHnFZ0/7Kb7Z7CpPvNnEmEB1KwH2bV42uN5MQfAj UdOyarzDzCYyndb31by+/u+hpWPSUCOS6iqrihtAt0+r4cX52v0kVW4in2a0Of2u10 0P4BrtiFko7sHfdD5Qg8fIu1VUVdd/yP1hy6edKI= Date: Fri, 16 Oct 2020 13:49:48 -0700 From: akpm@linux-foundation.org To: aneesh.kumar@linux.ibm.com, aneesh.kumar@linux.vnet.ibm.com, aris@ruivo.org, cai@lca.pw, dave.hansen@intel.com, david@redhat.com, mhocko@kernel.org, mike.kravetz@oracle.com, mm-commits@vger.kernel.org, naoya.horiguchi@nec.com, osalvador@suse.com, osalvador@suse.de, tony.luck@intel.com, zeil@yandex-team.ru Subject: [merged] mmhwpoison-try-to-narrow-window-race-for-free-pages.patch removed from -mm tree Message-ID: <20201016204948.e-EySrtf7%akpm@linux-foundation.org> User-Agent: s-nail v14.8.16 Precedence: bulk Reply-To: linux-kernel@vger.kernel.org List-ID: X-Mailing-List: mm-commits@vger.kernel.org The patch titled Subject: mm,hwpoison: try to narrow window race for free pages has been removed from the -mm tree. Its filename was mmhwpoison-try-to-narrow-window-race-for-free-pages.patch This patch was dropped because it was merged into mainline or a subsystem tree ------------------------------------------------------ From: Oscar Salvador Subject: mm,hwpoison: try to narrow window race for free pages Aristeu Rozanski reported that a customer test case started to report -EBUSY after the hwpoison rework patchset. There is a race window between spotting a free page and taking it off its buddy freelist, so it might be that by the time we try to take it off, the page has been already allocated. This patch tries to handle such race window by trying to handle the new type of page again if the page was allocated under us. Link: https://lkml.kernel.org/r/20200922135650.1634-15-osalvador@suse.de Signed-off-by: Oscar Salvador Reported-by: Aristeu Rozanski Tested-by: Aristeu Rozanski Acked-by: Naoya Horiguchi Cc: "Aneesh Kumar K.V" Cc: Aneesh Kumar K.V Cc: Dave Hansen Cc: David Hildenbrand Cc: Dmitry Yakunin Cc: Michal Hocko Cc: Mike Kravetz Cc: Oscar Salvador Cc: Qian Cai Cc: Tony Luck Signed-off-by: Andrew Morton --- mm/memory-failure.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) --- a/mm/memory-failure.c~mmhwpoison-try-to-narrow-window-race-for-free-pages +++ a/mm/memory-failure.c @@ -1903,6 +1903,7 @@ int soft_offline_page(unsigned long pfn, { int ret; struct page *page; + bool try_again = true; if (!pfn_valid(pfn)) return -ENXIO; @@ -1918,6 +1919,7 @@ int soft_offline_page(unsigned long pfn, return 0; } +retry: get_online_mems(); ret = get_any_page(page, pfn, flags); put_online_mems(); @@ -1925,7 +1927,10 @@ int soft_offline_page(unsigned long pfn, if (ret > 0) ret = soft_offline_in_use_page(page); else if (ret == 0) - ret = soft_offline_free_page(page); + if (soft_offline_free_page(page) && try_again) { + try_again = false; + goto retry; + } return ret; } _ Patches currently in -mm which might be from osalvador@suse.de are