From: Mike Rapoport <rppt@linux.ibm.com>
To: David Hildenbrand <david@redhat.com>
Cc: akpm@linux-foundation.org, aarcange@redhat.com, bhe@redhat.com,
cai@lca.pw, mgorman@suse.de, mhocko@kernel.org,
mm-commits@vger.kernel.org, stable@vger.kernel.org,
vbabka@suse.cz
Subject: Re: + mm-initialize-struct-pages-in-reserved-regions-outside-of-the-zone-ranges.patch added to -mm tree
Date: Mon, 7 Dec 2020 11:45:55 +0200 [thread overview]
Message-ID: <20201207094555.GD1112728@linux.ibm.com> (raw)
In-Reply-To: <cb3bfacb-821d-6251-03c5-498dd07727cd@redhat.com>
On Mon, Dec 07, 2020 at 09:58:37AM +0100, David Hildenbrand wrote:
> On 06.12.20 01:54, akpm@linux-foundation.org wrote:
> >
> > The patch titled
> > Subject: mm: initialize struct pages in reserved regions outside of the zone ranges
> > has been added to the -mm tree. Its filename is
> > mm-initialize-struct-pages-in-reserved-regions-outside-of-the-zone-ranges.patch
> >
> > This patch should soon appear at
> > https://ozlabs.org/~akpm/mmots/broken-out/mm-initialize-struct-pages-in-reserved-regions-outside-of-the-zone-ranges.patch
> > and later at
> > https://ozlabs.org/~akpm/mmotm/broken-out/mm-initialize-struct-pages-in-reserved-regions-outside-of-the-zone-ranges.patch
> >
> > Before you just go and hit "reply", please:
> > a) Consider who else should be cc'ed
> > b) Prefer to cc a suitable mailing list as well
> > c) Ideally: find the original patch on the mailing list and do a
> > reply-to-all to that, adding suitable additional cc's
> >
> > *** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
> >
> > The -mm tree is included into linux-next and is updated
> > there every 3-4 working days
> >
> > ------------------------------------------------------
> > From: Andrea Arcangeli <aarcange@redhat.com>
> > Subject: mm: initialize struct pages in reserved regions outside of the zone ranges
> >
> > Without this change, the pfn 0 isn't in any zone spanned range, and it's
> > also not in any memory.memblock range, so the struct page of pfn 0 wasn't
> > initialized and the PagePoison remained set when reserve_bootmem_region
> > called __SetPageReserved, inducing a silent boot failure with DEBUG_VM
> > (and correctly so, because the crash signaled the nodeid/nid of pfn 0
> > would be again wrong).
> >
> > There's no enforcement that all memblock.reserved ranges must overlap
> > memblock.memory ranges, so the memblock.reserved ranges also require an
> > explicit initialization and the zones ranges need to be extended to
> > include all memblock.reserved ranges with struct pages too or they'll be
> > left uninitialized with PagePoison as it happened to pfn 0.
> >
> > Link: https://lkml.kernel.org/r/20201205013238.21663-2-aarcange@redhat.com
> > Fixes: 73a6e474cb37 ("mm: memmap_init: iterate over memblock regions rather that check each PFN")
> > Signed-off-by: Andrea Arcangeli <aarcange@redhat.com>
> > Cc: Mike Rapoport <rppt@linux.ibm.com>
> > Cc: Baoquan He <bhe@redhat.com>
> > Cc: David Hildenbrand <david@redhat.com>
> > Cc: Mel Gorman <mgorman@suse.de>
> > Cc: Michal Hocko <mhocko@kernel.org>
> > Cc: Qian Cai <cai@lca.pw>
> > Cc: Vlastimil Babka <vbabka@suse.cz>
> > Cc: <stable@vger.kernel.org>
> > Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
>
> [...]
>
> I've lost track which patches are we considering right now to solve the
> overall issue. I'd appreciate a proper patch series with all relevant
> patches.
I think none of the patches is 100% right.
I'll try to send a new version today.
> --
> Thanks,
>
> David / dhildenb
>
--
Sincerely yours,
Mike.
prev parent reply other threads:[~2020-12-07 9:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-06 0:54 + mm-initialize-struct-pages-in-reserved-regions-outside-of-the-zone-ranges.patch added to -mm tree akpm
2020-12-06 6:48 ` Mike Rapoport
2020-12-06 19:30 ` Andrea Arcangeli
2020-12-07 16:50 ` Mike Rapoport
2020-12-08 2:57 ` Andrea Arcangeli
2020-12-08 21:46 ` Mike Rapoport
2020-12-08 23:13 ` Andrea Arcangeli
2020-12-09 21:42 ` Mike Rapoport
2020-12-07 8:58 ` David Hildenbrand
2020-12-07 9:45 ` Mike Rapoport [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201207094555.GD1112728@linux.ibm.com \
--to=rppt@linux.ibm.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=bhe@redhat.com \
--cc=cai@lca.pw \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mhocko@kernel.org \
--cc=mm-commits@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).