* + mm-vmallocc-fix-potential-memory-leak.patch added to -mm tree
@ 2021-01-07 23:10 akpm
0 siblings, 0 replies; only message in thread
From: akpm @ 2021-01-07 23:10 UTC (permalink / raw)
To: linmiaohe, luoshijie1, mm-commits, stable, urezki
The patch titled
Subject: mm/vmalloc.c: fix potential memory leak
has been added to the -mm tree. Its filename is
mm-vmallocc-fix-potential-memory-leak.patch
This patch should soon appear at
https://ozlabs.org/~akpm/mmots/broken-out/mm-vmallocc-fix-potential-memory-leak.patch
and later at
https://ozlabs.org/~akpm/mmotm/broken-out/mm-vmallocc-fix-potential-memory-leak.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Miaohe Lin <linmiaohe@huawei.com>
Subject: mm/vmalloc.c: fix potential memory leak
In VM_MAP_PUT_PAGES case, we should put pages and free array in vfree.
But we missed to set area->nr_pages in vmap(). So we would failed to put
pages in __vunmap() because area->nr_pages = 0.
Link: https://lkml.kernel.org/r/20210107123541.39206-1-linmiaohe@huawei.com
Fixes: b944afc9d64d ("mm: add a VM_MAP_PUT_PAGES flag for vmap")
Signed-off-by: Shijie Luo <luoshijie1@huawei.com>
Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
Reviewed-by: Uladzislau Rezki (Sony) <urezki@gmail.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
mm/vmalloc.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
--- a/mm/vmalloc.c~mm-vmallocc-fix-potential-memory-leak
+++ a/mm/vmalloc.c
@@ -2420,8 +2420,10 @@ void *vmap(struct page **pages, unsigned
return NULL;
}
- if (flags & VM_MAP_PUT_PAGES)
+ if (flags & VM_MAP_PUT_PAGES) {
area->pages = pages;
+ area->nr_pages = count;
+ }
return area->addr;
}
EXPORT_SYMBOL(vmap);
_
Patches currently in -mm which might be from linmiaohe@huawei.com are
mm-vmallocc-fix-potential-memory-leak.patch
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2021-01-07 23:11 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-07 23:10 + mm-vmallocc-fix-potential-memory-leak.patch added to -mm tree akpm
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).