From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_RED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 189F7C433E6 for ; Sat, 13 Mar 2021 05:08:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D8E9964FA6 for ; Sat, 13 Mar 2021 05:08:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231392AbhCMFHj (ORCPT ); Sat, 13 Mar 2021 00:07:39 -0500 Received: from mail.kernel.org ([198.145.29.99]:41392 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230114AbhCMFHJ (ORCPT ); Sat, 13 Mar 2021 00:07:09 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id D38F764F87; Sat, 13 Mar 2021 05:07:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1615612029; bh=Kr6+Jj1E1bAcLs+tlaatwaYAwGyLmP2QRBg+v9A8+18=; h=Date:From:To:Subject:In-Reply-To:From; b=GWAjcvq2fCSqrbjMPuLY/0pbme7sicMwZrLmgaP5doZ6utmJpaUEZcNQ9a7UvfKML CtS58A+vLDWypTvXHuNfEbRwiPvCpi+YUdgywW77D43+C0flwvzcYXcSgxfL/AIQee ZlJJ7YNE8O8rE7Piu0wwLuqkslBclljdVwNFFyLY= Date: Fri, 12 Mar 2021 21:07:08 -0800 From: Andrew Morton To: akpm@linux-foundation.org, arnd@kernel.org, daniel@iogearbox.net, hannes@cmpxchg.org, hca@linux.ibm.com, keescook@chromium.org, kpsingh@google.com, linux-mm@kvack.org, linux@roeck-us.net, lkml@metux.net, masahiroy@kernel.org, mm-commits@vger.kernel.org, nathan@kernel.org, qperret@google.com, terrelln@fb.com, torvalds@linux-foundation.org, valentin.schneider@arm.com Subject: [patch 03/29] init/Kconfig: make COMPILE_TEST depend on HAS_IOMEM Message-ID: <20210313050708.23E_e0qbS%akpm@linux-foundation.org> In-Reply-To: <20210312210632.9b7d62973d72a56fb13c7a03@linux-foundation.org> User-Agent: s-nail v14.8.16 Precedence: bulk Reply-To: linux-kernel@vger.kernel.org List-ID: X-Mailing-List: mm-commits@vger.kernel.org From: Masahiro Yamada Subject: init/Kconfig: make COMPILE_TEST depend on HAS_IOMEM I read the commit log of the following two: - bc083a64b6c0 ("init/Kconfig: make COMPILE_TEST depend on !UML") - 334ef6ed06fa ("init/Kconfig: make COMPILE_TEST depend on !S390") Both are talking about HAS_IOMEM dependency missing in many drivers. So, 'depends on HAS_IOMEM' seems the direct, sensible solution to me. This does not change the behavior of UML. UML still cannot enable COMPILE_TEST because it does not provide HAS_IOMEM. The current dependency for S390 is too strong. Under the condition of CONFIG_PCI=y, S390 provides HAS_IOMEM, hence can enable COMPILE_TEST. I also removed the meaningless 'default n'. Link: https://lkml.kernel.org/r/20210224140809.1067582-1-masahiroy@kernel.org Signed-off-by: Masahiro Yamada Cc: Heiko Carstens Cc: Guenter Roeck Cc: Arnd Bergmann Cc: Kees Cook Cc: Daniel Borkmann Cc: Johannes Weiner Cc: KP Singh Cc: Nathan Chancellor Cc: Nick Terrell Cc: Quentin Perret Cc: Valentin Schneider Cc: "Enrico Weigelt, metux IT consult" Signed-off-by: Andrew Morton --- init/Kconfig | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- a/init/Kconfig~init-kconfig-make-compile_test-depend-on-has_iomem +++ a/init/Kconfig @@ -119,8 +119,7 @@ config INIT_ENV_ARG_LIMIT config COMPILE_TEST bool "Compile also drivers which will not load" - depends on !UML && !S390 - default n + depends on HAS_IOMEM help Some drivers can be compiled on a different platform than they are intended to be run on. Despite they cannot be loaded there (or even _