From: Matthew Wilcox <willy@infradead.org>
To: James Bottomley <jejb@linux.ibm.com>
Cc: akpm@linux-foundation.org, arnd@arndb.de, bp@alien8.de,
catalin.marinas@arm.com, cl@linux.com, dan.j.williams@intel.com,
dave.hansen@linux.intel.com, david@redhat.com,
elena.reshetova@intel.com, guro@fb.com, hagen@jauu.net,
hpa@zytor.com, kirill@shutemov.name, luto@kernel.org,
mark.rutland@arm.com, mingo@redhat.com,
mm-commits@vger.kernel.org, mtk.manpages@gmail.com,
palmer@dabbelt.com, palmerdabbelt@google.com,
paul.walmsley@sifive.com, peterz@infradead.org,
rick.p.edgecombe@intel.com, rppt@linux.ibm.com,
shakeelb@google.com, shuah@kernel.org, tglx@linutronix.de,
tycho@tycho.ws, viro@zeniv.linux.org.uk, will@kernel.org
Subject: Re: + mm-add-definition-of-pmd_page_order.patch added to -mm tree
Date: Thu, 18 Mar 2021 00:15:38 +0000 [thread overview]
Message-ID: <20210318001538.GI3420@casper.infradead.org> (raw)
In-Reply-To: <42da5805da8dad56818d2047b2e64c20ec7d030d.camel@linux.ibm.com>
On Wed, Mar 17, 2021 at 04:19:06PM -0700, James Bottomley wrote:
> On Wed, 2021-03-17 at 22:54 +0000, Matthew Wilcox wrote:
> > On Wed, Mar 17, 2021 at 03:15:12PM -0700, akpm@linux-foundation.org
> > wrote:
> > > Several architectures already have definition of PMD_ORDER as the
> > > size of second level page table, so to avoid conflict with these
> > > definitions use PMD_PAGE_ORDER name and update DAX respectively.
> >
> > I thought I NACKed this patch already?
>
> I don't think anyone understands why. DAX won't build on several
> architectures, including parisc, because of this existing symbol clash.
>
> > The architectures should be updated to not use PMD_ORDER. PMD_ORDER
> > is clearly the right name for what is now PMD_PAGE_ORDER. The
> > architectures should be using PMD_ALLOC_ORDER or some such.
https://lore.kernel.org/linux-fsdevel/20201204034843.GM11935@casper.infradead.org/
was where I said what I wanted.
> Well I had a patch renaming the dax specific one to DAX_PMD_ORDER which
> you also didn't like. Why don't you just propose the patch you do like
> because this is a build failure on several architectures currently.
>
> I don't really care what colour the bike shed is ... I do care that my
> builds fail.
I was expecting you to do the rename, since it's inconveniencing you.
It doesn't cause me any trouble at all.
next prev parent reply other threads:[~2021-03-18 0:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-17 22:15 + mm-add-definition-of-pmd_page_order.patch added to -mm tree akpm
2021-03-17 22:54 ` Matthew Wilcox
2021-03-17 23:19 ` James Bottomley
2021-03-18 0:15 ` Matthew Wilcox [this message]
2021-03-18 1:04 ` James Bottomley
2021-03-18 16:14 ` Mike Rapoport
-- strict thread matches above, loose matches on Subject: below --
2020-12-03 23:42 akpm
2020-11-12 22:13 akpm
2020-09-25 2:35 akpm
2020-09-16 23:20 akpm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210318001538.GI3420@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=bp@alien8.de \
--cc=catalin.marinas@arm.com \
--cc=cl@linux.com \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=david@redhat.com \
--cc=elena.reshetova@intel.com \
--cc=guro@fb.com \
--cc=hagen@jauu.net \
--cc=hpa@zytor.com \
--cc=jejb@linux.ibm.com \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=mm-commits@vger.kernel.org \
--cc=mtk.manpages@gmail.com \
--cc=palmer@dabbelt.com \
--cc=palmerdabbelt@google.com \
--cc=paul.walmsley@sifive.com \
--cc=peterz@infradead.org \
--cc=rick.p.edgecombe@intel.com \
--cc=rppt@linux.ibm.com \
--cc=shakeelb@google.com \
--cc=shuah@kernel.org \
--cc=tglx@linutronix.de \
--cc=tycho@tycho.ws \
--cc=viro@zeniv.linux.org.uk \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).