From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_RED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD03DC433EA for ; Thu, 25 Mar 2021 04:38:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8ED7661A14 for ; Thu, 25 Mar 2021 04:38:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229590AbhCYEhn (ORCPT ); Thu, 25 Mar 2021 00:37:43 -0400 Received: from mail.kernel.org ([198.145.29.99]:44348 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229810AbhCYEhj (ORCPT ); Thu, 25 Mar 2021 00:37:39 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id ECE9661A14; Thu, 25 Mar 2021 04:37:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1616647059; bh=wfJi57xT+118C0KLVKwFyTA+/dJ745EM5w1Q2vP9ACg=; h=Date:From:To:Subject:In-Reply-To:From; b=aoodT+Nmk0qjST3K9QRVg44aKyDx5X9t2jkwgubE0IvlJMhoUSqawnKu+WtDu5BLx JlSeRXu+it/OtfbgpTz3P5T4/EAZ1VbG/5yAbD8Nw941Uq7wLtdUdCaOUz+At2dSSy 4LKWUCelxLx369LZdklL3xqIrwfcMLFacLKS7R1c= Date: Wed, 24 Mar 2021 21:37:38 -0700 From: Andrew Morton To: akpm@linux-foundation.org, linux-mm@kvack.org, mm-commits@vger.kernel.org, slyfox@gentoo.org, torvalds@linux-foundation.org Subject: [patch 08/14] ia64: mca: allocate early mca with GFP_ATOMIC Message-ID: <20210325043738.dMGofoOUi%akpm@linux-foundation.org> In-Reply-To: <20210324213644.bf03a529aec4ef9580e17dbc@linux-foundation.org> User-Agent: s-nail v14.8.16 Precedence: bulk Reply-To: linux-kernel@vger.kernel.org List-ID: X-Mailing-List: mm-commits@vger.kernel.org From: Sergei Trofimovich Subject: ia64: mca: allocate early mca with GFP_ATOMIC The sleep warning happens at early boot right at secondary CPU activation bootup: smp: Bringing up secondary CPUs ... BUG: sleeping function called from invalid context at mm/page_alloc.c:4942 in_atomic(): 0, irqs_disabled(): 1, non_block: 0, pid: 0, name: swapper/1 CPU: 1 PID: 0 Comm: swapper/1 Not tainted 5.12.0-rc2-00007-g79e228d0b611-dirty #99 Call Trace: [] show_stack+0x90/0xc0 [] dump_stack+0x150/0x1c0 [] ___might_sleep+0x1c0/0x2a0 [] __might_sleep+0xa0/0x160 [] __alloc_pages_nodemask+0x1a0/0x600 [] alloc_page_interleave+0x30/0x1c0 [] alloc_pages_current+0x2c0/0x340 [] __get_free_pages+0x30/0xa0 [] ia64_mca_cpu_init+0x2d0/0x3a0 [] cpu_init+0x8b0/0x1440 [] start_secondary+0x60/0x700 [] start_ap+0x750/0x780 Fixed BSP b0 value from CPU 1 As I understand interrupts are not enabled yet and system has a lot of memory. There is little chance to sleep and switch to GFP_ATOMIC should be a no-op. Link: https://lkml.kernel.org/r/20210315085045.204414-1-slyfox@gentoo.org Signed-off-by: Sergei Trofimovich Signed-off-by: Andrew Morton --- arch/ia64/kernel/mca.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/arch/ia64/kernel/mca.c~ia64-mca-allocate-early-mca-with-gfp_atomic +++ a/arch/ia64/kernel/mca.c @@ -1824,7 +1824,7 @@ ia64_mca_cpu_init(void *cpu_data) data = mca_bootmem(); first_time = 0; } else - data = (void *)__get_free_pages(GFP_KERNEL, + data = (void *)__get_free_pages(GFP_ATOMIC, get_order(sz)); if (!data) panic("Could not allocate MCA memory for cpu %d\n", _