From: Andrew Morton <akpm@linux-foundation.org>
To: mm-commits@vger.kernel.org, kernel@gpiccoli.net,
gpiccoli@igalia.com, akpm@linux-foundation.org,
akpm@linux-foundation.org
Subject: + notifiers-add-tracepoints-to-the-notifiers-infrastructure-checkpatch-fixes.patch added to mm-nonmm-unstable branch
Date: Tue, 14 Mar 2023 13:51:57 -0700 [thread overview]
Message-ID: <20230314205158.21BCBC433EF@smtp.kernel.org> (raw)
The patch titled
Subject: notifiers-add-tracepoints-to-the-notifiers-infrastructure-checkpatch-fixes
has been added to the -mm mm-nonmm-unstable branch. Its filename is
notifiers-add-tracepoints-to-the-notifiers-infrastructure-checkpatch-fixes.patch
This patch will shortly appear at
https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/notifiers-add-tracepoints-to-the-notifiers-infrastructure-checkpatch-fixes.patch
This patch will later appear in the mm-nonmm-unstable branch at
git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next via the mm-everything
branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
and is updated there every 2-3 working days
------------------------------------------------------
From: Andrew Morton <akpm@linux-foundation.org>
Subject: notifiers-add-tracepoints-to-the-notifiers-infrastructure-checkpatch-fixes
Date: Tue Mar 14 01:51:03 PM PDT 2023
ERROR: "(foo*)" should be "(foo *)"
#117: FILE: kernel/notifier.c:43:
+ trace_notifiers_register((void*)n->notifier_call);
ERROR: "(foo*)" should be "(foo *)"
#125: FILE: kernel/notifier.c:53:
+ trace_notifiers_unregister((void*)n->notifier_call);
ERROR: "(foo*)" should be "(foo *)"
#133: FILE: kernel/notifier.c:92:
+ trace_notifiers_run((void*)nb->notifier_call);
total: 3 errors, 0 warnings, 99 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
./patches/notifiers-add-tracepoints-to-the-notifiers-infrastructure.patch has style problems, please review.
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
Please run checkpatch prior to sending patches
Cc: "Guilherme G. Piccoli" <gpiccoli@igalia.com>
Cc: Guilherme G. Piccoli <kernel@gpiccoli.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
--- a/kernel/notifier.c~notifiers-add-tracepoints-to-the-notifiers-infrastructure-checkpatch-fixes
+++ a/kernel/notifier.c
@@ -40,7 +40,7 @@ static int notifier_chain_register(struc
}
n->next = *nl;
rcu_assign_pointer(*nl, n);
- trace_notifiers_register((void*)n->notifier_call);
+ trace_notifiers_register((void *)n->notifier_call);
return 0;
}
@@ -50,7 +50,7 @@ static int notifier_chain_unregister(str
while ((*nl) != NULL) {
if ((*nl) == n) {
rcu_assign_pointer(*nl, n->next);
- trace_notifiers_unregister((void*)n->notifier_call);
+ trace_notifiers_unregister((void *)n->notifier_call);
return 0;
}
nl = &((*nl)->next);
@@ -89,7 +89,7 @@ static int notifier_call_chain(struct no
continue;
}
#endif
- trace_notifiers_run((void*)nb->notifier_call);
+ trace_notifiers_run((void *)nb->notifier_call);
ret = nb->notifier_call(nb, val, v);
if (nr_calls)
_
Patches currently in -mm which might be from akpm@linux-foundation.org are
mm-page_alloc-reduce-page-alloc-free-sanity-checks-checkpatch-fixes.patch
mm-page_alloc-reduce-page-alloc-free-sanity-checks-fix.patch
mm-userfaultfd-support-wp-on-multiple-vmas-fix.patch
mm-add-new-api-to-enable-ksm-per-process-fix.patch
vmstat-add-pcp-remote-node-draining-via-cpu_vm_stats_fold-fix.patch
scripts-link-vmlinuxsh-fix-error-message-presentation.patch
notifiers-add-tracepoints-to-the-notifiers-infrastructure-checkpatch-fixes.patch
reply other threads:[~2023-03-14 20:52 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230314205158.21BCBC433EF@smtp.kernel.org \
--to=akpm@linux-foundation.org \
--cc=gpiccoli@igalia.com \
--cc=kernel@gpiccoli.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mm-commits@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).