From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3220C6FD1D for ; Mon, 20 Mar 2023 22:17:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229717AbjCTWRs (ORCPT ); Mon, 20 Mar 2023 18:17:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42162 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229865AbjCTWRp (ORCPT ); Mon, 20 Mar 2023 18:17:45 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6EA8634C20 for ; Mon, 20 Mar 2023 15:17:03 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id EB8456185F for ; Mon, 20 Mar 2023 22:17:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3E12CC433A1; Mon, 20 Mar 2023 22:17:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1679350622; bh=FE1++uOsE2yirCDU09wIqq/bVl840vdVKBjdbiT3TOI=; h=Date:To:From:Subject:From; b=YiACth6HyINsUBLUF/pnmrH4tL0gPPVw2yAb8owt4rHneD11qKm3AbMqSs96BTiE6 84oDLUcc8VdGp32lzmt82EX/02Fox3+z7WwaJAb/DBtEkkv/VYRh5zPYJF0q1Xk0PK tHnompJc9S1ZWUoUbkRBLA4o10nzI9i8r2XxGBnI= Date: Mon, 20 Mar 2023 15:17:01 -0700 To: mm-commits@vger.kernel.org, xmu@redhiat.com, viro@zeniv.linux.org.uk, soheil@google.com, jacob.e.keller@intel.com, ebiggers@kernel.org, cmaiolino@redhat.com, brauner@kernel.org, axboe@kernel.dk, pabeni@redhat.com, akpm@linux-foundation.org From: Andrew Morton Subject: [failures] epoll-use-refcount-to-reduce-ep_mutex-contention-v5.patch removed from -mm tree Message-Id: <20230320221702.3E12CC433A1@smtp.kernel.org> Precedence: bulk Reply-To: linux-kernel@vger.kernel.org List-ID: X-Mailing-List: mm-commits@vger.kernel.org The quilt patch titled Subject: epoll-use-refcount-to-reduce-ep_mutex-contention-v5 has been removed from the -mm tree. Its filename was epoll-use-refcount-to-reduce-ep_mutex-contention-v5.patch This patch was dropped because it had testing failures ------------------------------------------------------ From: Paolo Abeni Subject: epoll-use-refcount-to-reduce-ep_mutex-contention-v5 Date: Wed, 8 Mar 2023 22:51:31 +0100 update some comments Link: https://lkml.kernel.org/r/323de732635cc3513c1837c6cbb98f012174f994.1678312201.git.pabeni@redhat.com Tested-by: Xiumei Mu Reviewed-by: Jacob Keller Acked-by: Soheil Hassas Yeganeh Signed-off-by: Paolo Abeni Cc: Al Viro Cc: Carlos Maiolino Cc: Christian Brauner Cc: Eric Biggers Cc: Jens Axboe Signed-off-by: Andrew Morton --- --- a/fs/eventpoll.c~epoll-use-refcount-to-reduce-ep_mutex-contention-v5 +++ a/fs/eventpoll.c @@ -714,6 +714,8 @@ static void ep_free(struct eventpoll *ep * Removes a "struct epitem" from the eventpoll RB tree and deallocates * all the associated resources. Must be called with "mtx" held. * If the dying flag is set, do the removal only if force is true. + * This prevents ep_clear_and_put() from dropping all the ep references + * while running concurrently with eventpoll_release_file(). * Returns true if the eventpoll can be disposed. */ static bool __ep_remove(struct eventpoll *ep, struct epitem *epi, bool force) @@ -941,14 +943,13 @@ void eventpoll_release_file(struct file bool dispose; /* - * Use the 'dying' flag to prevent a concurrent ep_cleat_and_put() from + * Use the 'dying' flag to prevent a concurrent ep_clear_and_put() from * touching the epitems list before eventpoll_release_file() can access * the ep->mtx. */ again: spin_lock(&file->f_lock); if (file->f_ep && file->f_ep->first) { - /* detach from ep tree */ epi = hlist_entry(file->f_ep->first, struct epitem, fllink); epi->dying = true; spin_unlock(&file->f_lock); _ Patches currently in -mm which might be from pabeni@redhat.com are