From: akpm@linux-foundation.org
To: yang.shi@linux.alibaba.com, akpm@linux-foundation.org,
gavin.dg@linux.alibaba.com, kirill.shutemov@linux.intel.com,
mm-commits@vger.kernel.org
Subject: [to-be-updated] mm-thp-fix-potential-clearing-to-referenced-flag-in-page_idle_clear_pte_refs_one.patch removed from -mm tree
Date: Fri, 09 Feb 2018 14:02:16 -0800 [thread overview]
Message-ID: <5a7e1a68.FyUANURzdWzp/yBF%akpm@linux-foundation.org> (raw)
The patch titled
Subject: mm: thp: fix potential clearing to referenced flag in page_idle_clear_pte_refs_one()
has been removed from the -mm tree. Its filename was
mm-thp-fix-potential-clearing-to-referenced-flag-in-page_idle_clear_pte_refs_one.patch
This patch was dropped because an updated version will be merged
------------------------------------------------------
From: Yang Shi <yang.shi@linux.alibaba.com>
Subject: mm: thp: fix potential clearing to referenced flag in page_idle_clear_pte_refs_one()
For PTE-mapped THP, the compound THP has not been split to normal 4K pages
yet, the whole THP is considered referenced if any one of sub page is
referenced.
When walking PTE-mapped THP by pvmw, all relevant PTEs will be checked to
retrieve referenced bit. But, the current code just returns the result of
the last PTE. If the last PTE has not referenced, the referenced flag
will be cleared.
So, here just break pvmw walk once referenced PTE is found if the page is
a part of THP.
Link: http://lkml.kernel.org/r/1517875596-76350-1-git-send-email-yang.shi@linux.alibaba.com
Signed-off-by: Yang Shi <yang.shi@linux.alibaba.com>
Reported-by: Gang Deng <gavin.dg@linux.alibaba.com>
Reviewed-by: Andrew Morton <akpm@linux-foundation.org>
Cc: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
mm/page_idle.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff -puN mm/page_idle.c~mm-thp-fix-potential-clearing-to-referenced-flag-in-page_idle_clear_pte_refs_one mm/page_idle.c
--- a/mm/page_idle.c~mm-thp-fix-potential-clearing-to-referenced-flag-in-page_idle_clear_pte_refs_one
+++ a/mm/page_idle.c
@@ -67,6 +67,14 @@ static bool page_idle_clear_pte_refs_one
if (pvmw.pte) {
referenced = ptep_clear_young_notify(vma, addr,
pvmw.pte);
+ /*
+ * For PTE-mapped THP, one sub page is referenced,
+ * the whole THP is referenced.
+ */
+ if (referenced && PageTransCompound(pvmw.page)) {
+ page_vma_mapped_walk_done(&pvmw);
+ break;
+ }
} else if (IS_ENABLED(CONFIG_TRANSPARENT_HUGEPAGE)) {
referenced = pmdp_clear_young_notify(vma, addr,
pvmw.pmd);
_
Patches currently in -mm which might be from yang.shi@linux.alibaba.com are
reply other threads:[~2018-02-09 22:02 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5a7e1a68.FyUANURzdWzp/yBF%akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=gavin.dg@linux.alibaba.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mm-commits@vger.kernel.org \
--cc=yang.shi@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).