mm-commits.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>
To: akpm@linux-foundation.org, christophe.leroy@csgroup.eu,
	joel@joelfernandes.org, kaleshsingh@google.com,
	mm-commits@vger.kernel.org, mpe@ellerman.id.au,
	naresh.kamboju@linaro.org, npiggin@gmail.com,
	sfr@canb.auug.org.au
Subject: Re: + mm-mremap-use-range-flush-that-does-tlb-and-page-walk-cache-flush-fix.patch added to -mm tree
Date: Mon, 17 May 2021 11:27:50 +0530	[thread overview]
Message-ID: <8eedb441-a612-1ec8-8bf7-b40184de9f6f@linux.ibm.com> (raw)
In-Reply-To: <20210514220959.IXjn-Z0ga%akpm@linux-foundation.org>

On 5/15/21 3:39 AM, akpm@linux-foundation.org wrote:
> The patch titled
>       Subject: mm-mremap-use-range-flush-that-does-tlb-and-page-walk-cache-flush-fix
> has been added to the -mm tree.  Its filename is
>       mm-mremap-use-range-flush-that-does-tlb-and-page-walk-cache-flush-fix.patch
> 
> This patch should soon appear at
>      https://ozlabs.org/~akpm/mmots/broken-out/mm-mremap-use-range-flush-that-does-tlb-and-page-walk-cache-flush-fix.patch
> and later at
>      https://ozlabs.org/~akpm/mmotm/broken-out/mm-mremap-use-range-flush-that-does-tlb-and-page-walk-cache-flush-fix.patch
> 
> Before you just go and hit "reply", please:
>     a) Consider who else should be cc'ed
>     b) Prefer to cc a suitable mailing list as well
>     c) Ideally: find the original patch on the mailing list and do a
>        reply-to-all to that, adding suitable additional cc's
> 
> *** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
> 
> The -mm tree is included into linux-next and is updated
> there every 3-4 working days
> 
> ------------------------------------------------------
> From: Andrew Morton <akpm@linux-foundation.org>
> Subject: mm-mremap-use-range-flush-that-does-tlb-and-page-walk-cache-flush-fix
> 
> fix build
> 
> Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org>
> Cc: "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>
> Cc: Christophe Leroy <christophe.leroy@csgroup.eu>
> Cc: Joel Fernandes <joel@joelfernandes.org>
> Cc: Kalesh Singh <kaleshsingh@google.com>
> Cc: Michael Ellerman <mpe@ellerman.id.au>
> Cc: Nicholas Piggin <npiggin@gmail.com>
> Cc: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> ---
> 
>   mm/mremap.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- a/mm/mremap.c~mm-mremap-use-range-flush-that-does-tlb-and-page-walk-cache-flush-fix
> +++ a/mm/mremap.c
> @@ -216,7 +216,7 @@ static inline void flush_pte_tlb_pwc_ran
>   					   unsigned long start,
>   					   unsigned long end)
>   {
> -	return flush_tlb_range(vma, start, end);
> +	flush_tlb_range(vma, start, end);
>   }
>   #endif
>   
> _


Thanks for catching this. This is required because on some 
architectures, flush_tlb_range have non void returns. For example on 
parisc we have

int __flush_tlb_range(unsigned long sid,
	unsigned long start, unsigned long end);

#define flush_tlb_range(vma, start, end) \
	__flush_tlb_range((vma)->vm_mm->context, start, end)



-aneesh

  reply	other threads:[~2021-05-17  5:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-14 22:09 akpm
2021-05-17  5:57 ` Aneesh Kumar K.V [this message]
2021-05-17 22:41 ` Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8eedb441-a612-1ec8-8bf7-b40184de9f6f@linux.ibm.com \
    --to=aneesh.kumar@linux.ibm.com \
    --cc=akpm@linux-foundation.org \
    --cc=christophe.leroy@csgroup.eu \
    --cc=joel@joelfernandes.org \
    --cc=kaleshsingh@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mm-commits@vger.kernel.org \
    --cc=mpe@ellerman.id.au \
    --cc=naresh.kamboju@linaro.org \
    --cc=npiggin@gmail.com \
    --cc=sfr@canb.auug.org.au \
    --subject='Re: + mm-mremap-use-range-flush-that-does-tlb-and-page-walk-cache-flush-fix.patch added to -mm tree' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).