From: Linus Torvalds <torvalds@linux-foundation.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Linux-MM <linux-mm@kvack.org>, mm-commits@vger.kernel.org
Subject: Re: incoming
Date: Tue, 15 Dec 2020 14:48:13 -0800
Message-ID: <CAHk-=wi2-u8+m2k=dt-=L8sjHC=nR-Z7Db9igZDCjnkis1G9gA@mail.gmail.com> (raw)
In-Reply-To: <20201215123253.954eca9a5ef4c0d52fd381fa@linux-foundation.org>
On Tue, Dec 15, 2020 at 12:32 PM Andrew Morton
<akpm@linux-foundation.org> wrote:
>
> - more MM work: a memcg scalability improvememt
>
> 19 patches, based on 148842c98a24e508aecb929718818fbf4c2a6ff3.
With your re-send, I get all patches, but they don't actually apply cleanly.
Is that base correct?
I get
error: patch failed: mm/huge_memory.c:2750
error: mm/huge_memory.c: patch does not apply
Patch failed at 0004 mm/thp: narrow lru locking
for that patch "[patch 04/19] mm/thp: narrow lru locking", and that's
definitely true: the patch fragment has
@@ -2750,7 +2751,7 @@ int split_huge_page_to_list(struct page
__dec_lruvec_page_state(head, NR_FILE_THPS);
}
- __split_huge_page(page, list, end, flags);
+ __split_huge_page(page, list, end);
ret = 0;
} else {
if (IS_ENABLED(CONFIG_DEBUG_VM) && mapcount) {
but that __dec_lruvec_page_state() conversion was done by your
previous commit series.
So I have the feeling that what you actually mean by "base" isn't
actually really the base for that series at all..
I will try to apply it on top of my merge of your previous series instead.
Linus
next prev parent reply index
Thread overview: 196+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-15 20:32 incoming Andrew Morton
2020-12-15 20:33 ` [patch 01/19] mm/thp: move lru_add_page_tail() to huge_memory.c Andrew Morton
2020-12-15 20:33 ` [patch 02/19] mm/thp: use head for head page in lru_add_page_tail() Andrew Morton
2020-12-15 20:33 ` [patch 03/19] mm/thp: simplify lru_add_page_tail() Andrew Morton
2020-12-15 20:33 ` [patch 04/19] mm/thp: narrow lru locking Andrew Morton
2020-12-15 20:33 ` [patch 05/19] mm/vmscan: remove unnecessary lruvec adding Andrew Morton
2020-12-15 20:33 ` [patch 06/19] mm/rmap: stop store reordering issue on page->mapping Andrew Morton
2020-12-15 20:33 ` [patch 07/19] mm: page_idle_get_page() does not need lru_lock Andrew Morton
2020-12-15 20:33 ` [patch 08/19] mm/memcg: add debug checking in lock_page_memcg Andrew Morton
2020-12-15 20:33 ` [patch 09/19] mm/swap.c: fold vm event PGROTATED into pagevec_move_tail_fn Andrew Morton
2020-12-15 20:34 ` [patch 11/19] mm/vmscan: remove lruvec reget in move_pages_to_lru Andrew Morton
2020-12-15 20:34 ` [patch 12/19] mm/mlock: remove lru_lock on TestClearPageMlocked Andrew Morton
2020-12-15 20:34 ` [patch 13/19] mm/mlock: remove __munlock_isolate_lru_page() Andrew Morton
2020-12-15 20:34 ` [patch 14/19] mm/lru: introduce TestClearPageLRU() Andrew Morton
2020-12-15 20:34 ` [patch 15/19] mm/compaction: do page isolation first in compaction Andrew Morton
2020-12-15 20:34 ` [patch 16/19] mm/swap.c: serialize memcg changes in pagevec_lru_move_fn Andrew Morton
2020-12-15 20:34 ` [patch 17/19] mm/lru: replace pgdat lru_lock with lruvec lock Andrew Morton
2020-12-15 20:34 ` [patch 18/19] mm/lru: introduce relock_page_lruvec() Andrew Morton
2020-12-15 20:34 ` [patch 19/19] mm/lru: revise the comments of lru_lock Andrew Morton
2020-12-15 21:00 ` incoming Linus Torvalds
2020-12-15 22:20 ` [patch 01/19] mm/thp: move lru_add_page_tail() to huge_memory.c Andrew Morton
2020-12-15 22:20 ` [patch 02/19] mm/thp: use head for head page in lru_add_page_tail() Andrew Morton
2020-12-15 22:20 ` [patch 03/19] mm/thp: simplify lru_add_page_tail() Andrew Morton
2020-12-15 22:20 ` [patch 04/19] mm/thp: narrow lru locking Andrew Morton
2020-12-15 22:20 ` [patch 05/19] mm/vmscan: remove unnecessary lruvec adding Andrew Morton
2020-12-15 22:20 ` [patch 06/19] mm/rmap: stop store reordering issue on page->mapping Andrew Morton
2020-12-15 22:20 ` [patch 07/19] mm: page_idle_get_page() does not need lru_lock Andrew Morton
2020-12-15 22:20 ` [patch 08/19] mm/memcg: add debug checking in lock_page_memcg Andrew Morton
2020-12-15 22:20 ` [patch 09/19] mm/swap.c: fold vm event PGROTATED into pagevec_move_tail_fn Andrew Morton
2020-12-15 22:20 ` [patch 10/19] mm/lru: move lock into lru_note_cost Andrew Morton
2020-12-15 22:20 ` [patch 11/19] mm/vmscan: remove lruvec reget in move_pages_to_lru Andrew Morton
2020-12-15 22:20 ` [patch 12/19] mm/mlock: remove lru_lock on TestClearPageMlocked Andrew Morton
2020-12-15 22:21 ` [patch 13/19] mm/mlock: remove __munlock_isolate_lru_page() Andrew Morton
2020-12-15 22:21 ` [patch 14/19] mm/lru: introduce TestClearPageLRU() Andrew Morton
2020-12-15 22:21 ` [patch 15/19] mm/compaction: do page isolation first in compaction Andrew Morton
2020-12-15 22:21 ` [patch 16/19] mm/swap.c: serialize memcg changes in pagevec_lru_move_fn Andrew Morton
2020-12-15 22:21 ` [patch 17/19] mm/lru: replace pgdat lru_lock with lruvec lock Andrew Morton
2020-12-15 22:21 ` [patch 18/19] mm/lru: introduce relock_page_lruvec() Andrew Morton
2020-12-15 22:21 ` [patch 19/19] mm/lru: revise the comments of lru_lock Andrew Morton
2020-12-15 22:48 ` Linus Torvalds [this message]
2020-12-15 22:49 ` incoming Linus Torvalds
2020-12-15 22:55 ` incoming Andrew Morton
-- strict thread matches above, loose matches on Subject: below --
2021-02-26 1:14 incoming Andrew Morton
2021-02-26 17:55 ` incoming Linus Torvalds
2021-02-26 19:16 ` incoming Andrew Morton
2021-02-24 19:58 incoming Andrew Morton
2021-02-24 21:30 ` incoming Linus Torvalds
2021-02-24 21:37 ` incoming Linus Torvalds
2021-02-25 8:53 ` incoming Arnd Bergmann
2021-02-25 9:12 ` incoming Andrey Ryabinin
2021-02-25 11:07 ` incoming Walter Wu
2021-02-13 4:52 incoming Andrew Morton
2021-02-09 21:41 incoming Andrew Morton
2021-02-10 19:30 ` incoming Linus Torvalds
2021-02-05 2:31 incoming Andrew Morton
2021-01-24 5:00 incoming Andrew Morton
2021-01-12 23:48 incoming Andrew Morton
2021-01-15 23:32 ` incoming Linus Torvalds
2020-12-29 23:13 incoming Andrew Morton
2020-12-22 19:58 incoming Andrew Morton
2020-12-22 21:43 ` incoming Linus Torvalds
2020-12-18 22:00 incoming Andrew Morton
2020-12-16 4:41 incoming Andrew Morton
2020-12-15 3:02 incoming Andrew Morton
2020-12-15 3:25 ` incoming Linus Torvalds
2020-12-15 3:30 ` incoming Linus Torvalds
2020-12-15 14:04 ` incoming Konstantin Ryabitsev
2020-12-11 21:35 incoming Andrew Morton
2020-12-06 6:14 incoming Andrew Morton
2020-11-22 6:16 incoming Andrew Morton
2020-11-14 6:51 incoming Andrew Morton
2020-11-02 1:06 incoming Andrew Morton
2020-10-17 23:13 incoming Andrew Morton
2020-10-16 2:40 incoming Andrew Morton
2020-10-16 3:03 ` incoming Andrew Morton
2020-10-13 23:46 incoming Andrew Morton
2020-10-11 6:15 incoming Andrew Morton
2020-10-03 5:20 incoming Andrew Morton
2020-09-26 4:17 incoming Andrew Morton
2020-09-19 4:19 incoming Andrew Morton
2020-09-04 23:34 incoming Andrew Morton
2020-08-21 0:41 incoming Andrew Morton
2020-08-15 0:29 incoming Andrew Morton
2020-08-12 1:29 incoming Andrew Morton
2020-08-07 6:16 incoming Andrew Morton
2020-07-24 4:14 incoming Andrew Morton
2020-07-03 22:14 incoming Andrew Morton
2020-06-26 3:28 incoming Andrew Morton
2020-06-12 0:30 incoming Andrew Morton
2020-06-11 1:40 incoming Andrew Morton
2020-06-09 4:29 incoming Andrew Morton
2020-06-08 4:35 incoming Andrew Morton
2020-06-04 23:45 incoming Andrew Morton
2020-06-03 22:55 incoming Andrew Morton
2020-06-02 20:09 incoming Andrew Morton
2020-06-02 4:44 incoming Andrew Morton
2020-06-02 20:08 ` incoming Andrew Morton
[not found] ` <CAHk-=wgRV=SaiMn3L5u5mG0WfvB2VfEQadtudzDV3KRz5HnFrQ@mail.gmail.com>
2020-06-02 21:38 ` incoming Andrew Morton
2020-05-28 5:20 incoming Andrew Morton
[not found] ` <CAHk-=whQSWcE1WvKxptHdyc9BUXQyxxyAH954=Jb_YSBrNJYDQ@mail.gmail.com>
2020-05-29 20:31 ` incoming Andrew Morton
[not found] ` <CAHk-=wiU-vQVURz62dzitbh2Pk+m_+ipaJU6=z=ES3cd_wKSLQ@mail.gmail.com>
2020-05-29 21:12 ` incoming Andrew Morton
2020-05-14 0:50 incoming Andrew Morton
2020-05-08 1:35 incoming Andrew Morton
2020-04-21 1:13 incoming Andrew Morton
2020-04-12 7:41 incoming Andrew Morton
2020-04-10 21:30 incoming Andrew Morton
2020-04-07 3:02 incoming Andrew Morton
2020-04-02 4:01 incoming Andrew Morton
2020-03-29 2:14 incoming Andrew Morton
2020-03-22 1:19 incoming Andrew Morton
2020-03-06 6:27 incoming Andrew Morton
2020-02-21 4:00 incoming Andrew Morton
2020-02-21 4:03 ` incoming Andrew Morton
2020-02-04 1:33 incoming Andrew Morton
[not found] ` <CAHk-=whog86e4fRY_sxHqAos6spwAi_4aFF49S7h5C4XAZM2qw@mail.gmail.com>
2020-02-04 2:46 ` incoming Andrew Morton
2020-01-31 6:10 incoming Andrew Morton
2020-01-14 0:28 incoming Andrew Morton
2018-02-06 23:34 incoming Andrew Morton
2018-02-01 0:13 incoming Andrew Morton
2018-02-01 0:25 ` incoming Andrew Morton
2018-01-19 0:33 incoming Andrew Morton
2018-01-13 0:52 incoming Andrew Morton
2018-01-05 0:17 incoming Andrew Morton
2017-12-14 23:32 incoming Andrew Morton
2017-11-30 0:09 incoming Andrew Morton
2017-11-17 23:25 incoming Andrew Morton
2017-11-16 1:29 incoming Andrew Morton
2017-11-09 21:38 incoming Andrew Morton
2017-11-02 22:59 incoming Andrew Morton
2017-10-13 22:57 incoming Andrew Morton
2017-10-03 23:14 incoming Andrew Morton
2017-09-13 23:28 incoming Andrew Morton
2017-09-08 23:10 incoming Andrew Morton
[not found] ` <CA+55aFwRXB5_kSuN7o+tqN6Eft6w5oZuLG3B8Rns=0ZZa2ihgA@mail.gmail.com>
[not found] ` <CA+55aFw+z3HDT4s1C41j=d5_0QTSu8NLSSpnk_jxZ39w34xgnA@mail.gmail.com>
2017-09-09 18:09 ` incoming Andrew Morton
2017-09-06 23:17 incoming Andrew Morton
2017-08-31 23:15 incoming Andrew Morton
2017-08-25 22:55 incoming Andrew Morton
2017-08-18 22:15 incoming Andrew Morton
2017-08-10 22:23 incoming Andrew Morton
2017-08-02 20:31 incoming Andrew Morton
2017-07-14 21:46 incoming Andrew Morton
2017-07-12 21:32 incoming Andrew Morton
2017-07-10 22:46 incoming Andrew Morton
2017-07-06 22:34 incoming Andrew Morton
2017-06-23 22:08 incoming Andrew Morton
2017-06-16 21:02 incoming Andrew Morton
2017-06-02 21:45 incoming Andrew Morton
2017-05-12 22:45 incoming Andrew Morton
2017-05-08 22:53 incoming Andrew Morton
2017-05-03 21:50 incoming Andrew Morton
2017-04-20 21:37 incoming Andrew Morton
2017-04-13 21:56 incoming Andrew Morton
2017-04-07 23:04 incoming Andrew Morton
2017-03-31 22:11 incoming Andrew Morton
2017-03-16 23:40 incoming Andrew Morton
2017-03-10 0:15 incoming Andrew Morton
2017-02-27 22:25 incoming Andrew Morton
2017-02-24 22:55 incoming Andrew Morton
2017-02-22 23:38 incoming Andrew Morton
2017-02-18 11:42 incoming Andrew Morton
2017-02-08 22:30 incoming Andrew Morton
2017-01-24 23:17 incoming Andrew Morton
2017-01-11 0:57 incoming Andrew Morton
2016-12-20 0:22 incoming Andrew Morton
2016-12-14 23:04 incoming Andrew Morton
2016-12-13 0:40 incoming Andrew Morton
2016-12-07 22:44 incoming Andrew Morton
2016-12-03 1:26 incoming Andrew Morton
2016-11-30 23:53 incoming Andrew Morton
2016-11-10 18:45 incoming Andrew Morton
2016-10-11 20:49 incoming Andrew Morton
2016-10-07 23:53 incoming Andrew Morton
2016-09-30 22:11 incoming Andrew Morton
2016-09-28 22:22 incoming Andrew Morton
2016-09-19 21:43 incoming Andrew Morton
2016-09-01 23:14 incoming Andrew Morton
2016-08-25 22:16 incoming Andrew Morton
2016-08-11 22:32 incoming Andrew Morton
2016-08-04 22:31 incoming Andrew Morton
2016-08-03 20:45 incoming Andrew Morton
2016-08-02 21:01 incoming Andrew Morton
2016-07-28 22:42 incoming Andrew Morton
2016-07-26 22:16 incoming Andrew Morton
2016-07-20 22:44 incoming Andrew Morton
2016-07-14 19:06 incoming Andrew Morton
2016-06-24 21:48 incoming Andrew Morton
2016-06-08 22:33 incoming Andrew Morton
2016-06-03 21:51 incoming Andrew Morton
2016-05-27 21:26 incoming Andrew Morton
2016-05-26 22:15 incoming Andrew Morton
2016-05-23 23:21 incoming Andrew Morton
2016-05-20 23:55 incoming Andrew Morton
2016-05-20 0:07 incoming Andrew Morton
2016-05-12 22:41 incoming Andrew Morton
2016-05-09 23:28 incoming Andrew Morton
2016-05-05 23:21 incoming Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHk-=wi2-u8+m2k=dt-=L8sjHC=nR-Z7Db9igZDCjnkis1G9gA@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mm-commits@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
mm-commits Archive on lore.kernel.org
Archives are clonable:
git clone --mirror https://lore.kernel.org/mm-commits/0 mm-commits/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 mm-commits mm-commits/ https://lore.kernel.org/mm-commits \
mm-commits@vger.kernel.org
public-inbox-index mm-commits
Example config snippet for mirrors
Newsgroup available over NNTP:
nntp://nntp.lore.kernel.org/org.kernel.vger.mm-commits
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git