Re: + checkpatch-add-missing-bindings-license-check.patch added to mm-nonmm-unstable branch

[Rob Herring <robh@kernel.org>]

On Tue, Mar 21, 2023 at 4:29 PM Andrew Morton <akpm@linux-foundation.org> wrote:
>
>
> The patch titled
>      Subject: checkpatch: add missing bindings license check
> has been added to the -mm mm-nonmm-unstable branch.  Its filename is
>      checkpatch-add-missing-bindings-license-check.patch
>
> This patch will shortly appear at
>      https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/checkpatch-add-missing-bindings-license-check.patch
>
> This patch will later appear in the mm-nonmm-unstable branch at
>     git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
>
> Before you just go and hit "reply", please:
>    a) Consider who else should be cc'ed
>    b) Prefer to cc a suitable mailing list as well
>    c) Ideally: find the original patch on the mailing list and do a
>       reply-to-all to that, adding suitable additional cc's
>
> *** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
>
> The -mm tree is included into linux-next via the mm-everything
> branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
> and is updated there every 2-3 working days
>
> ------------------------------------------------------
> From: Dmitry Rokosov <ddrokosov@sberdevices.ru>
> Subject: checkpatch: add missing bindings license check
> Date: Mon, 20 Mar 2023 23:33:50 +0300
>
> All headers from 'include/dt-bindings/' must be verified by checkpatch
> together with Documentation bindings, because all of them are part of the
> whole DT bindings system.
>
> The requirement is dual licensed and matching pattern:
>     /GPL-2\.0(?:-only|-or-later|\+)? (?:OR|or) BSD-2-Clause/
>
> The issue was found during patch review:
> https://lore.kernel.org/all/20230313201259.19998-4-ddrokosov@sberdevices.ru/
>
> Link: https://lkml.kernel.org/r/20230320203350.13696-1-ddrokosov@sberdevices.ru

Not a correct link.

> Signed-off-by: Dmitry Rokosov <ddrokosov@sberdevices.ru>
> Acked-by: Joe Perches <joe@perches.com>
> Cc: Andy Whitcroft <apw@canonical.com>
> Cc: Dwaipayan Ray <dwaipayanray1@gmail.com>
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Cc: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> Cc: Rob Herring <robh@kernel.org>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> ---
>
>  scripts/checkpatch.pl |    5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> --- a/scripts/checkpatch.pl~checkpatch-add-missing-bindings-license-check
> +++ a/scripts/checkpatch.pl
> @@ -3735,8 +3735,9 @@ sub process {
>                                                 WARN("SPDX_LICENSE_TAG",
>                                                      "'$spdx_license' is not supported in LICENSES/...\n" . $herecurr);
>                                         }
> -                                       if ($realfile =~ m@^Documentation/devicetree/bindings/@ &&
> -                                           not $spdx_license =~ /GPL-2\.0.*BSD-2-Clause/) {
> +                                       if (($realfile =~ m@^Documentation/devicetree/bindings/@ ||
> +                                            $realfile =~ m@^include/dt-bindings/@) &&
> +                                           $spdx_license !~ /GPL-2\.0(?:-only|-or-later|\+)? (?:OR|or) BSD-2-Clause/) {
>                                                 my $msg_level = \&WARN;
>                                                 $msg_level = \&CHK if ($file);
>                                                 if (&{$msg_level}("SPDX_LICENSE_TAG",
> _
>
> Patches currently in -mm which might be from ddrokosov@sberdevices.ru are
>
> checkpatch-add-missing-bindings-license-check.patch
>