From: Heiko Carstens <email@example.com> To: Linus Torvalds <firstname.lastname@example.org> Cc: Andrew Morton <email@example.com>, Christian Borntraeger <firstname.lastname@example.org>, Vasily Gorbik <email@example.com>, Amir Goldstein <firstname.lastname@example.org>, Chris Down <email@example.com>, Hugh Dickins <firstname.lastname@example.org>, Ivan Kokshaysky <email@example.com>, Linux-MM <firstname.lastname@example.org>, Matt Turner <email@example.com>, firstname.lastname@example.org, Richard Henderson <email@example.com>, Seth Forshee <firstname.lastname@example.org>, stable <email@example.com>, Arnd Bergmann <firstname.lastname@example.org>, Ulrich Weigand <Ulrich.Weigand@de.ibm.com>, Tuan Hoang1 <Tuan.Hoang1@ibm.com> Subject: Re: [patch 09/14] tmpfs: disallow CONFIG_TMPFS_INODE64 on alpha Date: Thu, 11 Feb 2021 19:45:22 +0100 Message-ID: <YCV7QiyoweJwvN+m@osiris> (raw) In-Reply-To: <CAHk-=wghVA-6aNQz3rwr5VHmJAHkUvGyzKFpsEN1HPB5SL+aQA@mail.gmail.com> On Wed, Feb 10, 2021 at 11:17:10AM -0800, Linus Torvalds wrote: > On Wed, Feb 10, 2021 at 5:39 AM Heiko Carstens <email@example.com> wrote: > > > > I couldn't spot any and also gave the patch below a try and my system > > still boots without any errors. > > So, as far as I can tell it _should_ be ok to change this. > > So your patch (with the fix on top) looks sane to me. > > I'm not entirely sure it is worth it, but the fact that we've had bugs > wrt this before does seem to imply that we should do this. > > I'd remove the __kernel_ino_t type entirely, but I wonder if user > space might depend on it. I do find > > #ifndef __kernel_ino_t > typedef __kernel_ulong_t __kernel_ino_t; > #endif > > in the GNU libc headers I have, but then I don't find any actual use > of that, so it looks like it may be jyst a "we copied things for other > reasons". > > On the whole I think this would be the right thing to do, but I'm a > bit worried that it's more pain that it might be worth. > > Heiko, I think I'll leave this decision entirely to you. If you think > it's worth it to avoid any possible future pain wrt this odd inode > number thing for s390, just add it to the s390 tree with my ack. > Because honestly, I think s390 is the only architecture that really > cares by now. So, yes. We will go to change this to hopefully avoid future problems. The patch is supposed to be part of the next merge window and converts both s390 and alpha, unless somebody objects. After that has been merged I'll provide a follow-on patch which enables TMPFS_INODE64 for alpha and s390 again, and yet another one which removes __kernel_ino_t as suggested by you.
next prev parent reply index Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-02-09 21:41 incoming Andrew Morton 2021-02-09 21:41 ` [patch 01/14] squashfs: avoid out of bounds writes in decompressors Andrew Morton 2021-02-09 21:41 ` [patch 02/14] squashfs: add more sanity checks in id lookup Andrew Morton 2021-02-09 21:41 ` [patch 03/14] squashfs: add more sanity checks in inode lookup Andrew Morton 2021-02-09 21:42 ` [patch 04/14] squashfs: add more sanity checks in xattr id lookup Andrew Morton 2021-02-09 21:42 ` [patch 05/14] kasan: fix stack traces dependency for HW_TAGS Andrew Morton 2021-02-09 21:42 ` [patch 06/14] firmware_loader: align .builtin_fw to 8 Andrew Morton 2021-02-09 21:42 ` [patch 07/14] mm/mremap: fix BUILD_BUG_ON() error in get_extent Andrew Morton 2021-02-09 21:42 ` [patch 08/14] tmpfs: disallow CONFIG_TMPFS_INODE64 on s390 Andrew Morton 2021-02-09 21:42 ` [patch 09/14] tmpfs: disallow CONFIG_TMPFS_INODE64 on alpha Andrew Morton 2021-02-09 22:03 ` Linus Torvalds 2021-02-10 13:34 ` Heiko Carstens 2021-02-10 17:27 ` Heiko Carstens 2021-02-10 19:17 ` Linus Torvalds 2021-02-10 19:55 ` Arnd Bergmann 2021-02-11 18:45 ` Heiko Carstens [this message] 2021-02-09 21:42 ` [patch 10/14] selftests/vm: rename file run_vmtests to run_vmtests.sh Andrew Morton 2021-02-09 21:42 ` [patch 11/14] MAINTAINERS: update Andrey Ryabinin's email address Andrew Morton 2021-02-09 21:42 ` [patch 12/14] Revert "mm: memcontrol: avoid workload stalls when lowering memory.high" Andrew Morton 2021-02-09 21:42 ` [patch 13/14] mm, slub: better heuristic for number of cpus when calculating slab order Andrew Morton 2021-02-10 14:34 ` Vlastimil Babka 2021-02-10 19:22 ` Linus Torvalds 2021-02-09 21:42 ` [patch 14/14] nilfs2: make splice write available again Andrew Morton 2021-02-10 19:30 ` incoming Linus Torvalds
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YCV7QiyoweJwvN+m@osiris \ --firstname.lastname@example.org \ --cc=Tuan.Hoang1@ibm.com \ --cc=Ulrich.Weigand@de.ibm.com \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
mm-commits Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/mm-commits/0 mm-commits/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 mm-commits mm-commits/ https://lore.kernel.org/mm-commits \ email@example.com public-inbox-index mm-commits Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.mm-commits AGPL code for this site: git clone https://public-inbox.org/public-inbox.git