From: Petr Mladek <pmladek@suse.com>
To: Peter Zijlstra <peterz@infradead.org>, akpm@linux-foundation.org
Cc: loberman@redhat.com, mhocko@suse.com, mingo@kernel.org,
mm-commits@vger.kernel.org, tglx@linutronix.de,
vincent.whitchurch@axis.com
Subject: [PATCH] watchdog: Use bit lock operations to prevent multiple soft-lockup reports
Date: Fri, 19 Mar 2021 13:14:40 +0100 [thread overview]
Message-ID: <YFSVsLGVWMXTvlbk@alley> (raw)
In-Reply-To: <YFHIc+Q42bKcuWFY@alley>
Use bit_lock operation to prevent multiple soft-lockups reports when
one CPU already triggered dumping backtraces from all CPUs.
It allows to remove the explicit memory barriers and misleading
comments.
Suggested-by: Peter Zijlstra <peterz@infradead.org>
Signed-off-by: Petr Mladek <pmladek@suse.com>
---
Andrew,
this patch can be put on top of the patchset fixing/cleaning softlockup
watchdog code. Feel free to squash it into the other patch fixing
the barriers.
Or should I resend the entire patchset again, please?
Best Regards,
Petr
kernel/watchdog.c | 15 ++-------------
1 file changed, 2 insertions(+), 13 deletions(-)
diff --git a/kernel/watchdog.c b/kernel/watchdog.c
index c050323fcd33..090b6bc4de79 100644
--- a/kernel/watchdog.c
+++ b/kernel/watchdog.c
@@ -410,13 +410,8 @@ static enum hrtimer_restart watchdog_timer_fn(struct hrtimer *hrtimer)
* engaged in dumping all cpu back traces.
*/
if (softlockup_all_cpu_backtrace) {
- if (test_and_set_bit(0, &soft_lockup_nmi_warn))
+ if (test_and_set_bit_lock(0, &soft_lockup_nmi_warn))
return HRTIMER_RESTART;
- /*
- * Make sure that reports are serialized. Start
- * printing after getting the exclusive rights.
- */
- smp_mb__after_atomic();
}
/* Start period for the next softlockup warning. */
@@ -434,13 +429,7 @@ static enum hrtimer_restart watchdog_timer_fn(struct hrtimer *hrtimer)
if (softlockup_all_cpu_backtrace) {
trigger_allbutself_cpu_backtrace();
- /*
- * Make sure that everything is printed before
- * another CPU is allowed to report lockup again.
- */
- smp_mb__before_atomic();
- /* Allow a further report. */
- clear_bit(0, &soft_lockup_nmi_warn);
+ clear_bit_unlock(0, &soft_lockup_nmi_warn);
}
add_taint(TAINT_SOFTLOCKUP, LOCKDEP_STILL_OK);
--
2.26.2
next prev parent reply other threads:[~2021-03-19 12:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-11 21:22 + watchdog-fix-barriers-when-printing-backtraces-from-all-cpus.patch added to -mm tree akpm
2021-03-16 11:48 ` Peter Zijlstra
2021-03-17 9:14 ` Petr Mladek
2021-03-19 12:14 ` Petr Mladek [this message]
2021-03-19 12:29 ` [PATCH] watchdog: Use bit lock operations to prevent multiple soft-lockup reports Peter Zijlstra
2021-03-20 16:32 ` Andrew Morton
2021-03-22 13:41 ` Petr Mladek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YFSVsLGVWMXTvlbk@alley \
--to=pmladek@suse.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loberman@redhat.com \
--cc=mhocko@suse.com \
--cc=mingo@kernel.org \
--cc=mm-commits@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=vincent.whitchurch@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).