From: patchwork-bot+netdevbpf@kernel.org
To: Mat Martineau <mathew.j.martineau@linux.intel.com>
Cc: netdev@vger.kernel.org, matthieu.baerts@tessares.net,
davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
mptcp@lists.linux.dev, dan.carpenter@oracle.com
Subject: Re: [PATCH net-next] mptcp: fix 'masking a bool' warning
Date: Mon, 28 Jun 2021 20:10:05 +0000 [thread overview]
Message-ID: <162491100528.2562.743940781000501523.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20210625212522.264000-1-mathew.j.martineau@linux.intel.com>
Hello:
This patch was applied to netdev/net-next.git (refs/heads/master):
On Fri, 25 Jun 2021 14:25:22 -0700 you wrote:
> From: Matthieu Baerts <matthieu.baerts@tessares.net>
>
> Dan Carpenter reported an issue introduced in
> commit fde56eea01f9 ("mptcp: refine mptcp_cleanup_rbuf") where a new
> boolean (ack_pending) is masked with 0x9.
>
> This is not the intention to ignore values by using a boolean. This
> variable should not have a 'bool' type: we should keep the 'u8' to allow
> this comparison.
>
> [...]
Here is the summary with links:
- [net-next] mptcp: fix 'masking a bool' warning
https://git.kernel.org/netdev/net-next/c/c4512c63b119
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2021-06-28 20:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-25 21:25 [PATCH net-next] mptcp: fix 'masking a bool' warning Mat Martineau
2021-06-28 8:22 ` Paolo Abeni
2021-06-28 20:10 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=162491100528.2562.743940781000501523.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=dan.carpenter@oracle.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=mathew.j.martineau@linux.intel.com \
--cc=matthieu.baerts@tessares.net \
--cc=mptcp@lists.linux.dev \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).