From: Matthieu Baerts <matthieu.baerts@tessares.net>
To: menglong8.dong@gmail.com, mathew.j.martineau@linux.intel.com
Cc: mptcp@lists.linux.dev, Menglong Dong <imagedong@tencent.com>
Subject: Re: [PATCH mptcp-next v2 2/2] mptcp: add statistics for mptcp socket in use
Date: Wed, 21 Sep 2022 14:42:32 +0200 [thread overview]
Message-ID: <1f5efd69-3507-1086-1499-c2014c75c673@tessares.net> (raw)
In-Reply-To: <20220921120442.320727-3-imagedong@tencent.com>
Hi Menglong,
On 21/09/2022 14:04, menglong8.dong@gmail.com wrote:
> From: Menglong Dong <imagedong@tencent.com>
>
> Do the statistics of mptcp socket in use with sock_prot_inuse_add().
> Therefore, we can get the count of used mptcp socket from
> /proc/net/protocols:
(...)
> diff --git a/net/mptcp/protocol.h b/net/mptcp/protocol.h
> index c0b5b4628f65..675de024de10 100644
> --- a/net/mptcp/protocol.h
> +++ b/net/mptcp/protocol.h
> @@ -116,6 +116,7 @@
> #define MPTCP_WORK_EOF 3
> #define MPTCP_FALLBACK_DONE 4
> #define MPTCP_WORK_CLOSE_SUBFLOW 5
> +#define MPTCP_DESTROIED 6
I'm only reacting here about the name (I didn't check the rest in
details) but do you mind using MPTCP_DESTROYED with a Y instead of I please
When it is written using capital letters, it is better to avoid such
typos :)
Cheers,
Matt
--
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net
next prev parent reply other threads:[~2022-09-21 12:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-21 12:04 [PATCH mptcp-next v2 0/2] mptcp: add statistics for mptcp socket in use menglong8.dong
2022-09-21 12:04 ` [PATCH mptcp-next v2 1/2] mptcp: introduce 'sk' to replace 'sock->sk' in mptcp_listen() menglong8.dong
2022-09-21 12:04 ` [PATCH mptcp-next v2 2/2] mptcp: add statistics for mptcp socket in use menglong8.dong
2022-09-21 12:42 ` Matthieu Baerts [this message]
2022-09-21 12:52 ` Menglong Dong
2022-09-21 13:37 ` mptcp: add statistics for mptcp socket in use: Tests Results MPTCP CI
2022-09-22 0:03 ` [PATCH mptcp-next v2 0/2] mptcp: add statistics for mptcp socket in use Mat Martineau
2022-09-22 3:48 ` Menglong Dong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1f5efd69-3507-1086-1499-c2014c75c673@tessares.net \
--to=matthieu.baerts@tessares.net \
--cc=imagedong@tencent.com \
--cc=mathew.j.martineau@linux.intel.com \
--cc=menglong8.dong@gmail.com \
--cc=mptcp@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).