From: Florian Westphal <fw@strlen.de>
To: <mptcp@lists.linux.dev>
Cc: Florian Westphal <fw@strlen.de>
Subject: [PATCH v2 mptcp-next 1/8] mptcp: enable busypoll from mptcp receive path
Date: Tue, 11 May 2021 15:36:52 +0200 [thread overview]
Message-ID: <20210511133659.29982-2-fw@strlen.de> (raw)
In-Reply-To: <20210511133659.29982-1-fw@strlen.de>
The setting is only relevant for the msk socket.
While at it, also handle rcvlowat/rcvtimeo this way.
Signed-off-by: Florian Westphal <fw@strlen.de>
---
net/mptcp/protocol.c | 7 +++++++
net/mptcp/sockopt.c | 8 ++++++++
2 files changed, 15 insertions(+)
diff --git a/net/mptcp/protocol.c b/net/mptcp/protocol.c
index 652e55a0c6e8..86e599eb4403 100644
--- a/net/mptcp/protocol.c
+++ b/net/mptcp/protocol.c
@@ -12,6 +12,7 @@
#include <linux/sched/signal.h>
#include <linux/atomic.h>
#include <net/sock.h>
+#include <net/busy_poll.h>
#include <net/inet_common.h>
#include <net/inet_hashtables.h>
#include <net/protocol.h>
@@ -1982,6 +1983,12 @@ static int mptcp_recvmsg(struct sock *sk, struct msghdr *msg, size_t len,
if (unlikely(flags & MSG_ERRQUEUE))
return inet_recv_error(sk, msg, len, addr_len);
+ if (sk_can_busy_loop(sk) &&
+ skb_queue_empty_lockless(&msk->receive_queue) &&
+ skb_queue_empty_lockless(&sk->sk_receive_queue) &&
+ inet_sk_state_load(sk) == TCP_ESTABLISHED)
+ sk_busy_loop(sk, nonblock);
+
mptcp_lock_sock(sk, __mptcp_splice_receive_queue(sk));
if (unlikely(sk->sk_state == TCP_LISTEN)) {
copied = -ENOTCONN;
diff --git a/net/mptcp/sockopt.c b/net/mptcp/sockopt.c
index a79798189599..ee55e4145d7e 100644
--- a/net/mptcp/sockopt.c
+++ b/net/mptcp/sockopt.c
@@ -254,6 +254,14 @@ static int mptcp_setsockopt_sol_socket(struct mptcp_sock *msk, int optname,
return mptcp_setsockopt_sol_socket_int(msk, optname, optval, optlen);
case SO_LINGER:
return mptcp_setsockopt_sol_socket_linger(msk, optval, optlen);
+ case SO_RCVLOWAT:
+ case SO_RCVTIMEO_OLD:
+ case SO_RCVTIMEO_NEW:
+ case SO_BUSY_POLL:
+ case SO_PREFER_BUSY_POLL:
+ case SO_BUSY_POLL_BUDGET:
+ /* No need to copy: only relevant for msk */
+ break;
case SO_NO_CHECK:
case SO_DONTROUTE:
case SO_BROADCAST:
--
2.26.3
next prev parent reply other threads:[~2021-05-11 13:37 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-11 13:36 [PATCH v2 mptcp-next 0/8] add cmsg support to receive path Florian Westphal
2021-05-11 13:36 ` Florian Westphal [this message]
2021-05-12 8:19 ` [PATCH v2 mptcp-next 1/8] mptcp: enable busypoll from mptcp " Paolo Abeni
2021-05-12 9:08 ` Florian Westphal
2021-05-12 10:04 ` Florian Westphal
2021-05-12 15:06 ` Paolo Abeni
2021-05-14 9:57 ` Florian Westphal
2021-05-14 10:35 ` Paolo Abeni
2021-05-14 10:50 ` Paolo Abeni
2021-05-11 13:36 ` [PATCH v2 mptcp-next 2/8] sock: expose so_timestamp options for mptcp Florian Westphal
2021-05-19 8:58 ` [sock] d1023bc19b: kernel-selftests.net.rxtimestamp.sh.fail kernel test robot
2021-05-11 13:36 ` [PATCH v2 mptcp-next 3/8] sock: expose so_timestamping options for mptcp Florian Westphal
2021-05-11 13:36 ` [PATCH v2 mptcp-next 4/8] mptcp: sockopt: propagate timestamp request to subflows Florian Westphal
2021-05-11 13:36 ` [PATCH v2 mptcp-next 5/8] mptcp: setsockopt: handle SOL_SOCKET in one place only Florian Westphal
2021-05-11 13:36 ` [PATCH v2 mptcp-next 6/8] tcp: export timestamp helpers for mptcp Florian Westphal
2021-05-11 13:36 ` [PATCH v2 mptcp-next 7/8] mptcp: receive path cmsg support Florian Westphal
2021-05-11 13:36 ` [PATCH v2 mptcp-next 8/8] selftests: mptcp_connect: add SO_TIMESTAMPNS " Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210511133659.29982-2-fw@strlen.de \
--to=fw@strlen.de \
--cc=mptcp@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).