From: Florian Westphal <fw@strlen.de>
To: Paolo Abeni <pabeni@redhat.com>
Cc: mptcp@lists.linux.dev, fwestpha@redhat.com
Subject: Re: [PATCH mptcp-net] selftests: mptcp: enable syncookie only in absence of reorders
Date: Thu, 3 Jun 2021 13:29:12 +0200 [thread overview]
Message-ID: <20210603112912.GA7062@breakpoint.cc> (raw)
In-Reply-To: <15333b645caafe2b7fbb028e67bb788c0d5cf526.1622719000.git.pabeni@redhat.com>
Paolo Abeni <pabeni@redhat.com> wrote:
> Syncookie validation may fail for OoO packets, causing spurious
> resets and self-tests failures, so let's force syncookie only
> for tests iteration with no OoO.
>
> Fixes: fed61c4b584c ("selftests: mptcp: make 2nd net namespace use tcp syn cookies unconditionally")
> Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/198
> Signed-off-by: Paolo Abeni <pabeni@redhat.com>
> ---
> tools/testing/selftests/net/mptcp/mptcp_connect.sh | 10 +++++++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/tools/testing/selftests/net/mptcp/mptcp_connect.sh b/tools/testing/selftests/net/mptcp/mptcp_connect.sh
> index 69351c3eb68c..9e53334c9512 100755
> --- a/tools/testing/selftests/net/mptcp/mptcp_connect.sh
> +++ b/tools/testing/selftests/net/mptcp/mptcp_connect.sh
> @@ -202,9 +202,6 @@ ip -net "$ns4" link set ns4eth3 up
> ip -net "$ns4" route add default via 10.0.3.2
> ip -net "$ns4" route add default via dead:beef:3::2
>
> -# use TCP syn cookies, even if no flooding was detected.
> -ip netns exec "$ns2" sysctl -q net.ipv4.tcp_syncookies=2
> -
> if $checksum; then
> for i in "$ns1" "$ns2" "$ns3" "$ns4";do
> ip netns exec $i sysctl -q net.mptcp.checksum_enabled=1
> @@ -748,6 +745,13 @@ for sender in $ns1 $ns2 $ns3 $ns4;do
> exit $ret
> fi
>
> + # force TCP syn cookies only if there is no reorder
> + if [ $sender = $ns1 ]; then
> + ip netns exec "$ns2" sysctl -q net.ipv4.tcp_syncookies=2
I wasn't clear to me at first glance what $sender = $ns1 had to
do with reordering.
Maybe:
# ns1<->ns2 is not subject to reordering/tc delays. Use it to test
# mptcp syncookie support.
?
next prev parent reply other threads:[~2021-06-03 11:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-03 11:17 [PATCH mptcp-net] selftests: mptcp: enable syncookie only in absence of reorders Paolo Abeni
2021-06-03 11:29 ` Florian Westphal [this message]
2021-06-03 14:47 ` Paolo Abeni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210603112912.GA7062@breakpoint.cc \
--to=fw@strlen.de \
--cc=fwestpha@redhat.com \
--cc=mptcp@lists.linux.dev \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).