From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f46.google.com (mail-ej1-f46.google.com [209.85.218.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4DAE772 for ; Thu, 17 Jun 2021 17:42:54 +0000 (UTC) Received: by mail-ej1-f46.google.com with SMTP id g20so11301185ejt.0 for ; Thu, 17 Jun 2021 10:42:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=7MHD7EiSpY3e0ERtwOHvIB+KaRhM2Um7f/06TGmH7Gg=; b=ISiz3+CBB3cS1Fjzms1hdR9IOCuWXdV/3OZsAmuGA0u24iyp1VIHRdmDtsT0ZCTDEr 6xRvIJTzHq19O7CIonVqvqT5KoNboIJFFofrV9S1qL6xWomF76y1mqpy96Ayf09PDu8Y 1F/iId/lDj1MLIEAdk7KjCspqeheaGab+uxzjCKK+tRfDzZi73Scn+qjPBfxHRJniFVl Mh3LLnvEYE8eiKmUVob2T5c0J84jhYChrB+V3br1n5fVFc1nhVxZlUQPGbiF/zQqroVs iwuUT0RO25hRq1026WPDY/sFUqqW89zfqf7etBnfS8mRpohw9uv5ffFsayrcCTX+EUU4 UFAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=7MHD7EiSpY3e0ERtwOHvIB+KaRhM2Um7f/06TGmH7Gg=; b=URLeFgkE0ppLk3YUnc40eFFU64vpNhv0Fr4jX0lcWFF4QK1WePibx6bOQw5rmBAtDR THw5nwMvzmIloybmTmsINPmL+4/HCZwKXDQ+inJrGpnOY97dBzPrT24fY+G4RuguDuQE OHxVC34fZqK8UIPuyduruqhFUBTTWMP3U+i2DcyMhkfin1lz3iy5xMo7RIHue/Uabi7j H0+nBFYKKi78jtOea2qShs5+zpyK8DdLltq23s3EQHL+kHW81ALwFx8DWAqbxJCEq3+H jr75AhIMfVyhLGc1ezDLBM7bxPyhjxYd312WTe2yR7if8SsPGCF1YG1HI2x+GZt8OWEX kJ8A== X-Gm-Message-State: AOAM5311rFUf8wRl8UtyKvJHv0pqpRZepB3HWi8HerX9bqlGWKTXkYsS nO1cFrIRr+Jd/1Qy8Yd+hoE= X-Google-Smtp-Source: ABdhPJwWNLIULh5OpxfozVq/mF6ozU+8u/EdBodGq5HallWZ8jCIVaPdxjyiv0YLWeBZz65OeLTGJQ== X-Received: by 2002:a17:907:3f08:: with SMTP id hq8mr6490774ejc.150.1623951772740; Thu, 17 Jun 2021 10:42:52 -0700 (PDT) Received: from localhost ([185.246.22.209]) by smtp.gmail.com with ESMTPSA id b10sm4776610edf.77.2021.06.17.10.42.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Jun 2021 10:42:52 -0700 (PDT) Date: Thu, 17 Jun 2021 19:42:47 +0200 From: Richard Cochran To: Yangbo Lu Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, mptcp@lists.linux.dev, "David S . Miller" , Jakub Kicinski , Mat Martineau , Matthieu Baerts , Shuah Khan , Michal Kubecek , Florian Fainelli , Andrew Lunn , Rui Sousa , Sebastien Laveze Subject: Re: [net-next, v3, 02/10] ptp: support ptp physical/virtual clocks conversion Message-ID: <20210617174247.GB4770@localhost> References: <20210615094517.48752-1-yangbo.lu@nxp.com> <20210615094517.48752-3-yangbo.lu@nxp.com> X-Mailing-List: mptcp@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210615094517.48752-3-yangbo.lu@nxp.com> User-Agent: Mutt/1.10.1 (2018-07-13) On Tue, Jun 15, 2021 at 05:45:09PM +0800, Yangbo Lu wrote: > diff --git a/Documentation/ABI/testing/sysfs-ptp b/Documentation/ABI/testing/sysfs-ptp > index 2363ad810ddb..2ef11b775f47 100644 > --- a/Documentation/ABI/testing/sysfs-ptp > +++ b/Documentation/ABI/testing/sysfs-ptp > @@ -61,6 +61,19 @@ Description: > This file contains the number of programmable pins > offered by the PTP hardware clock. > > +What: /sys/class/ptp/ptpN/n_vclocks > +Date: May 2021 > +Contact: Yangbo Lu > +Description: > + This file contains the ptp virtual clocks number in use, > + based on current ptp physical clock. In default, the > + value is 0 meaning only ptp physical clock is in use. > + Setting the value can create corresponding number of ptp > + virtual clocks to use. But current ptp physical clock is > + guaranteed to stay free running. Setting the value back > + to 0 can delete ptp virtual clocks and back use ptp > + physical clock again. The native speaker in me suggests: This file contains the number of virtual PTP clocks in use. By default, the value is 0 meaning that only the physical clock is in use. Setting the value creates the corresponding number of virtual clocks and causes the physical clock to become free running. Setting the value back to 0 deletes the virtual clocks and switches the physical clock back to normal, adjustable operation. Thanks, Richard