mptcp.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: Mat Martineau <mathew.j.martineau@linux.intel.com>
To: netdev@vger.kernel.org
Cc: Jianguo Wu <wujianguo@chinatelecom.cn>,
	davem@davemloft.net, kuba@kernel.org,
	matthieu.baerts@tessares.net, pabeni@redhat.com, fw@strlen.de,
	mptcp@lists.linux.dev, kernel test robot <oliver.sang@intel.com>,
	Mat Martineau <mathew.j.martineau@linux.intel.com>
Subject: [PATCH net 5/6] selftests: mptcp: fix case multiple subflows limited by server
Date: Fri,  9 Jul 2021 17:20:50 -0700	[thread overview]
Message-ID: <20210710002051.216010-6-mathew.j.martineau@linux.intel.com> (raw)
In-Reply-To: <20210710002051.216010-1-mathew.j.martineau@linux.intel.com>

From: Jianguo Wu <wujianguo@chinatelecom.cn>

After patch "mptcp: fix syncookie process if mptcp can not_accept new
subflow", if subflow is limited, MP_JOIN SYN is dropped, and no SYN/ACK
will be replied.

So in case "multiple subflows limited by server", the expected SYN/ACK
number should be 1.

Fixes: 00587187ad30 ("selftests: mptcp: add test cases for mptcp join tests with syn cookies")
Reported-by: kernel test robot <oliver.sang@intel.com>
Signed-off-by: Jianguo Wu <wujianguo@chinatelecom.cn>
Signed-off-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
---
 tools/testing/selftests/net/mptcp/mptcp_join.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/net/mptcp/mptcp_join.sh b/tools/testing/selftests/net/mptcp/mptcp_join.sh
index 9a191c1a5de8..f02f4de2f3a0 100755
--- a/tools/testing/selftests/net/mptcp/mptcp_join.sh
+++ b/tools/testing/selftests/net/mptcp/mptcp_join.sh
@@ -1409,7 +1409,7 @@ syncookies_tests()
 	ip netns exec $ns2 ./pm_nl_ctl add 10.0.3.2 flags subflow
 	ip netns exec $ns2 ./pm_nl_ctl add 10.0.2.2 flags subflow
 	run_tests $ns1 $ns2 10.0.1.1
-	chk_join_nr "subflows limited by server w cookies" 2 2 1
+	chk_join_nr "subflows limited by server w cookies" 2 1 1
 
 	# test signal address with cookies
 	reset_with_cookies
-- 
2.32.0


  parent reply	other threads:[~2021-07-10  0:20 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-10  0:20 [PATCH net 0/6] mptcp: Connection and accounting fixes Mat Martineau
2021-07-10  0:20 ` [PATCH net 1/6] mptcp: fix warning in __skb_flow_dissect() when do syn cookie for subflow join Mat Martineau
2021-07-10  0:20 ` [PATCH net 2/6] mptcp: remove redundant req destruct in subflow_check_req() Mat Martineau
2021-07-10  0:20 ` [PATCH net 3/6] mptcp: fix syncookie process if mptcp can not_accept new subflow Mat Martineau
2021-07-10  0:20 ` [PATCH net 4/6] mptcp: avoid processing packet if a subflow reset Mat Martineau
2021-07-10  0:20 ` Mat Martineau [this message]
2021-07-10  0:20 ` [PATCH net 6/6] mptcp: properly account bulk freed memory Mat Martineau
2021-07-10  1:50 ` [PATCH net 0/6] mptcp: Connection and accounting fixes patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210710002051.216010-6-mathew.j.martineau@linux.intel.com \
    --to=mathew.j.martineau@linux.intel.com \
    --cc=davem@davemloft.net \
    --cc=fw@strlen.de \
    --cc=kuba@kernel.org \
    --cc=matthieu.baerts@tessares.net \
    --cc=mptcp@lists.linux.dev \
    --cc=netdev@vger.kernel.org \
    --cc=oliver.sang@intel.com \
    --cc=pabeni@redhat.com \
    --cc=wujianguo@chinatelecom.cn \
    --subject='Re: [PATCH net 5/6] selftests: mptcp: fix case multiple subflows limited by server' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
on how to clone and mirror all data and code used for this inbox