From: Jakub Kicinski <kuba@kernel.org>
To: Mat Martineau <mathew.j.martineau@linux.intel.com>
Cc: netdev@vger.kernel.org, Geliang Tang <geliangtang@gmail.com>,
davem@davemloft.net, matthieu.baerts@tessares.net,
mptcp@lists.linux.dev
Subject: Re: [PATCH net] mptcp: drop unused rcu member in mptcp_pm_addr_entry
Date: Tue, 3 Aug 2021 14:28:55 -0700 [thread overview]
Message-ID: <20210803142855.54590346@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <7ef8acba-2ecc-37ec-165d-ba32b3f3fde@linux.intel.com>
On Tue, 3 Aug 2021 11:11:16 -0700 (PDT) Mat Martineau wrote:
> On Tue, 3 Aug 2021, Jakub Kicinski wrote:
> > On Mon, 2 Aug 2021 16:19:14 -0700 Mat Martineau wrote:
> >> From: Geliang Tang <geliangtang@gmail.com>
> >>
> >> kfree_rcu() had been removed from pm_netlink.c, so this rcu field in
> >> struct mptcp_pm_addr_entry became useless. Let's drop it.
> >>
> >> Fixes: 1729cf186d8a ("mptcp: create the listening socket for new port")
> >> Signed-off-by: Geliang Tang <geliangtang@gmail.com>
> >> Signed-off-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
> >
> > This just removes a superfluous member, right? So could as well be
> > applied to net-next?
>
> Hi Jakub -
>
> Yes, it's just a superfluous member.
>
> It seemed like a -net candidate, as it was addressing a mistake in a
> previous commit (rather than a feature or refactor) and does affect memory
> usage - and I was trying to be mindful of the stable tree process. But the
> patch will apply cleanly to either net or net-next, so you could apply to
> net-next if the fix is not significant enough.
>
> I'll tune my net-vs-net-next threshold based on the tree I see it applied
> to :)
Alright, applied but without the Fixes tag. Thanks!
prev parent reply other threads:[~2021-08-03 21:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-02 23:19 [PATCH net] mptcp: drop unused rcu member in mptcp_pm_addr_entry Mat Martineau
2021-08-03 15:21 ` Jakub Kicinski
2021-08-03 18:11 ` Mat Martineau
2021-08-03 21:28 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210803142855.54590346@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=geliangtang@gmail.com \
--cc=mathew.j.martineau@linux.intel.com \
--cc=matthieu.baerts@tessares.net \
--cc=mptcp@lists.linux.dev \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).