mptcp.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: Geliang Tang <geliang.tang@suse.com>
To: Matthieu Baerts <matthieu.baerts@tessares.net>
Cc: mptcp@lists.linux.dev
Subject: Re: selftests/bpf: add bpf_rr test: Build Failure
Date: Thu, 2 Jun 2022 06:25:56 +0800	[thread overview]
Message-ID: <20220601222556.GA3368@bogon.HOST> (raw)
In-Reply-To: <0e945e4c-212f-bf6f-04ce-50d32bb6e330@tessares.net>

Hi Matt,

On Wed, Jun 01, 2022 at 05:04:24PM +0200, Matthieu Baerts wrote:
> Hi Geliang,
> 
> Thank you for the new version!
> 
> On 01/06/2022 16:21, MPTCP CI wrote:
> > Hi Geliang,
> > 
> > Thank you for your modifications, that's great!
> > 
> > But sadly, our CI spotted some issues with it when trying to build it.
> > 
> > You can find more details there:
> > 
> >   https://patchwork.kernel.org/project/mptcp/patch/94de6d463bde36d3ad8e50324b9c40ce9ae36467.1654092153.git.geliang.tang@suse.com/
> >   https://github.com/multipath-tcp/mptcp_net-next/actions/runs/2422165357
> 
> Regarding these errors, are they normal? I mean: will they be removed
> after having applied the different Squash-to patch?

Yes, they will be removed after having applied all the squash-to patches.

> 
> I guess for these ones yes:
> 
>   net/mptcp/sched.c: In function 'mptcp_sched_data_init':
>   net/mptcp/sched.c:94:6: error: 'struct mptcp_sched_data' has no member
> named 'sock'
>      94 |  data->sock = NULL;
>         |      ^~
>   (...)

This will be removed by "Squash to "mptcp: add get_subflow wrappers"".

> 
> 
> But also for these ones?
> 
>   In file included from ./include/uapi/linux/posix_types.h:5,
>                    from ./include/uapi/linux/types.h:14,
>                    from ./include/linux/types.h:6,
>                    from ./include/uapi/linux/bpf.h:11,
>                    from ./include/linux/bpf.h:7,
>                    from net/mptcp/bpf.c:12:
>   net/mptcp/bpf.c: In function 'bpf_mptcp_sched_btf_struct_access':
>   ./include/linux/stddef.h:16:32: error: 'struct mptcp_sched_data' has
> no member named 'sock'
>      16 | #define offsetof(TYPE, MEMBER) __builtin_offsetof(TYPE, MEMBER)
>         |                                ^~~~~~~~~~~~~~~~~~
>   net/mptcp/bpf.c:55:7: note: in expansion of macro 'offsetof'
>      55 |  case offsetof(struct mptcp_sched_data, sock):
>         |       ^~~~~~~~
>   (...)

And this will be removed by "Squash to "mptcp: add bpf_mptcp_sched_ops"".

Thanks,
-Geliang

> 
> 
> Cheers,
> Matt
> -- 
> Tessares | Belgium | Hybrid Access Solutions
> www.tessares.net
> 


  reply	other threads:[~2022-06-01 22:25 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-01 14:08 [PATCH mptcp-next v6 00/11] BPF packet scheduler Geliang Tang
2022-06-01 14:08 ` [PATCH mptcp-next v6 01/11] Squash to "mptcp: add struct mptcp_sched_ops" Geliang Tang
2022-06-01 14:08 ` [PATCH mptcp-next v6 02/11] Squash to "mptcp: add sched in mptcp_sock" Geliang Tang
2022-06-01 14:08 ` [PATCH mptcp-next v6 03/11] Squash to "mptcp: add get_subflow wrappers" Geliang Tang
2022-06-01 14:08 ` [PATCH mptcp-next v6 04/11] Squash to "mptcp: add bpf_mptcp_sched_ops" Geliang Tang
2022-06-01 14:08 ` [PATCH mptcp-next v6 05/11] mptcp: add subflow_set_scheduled helper Geliang Tang
2022-06-02  0:23   ` Mat Martineau
2022-06-01 14:08 ` [PATCH mptcp-next v6 06/11] Squash to "selftests/bpf: add bpf_first scheduler" Geliang Tang
2022-06-01 14:08 ` [PATCH mptcp-next v6 07/11] Squash to "selftests/bpf: add bpf_first test" Geliang Tang
2022-06-01 14:08 ` [PATCH mptcp-next v6 08/11] selftests/bpf: add bpf_bkup scheduler Geliang Tang
2022-06-01 14:08 ` [PATCH mptcp-next v6 09/11] selftests/bpf: add bpf_bkup test Geliang Tang
2022-06-01 14:08 ` [PATCH mptcp-next v6 10/11] selftests/bpf: add bpf_rr scheduler Geliang Tang
2022-06-01 14:08 ` [PATCH mptcp-next v6 11/11] selftests/bpf: add bpf_rr test Geliang Tang
2022-06-01 14:21   ` selftests/bpf: add bpf_rr test: Build Failure MPTCP CI
2022-06-01 15:04     ` Matthieu Baerts
2022-06-01 22:25       ` Geliang Tang [this message]
2022-06-01 16:02   ` selftests/bpf: add bpf_rr test: Tests Results MPTCP CI
2022-06-02  0:02 ` [PATCH mptcp-next v6 00/11] BPF packet scheduler Mat Martineau
  -- strict thread matches above, loose matches on Subject: below --
2022-06-02  4:53 [PATCH mptcp-next v7 13/13] selftests/bpf: Add bpf_rr test Geliang Tang
2022-06-02  5:20 ` selftests/bpf: Add bpf_rr test: Build Failure MPTCP CI
2022-06-01  6:46 [PATCH mptcp-next v5 11/11] selftests/bpf: add bpf_rr test Geliang Tang
2022-06-01  6:57 ` selftests/bpf: add bpf_rr test: Build Failure MPTCP CI
2022-05-31  9:09 [PATCH mptcp-next v4 10/10] selftests/bpf: add bpf_rr test Geliang Tang
2022-05-31  9:21 ` selftests/bpf: add bpf_rr test: Build Failure MPTCP CI
2022-05-28 15:11 [PATCH mptcp-next v3 10/10] selftests/bpf: add bpf_rr test Geliang Tang
2022-05-28 15:21 ` selftests/bpf: add bpf_rr test: Build Failure MPTCP CI

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220601222556.GA3368@bogon.HOST \
    --to=geliang.tang@suse.com \
    --cc=matthieu.baerts@tessares.net \
    --cc=mptcp@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).