From: Matthieu Baerts <matthieu.baerts@tessares.net>
To: Paolo Abeni <pabeni@redhat.com>,
Mat Martineau <mathew.j.martineau@linux.intel.com>
Cc: mptcp@lists.linux.dev
Subject: Re: [PATCH v2 mptcp-net] mptcp: fix bad handling of 32 bit ack wrap-around.
Date: Thu, 17 Jun 2021 15:22:05 +0200 [thread overview]
Message-ID: <4184691c-684a-e188-b829-07667694756a@tessares.net> (raw)
In-Reply-To: <140f8561f1ba22d171c1acc35812b571b63c8836.1623831447.git.pabeni@redhat.com>
Hi Paolo, Mat,
On 16/06/2021 10:19, Paolo Abeni wrote:
> When receiving 32 bits DSS ack from the peer, the MPTCP need
> to expand them to 64 bits value. The current code is buggy
> WRT detecting 32 bits ack wrap-around: when the wrap-around
> happens the current unsigned 32 bit ack value is lower than
> the previous one.
>
> Additionally check for possible reverse wrap and make the helper
> visible, so that we could re-use it for the next patch.
>
> Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/204
> Fixes: cc9d25669866 ("mptcp: update per unacked sequence on pkt reception")
> Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Thank you for the patch and the review!
Now in the tree with Mat's RvB tag and without a dot at the end of the
commit title ;)
- 5345fa174b03: mptcp: fix bad handling of 32 bit ack wrap-around
- Results: 8c0eaeab091c..035a752fa93d
Builds and tests are now in progress:
https://cirrus-ci.com/github/multipath-tcp/mptcp_net-next/export/20210617T132140
https://github.com/multipath-tcp/mptcp_net-next/actions/workflows/build-validation.yml?query=branch:export/20210617T132140
Cheers,
Matt
--
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net
prev parent reply other threads:[~2021-06-17 13:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-16 8:19 [PATCH v2 mptcp-net] mptcp: fix bad handling of 32 bit ack wrap-around Paolo Abeni
2021-06-17 0:05 ` Mat Martineau
2021-06-17 13:22 ` Matthieu Baerts [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4184691c-684a-e188-b829-07667694756a@tessares.net \
--to=matthieu.baerts@tessares.net \
--cc=mathew.j.martineau@linux.intel.com \
--cc=mptcp@lists.linux.dev \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).