From: Paolo Abeni <pabeni@redhat.com>
To: Mat Martineau <mathew.j.martineau@linux.intel.com>,
Matthieu Baerts <matthieu.baerts@tessares.net>,
Geliang Tang <geliang.tang@suse.com>,
mptcp@lists.linux.dev
Subject: Re: Should the MIB_RMSUBFLOW commit go to -net?
Date: Fri, 24 Jun 2022 10:40:43 +0200 [thread overview]
Message-ID: <437af8add242099c84cf106108ab4988a65010ff.camel@redhat.com> (raw)
In-Reply-To: <ad151d35-f094-675d-5ced-71df98ea5857@linux.intel.com>
On Thu, 2022-06-23 at 16:19 -0700, Mat Martineau wrote:
> I was preparing the patches we had agreed to be ready for net-next in the
> meeting today:
>
> - [f1eb3f2cb4d2] mptcp: update MIB_RMSUBFLOW in cmd_sf_destroy (Geliang Tang)
> - [f3c5dde10031] selftests: mptcp: userspace pm address tests (Geliang Tang)
> - [92378ff55152] selftests: mptcp: userspace pm subflow tests (Geliang Tang)
> - [1908a4ccaa2c] selftests: mptcp: avoid Terminated messages in userspace_pm (Geliang Tang)
> - [bac5548c7c47] selftests: mptcp: update pm_nl_ctl usage header (Geliang Tang)
>
> I think the selftest commits are definitely best for net-next. But for the
> first one ("mptcp: update MIB_RMSUBFLOW in cmd_sf_destroy"), should we add
>
> Fixes: 702c2f646d42 ("mptcp: netlink: allow userspace-driven subflow establishment")
>
> and include that in a patch set for -net? Seems like it would be good to
> improve the MIB accuracy with the userspace PM in 5.19.
>
> Link to commit in patchwork:
> https://patchwork.kernel.org/project/mptcp/patch/723d61d82730b996132925686b43f9c3c79bc747.1655355422.git.geliang.tang@suse.com/
>
>
> If that patch goes to -net, it would also require waiting until the next
> net/net-next sync before sending the selftest patches listed above.
I would vote for keeping the process simple and keeping all the above
patches on net-next.
If we choose otherwise, I think we should also update a bit the
("mptcp: update MIB_RMSUBFLOW in cmd_sf_destroy") commit message to
something more tuned for -net. Alike: "The user-space patch manager
currently miss the required update of the subflow destruction MIB,
address the issue "...
/P
next prev parent reply other threads:[~2022-06-24 8:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-23 23:19 Should the MIB_RMSUBFLOW commit go to -net? Mat Martineau
2022-06-24 8:40 ` Paolo Abeni [this message]
2022-06-24 15:04 ` Matthieu Baerts
2022-06-29 19:13 ` Mat Martineau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=437af8add242099c84cf106108ab4988a65010ff.camel@redhat.com \
--to=pabeni@redhat.com \
--cc=geliang.tang@suse.com \
--cc=mathew.j.martineau@linux.intel.com \
--cc=matthieu.baerts@tessares.net \
--cc=mptcp@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).