Re: [PATCH v5 1/4] mptcp: fix warning in __skb_flow_dissect() when do syn cookie for subflow join

[Mat Martineau <mathew.j.martineau@linux.intel.com>]

On Mon, 21 Jun 2021, Jianguo Wu wrote:

>
>
> On 2021/6/21 14:14, Jianguo Wu wrote:
>> Hi Mat,
>>
>> On 2021/6/19 6:40, Mat Martineau wrote:
>>>
>>> On Wed, 16 Jun 2021, wujianguo106@163.com wrote:
>>>
>>>> From: Jianguo Wu <wujianguo@chinatelecom.cn>
>>>>
>>>> I got the following warning message while doing the test:
>>>
>>> Hi Jianguo, thanks for your patch set and revisions.
>>>
>>> Could you explain some more about which test produced the following result? Was it one of the self tests?
>>>
>>> If this is triggered by test code that is not upstream yet, it would help to add a selftest that shows if this bug is present or fixed. A packetdrill test is also an option, if that is a better way to reproduce the error.
>>>
>>
>> I tested with wrk(https://github.com/wg/wrk) and webfsd(https://github.com/ourway/webfsd) with the assistance of mptcp-tools(https://github.com/pabeni/mptcp-tools),
>> Server side:
>>     ./use_mptcp.sh webfsd -4 -R /tmp/ -p 8099
>> Client side:
>>     ./use_mptcp.sh wrk -c 200 -d 30 -t 4 http://192.168.174.129:8099/
>>
>> I will try self tests.
>>
>
> Hi Mat,
>
> It can not be reproduced with selftests(./mptcp_join.sh -k), because skb->l4_hash is 1 in this scenario,
> and direct using skb->hash, so __skb_flow_dissect() isn't called.
>

Thanks for the information! We hadn't seen the failures with the self 
tests so it's good to know that wrk and webfsd were useful for stress 
testing.

--
Mat Martineau
Intel